Add spec.revisionHistoryLimit config possibility for Deployment resource (#122)

* Add spec.revisionHistoryLimit config possibility for Deployment resource

Signed-off-by: Marcel Hoyer <mhoyer@pixelplastic.de>

* Fix order of values in README.md

Signed-off-by: Marcel Hoyer <mhoyer@pixelplastic.de>

---------

Signed-off-by: Marcel Hoyer <mhoyer@pixelplastic.de>
This commit is contained in:
Marcel Hoyer 2023-07-11 10:54:30 +02:00 committed by GitHub
parent 111933e163
commit 2c1c880636
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 14 additions and 2 deletions

View File

@ -38,4 +38,4 @@ sources:
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.1.3
version: 1.2.0

View File

@ -2,7 +2,7 @@
# Backstage Helm Chart
[![Artifact Hub](https://img.shields.io/endpoint?url=https://artifacthub.io/badge/repository/backstage)](https://artifacthub.io/packages/search?repo=backstage)
![Version: 1.1.3](https://img.shields.io/badge/Version-1.1.3-informational?style=flat-square)
![Version: 1.2.0](https://img.shields.io/badge/Version-1.2.0-informational?style=flat-square)
![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
A Helm chart for deploying a Backstage application
@ -142,6 +142,7 @@ Kubernetes: `>= 1.19.0-0`
| backstage.readinessProbe | Readiness Probe Backstage doesn't provide any health endpoints by default. A simple one can be added like this: https://backstage.io/docs/plugins/observability/#health-checks <br /> Ref: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes <!-- E.g. readinessProbe: failureThreshold: 3 httpGet: path: /healthcheck port: 7007 scheme: HTTP initialDelaySeconds: 30 periodSeconds: 10 successThreshold: 2 timeoutSeconds: 2 | object | `{}` |
| backstage.replicas | Number of deployment replicas | int | `1` |
| backstage.resources | Resource requests/limits <br /> Ref: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#resource-requests-and-limits-of-pod-and-container <!-- E.g. resources: limits: memory: 1Gi cpu: 1000m requests: memory: 250Mi cpu: 100m --> | object | `{}` |
| backstage.revisionHistoryLimit | Define the [count of deployment revisions](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#clean-up-policy) to be kept. May be set to 0 in case of GitOps deployment approach. | int | `10` |
| backstage.tolerations | Node tolerations for server scheduling to nodes with taints <br /> Ref: https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/ | list | `[]` |
| clusterDomain | Default Kubernetes cluster domain | string | `"cluster.local"` |
| commonAnnotations | Annotations to add to all deployed objects | object | `{}` |

View File

@ -21,6 +21,7 @@ metadata:
{{- end }}
spec:
replicas: {{ .Values.backstage.replicas }}
revisionHistoryLimit: {{ .Values.backstage.revisionHistoryLimit }}
selector:
matchLabels: {{- include "common.labels.matchLabels" . | nindent 6 }}
app.kubernetes.io/component: backstage

View File

@ -174,6 +174,12 @@
"minimum": 0,
"default": 1
},
"revisionHistoryLimit": {
"title": "The count of deployment revisions",
"type": "integer",
"minimum": 0,
"default": 10
},
"image": {
"title": "Image parameters",
"type": "object",

View File

@ -83,6 +83,10 @@ backstage:
# -- Number of deployment replicas
replicas: 1
# -- Define the [count of deployment revisions](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#clean-up-policy) to be kept.
# May be set to 0 in case of GitOps deployment approach.
revisionHistoryLimit: 10
image:
# -- Backstage image registry