URL encode db username and password (#4133)

Closes #4129

Signed-off-by: Sergio Castaño Arteaga <tegioz@icloud.com>
This commit is contained in:
Sergio Castaño Arteaga 2024-11-05 09:14:05 +01:00 committed by GitHub
parent 927ac73d60
commit c252af9157
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 10 additions and 9 deletions

View File

@ -2,7 +2,7 @@ apiVersion: v2
name: artifact-hub
description: Artifact Hub is a web-based application that enables finding, installing, and publishing Cloud Native packages.
type: application
version: 1.20.0
version: 1.21.0-0
appVersion: 1.20.0
kubeVersion: ">= 1.19.0-0"
home: https://artifacthub.io

View File

@ -15,8 +15,8 @@ stringData:
host: {{ default (printf "%s-postgresql.%s" .Release.Name .Release.Namespace) .Values.db.host }}
port: {{ .Values.db.port }}
database: {{ .Values.db.database }}
user: {{ .Values.db.user }}
password: {{ .Values.db.password }}
user: {{ .Values.db.user | quote }}
password: {{ .Values.db.password | quote }}
email:
fromName: {{ .Values.email.fromName }}
from: {{ .Values.email.from }}

View File

@ -16,8 +16,8 @@ stringData:
host: {{ default (printf "%s-postgresql.%s" .Release.Name .Release.Namespace) .Values.db.host }}
port: {{ .Values.db.port }}
database: {{ .Values.db.database }}
user: {{ .Values.db.user }}
password: {{ .Values.db.password }}
user: {{ .Values.db.user | quote }}
password: {{ .Values.db.password | quote }}
creds:
dockerUsername: {{ .Values.creds.dockerUsername }}
dockerPassword: {{ .Values.creds.dockerPassword }}

View File

@ -15,8 +15,8 @@ stringData:
host: {{ default (printf "%s-postgresql.%s" .Release.Name .Release.Namespace) .Values.db.host }}
port: {{ .Values.db.port }}
database: {{ .Values.db.database }}
user: {{ .Values.db.user }}
password: {{ .Values.db.password }}
user: {{ .Values.db.user | quote }}
password: {{ .Values.db.password | quote }}
creds:
dockerUsername: {{ .Values.creds.dockerUsername }}
dockerPassword: {{ .Values.creds.dockerPassword }}

View File

@ -5,6 +5,7 @@ import (
"encoding/json"
"errors"
"fmt"
"net/url"
"time"
"github.com/artifacthub/hub/internal/hub"
@ -31,8 +32,8 @@ var (
func SetupDB(cfg *viper.Viper) (*pgxpool.Pool, error) {
// Setup pool config
url := fmt.Sprintf("postgres://%s:%s@%s:%s/%s",
cfg.GetString("db.user"),
cfg.GetString("db.password"),
url.QueryEscape(cfg.GetString("db.user")),
url.QueryEscape(cfg.GetString("db.password")),
cfg.GetString("db.host"),
cfg.GetString("db.port"),
cfg.GetString("db.database"),