From 684f94e20d48ccc07515b434892228dd6e4866f4 Mon Sep 17 00:00:00 2001 From: Pablo Caderno Date: Fri, 8 Oct 2021 16:55:08 +1100 Subject: [PATCH] return 404 code when delete not exist experiment (#96) Signed-off-by: Pablo Caderno --- pkg/server/httpserver/server.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pkg/server/httpserver/server.go b/pkg/server/httpserver/server.go index df84792..cc9512c 100644 --- a/pkg/server/httpserver/server.go +++ b/pkg/server/httpserver/server.go @@ -20,6 +20,7 @@ import ( "github.com/joomcode/errorx" "github.com/pingcap/log" "go.uber.org/zap" + "gorm.io/gorm" "github.com/chaos-mesh/chaosd/pkg/config" "github.com/chaos-mesh/chaosd/pkg/core" @@ -272,6 +273,10 @@ func (s *httpServer) recoverAttack(c *gin.Context) { } func handleError(c *gin.Context, err error) { + if err == gorm.ErrRecordNotFound { + _ = c.AbortWithError(http.StatusNotFound, utils.ErrNotFound.WrapWithNoMessage(err)) + return + } if errorx.IsOfType(err, core.ErrAttackConfigValidation) { _ = c.AbortWithError(http.StatusBadRequest, utils.ErrInvalidRequest.WrapWithNoMessage(err)) } else {