Merge pull request #11 from friism/clean-code

Clean code
This commit is contained in:
Clemens Vasters 2019-09-17 06:34:14 -07:00 committed by GitHub
commit a2be3fb00e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 6 deletions

View File

@ -6,7 +6,6 @@ namespace HttpSend
{ {
using System; using System;
using System.ComponentModel.DataAnnotations; using System.ComponentModel.DataAnnotations;
using System.Net;
using System.Net.Http; using System.Net.Http;
using System.Net.Mime; using System.Net.Mime;
using System.Threading.Tasks; using System.Threading.Tasks;

View File

@ -116,7 +116,7 @@ namespace CloudNative.CloudEvents
var response = await client.GetAsync(new Uri(uri)); var response = await client.GetAsync(new Uri(uri));
return new HttpResponseMessage(response.StatusCode); return new HttpResponseMessage(response.StatusCode);
} }
catch (Exception e) catch (Exception)
{ {
return new HttpResponseMessage(HttpStatusCode.InternalServerError); return new HttpResponseMessage(HttpStatusCode.InternalServerError);
} }
@ -175,7 +175,7 @@ namespace CloudNative.CloudEvents
context.Response.Close(); context.Response.Close();
return; return;
} }
catch (Exception e) catch (Exception)
{ {
context.Response.StatusCode = (int)HttpStatusCode.InternalServerError; context.Response.StatusCode = (int)HttpStatusCode.InternalServerError;
context.Response.Close(); context.Response.Close();
@ -271,7 +271,7 @@ namespace CloudNative.CloudEvents
/// </summary> /// </summary>
/// <param name="httpListenerRequest">Listener request</param> /// <param name="httpListenerRequest">Listener request</param>
/// <param name="extensions">List of extension instances</param> /// <param name="extensions">List of extension instances</param>
/// <returns>A CloudEvent instance or 'null' if the response message doesn't hold a CloudEvent</returns> /// <returns>A CloudEvent instance or 'null' if the request message doesn't hold a CloudEvent</returns>
public static CloudEvent ToCloudEvent(this HttpListenerRequest httpListenerRequest, public static CloudEvent ToCloudEvent(this HttpListenerRequest httpListenerRequest,
params ICloudEventExtension[] extensions) params ICloudEventExtension[] extensions)
{ {
@ -285,7 +285,7 @@ namespace CloudNative.CloudEvents
/// <param name="httpListenerRequest">Listener request</param> /// <param name="httpListenerRequest">Listener request</param>
/// <param name="formatter"></param> /// <param name="formatter"></param>
/// <param name="extensions">List of extension instances</param> /// <param name="extensions">List of extension instances</param>
/// <returns>A CloudEvent instance or 'null' if the response message doesn't hold a CloudEvent</returns> /// <returns>A CloudEvent instance or 'null' if the request message doesn't hold a CloudEvent</returns>
public static CloudEvent ToCloudEvent(this HttpListenerRequest httpListenerRequest, public static CloudEvent ToCloudEvent(this HttpListenerRequest httpListenerRequest,
ICloudEventFormatter formatter = null, ICloudEventFormatter formatter = null,
params ICloudEventExtension[] extensions) params ICloudEventExtension[] extensions)
@ -370,7 +370,7 @@ namespace CloudNative.CloudEvents
/// <param name="httpListenerRequest">Listener request</param> /// <param name="httpListenerRequest">Listener request</param>
/// <param name="formatter"></param> /// <param name="formatter"></param>
/// <param name="extensions">List of extension instances</param> /// <param name="extensions">List of extension instances</param>
/// <returns>A CloudEvent instance or 'null' if the response message doesn't hold a CloudEvent</returns> /// <returns>A CloudEvent instance or 'null' if the request message doesn't hold a CloudEvent</returns>
public static CloudEvent ToCloudEvent(this HttpRequestMessage httpListenerRequest, public static CloudEvent ToCloudEvent(this HttpRequestMessage httpListenerRequest,
ICloudEventFormatter formatter = null, ICloudEventFormatter formatter = null,
params ICloudEventExtension[] extensions) params ICloudEventExtension[] extensions)