cloudevents
/
sdk-csharp
mirror of https://github.com/cloudevents/sdk-csharp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Comment-only review changes 

Signed-off-by: Jon Skeet <jonskeet@google.com>
This commit is contained in:
Jon Skeet 2021-02-11 07:50:11 +00:00 committed by Jon Skeet
parent 33552a13f6
commit ab2a9b6448
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/CloudNative.CloudEvents/CloudEvent.cs
View File

@ -9,6 +9,7 @@ using System.Linq;
namespace CloudNative.CloudEvents namespace CloudNative.CloudEvents
{ {
// TODO: Document really clearly that the SpecVersion attribute isn't included anywhere here... // TODO: Document really clearly that the SpecVersion attribute isn't included anywhere here...
// TODO: Consider implementing IDictionary<,>
/// <summary> /// <summary>
/// Represents a CloudEvent. /// Represents a CloudEvent.
@ -161,7 +162,6 @@ namespace CloudNative.CloudEvents
return; return;
} }
// TODO: We could convert the attribute value here instead? Or is that a bit too much "magic"? // TODO: We could convert the attribute value here instead? Or is that a bit too much "magic"?
// TODO: Should we validate the value against the
attributeValues[name] = attribute.Validate(value); attributeValues[name] = attribute.Validate(value);
} }
} }