cloudevents
/
sdk-csharp
mirror of https://github.com/cloudevents/sdk-csharp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix warnings around async methods/lambda expressions 

Signed-off-by: Jon Skeet <jonskeet@google.com>
This commit is contained in:
Jon Skeet 2020-06-05 11:00:20 +01:00
parent b0f3c06a5f
commit b2c918ee0c
2 changed files with 12 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/CloudNative.CloudEvents.Avro/AvroEventFormatter.cs
View File

@ -40,9 +40,9 @@ namespace CloudNative.CloudEvents
return DecodeStructuredEvent(data, (IEnumerable<ICloudEventExtension>)extensions);
}
public async Task<CloudEvent> DecodeStructuredEventAsync(Stream data, IEnumerable<ICloudEventExtension> extensions)
public Task<CloudEvent> DecodeStructuredEventAsync(Stream data, IEnumerable<ICloudEventExtension> extensions)
{
return DecodeStructuredEvent(data, extensions);
return Task.FromResult(DecodeStructuredEvent(data, extensions));
}
public CloudEvent DecodeStructuredEvent(Stream data, IEnumerable<ICloudEventExtension> extensions = null)

19
test/CloudNative.CloudEvents.UnitTests/HttpTest.cs
View File

@ -33,11 +33,11 @@ namespace CloudNative.CloudEvents.UnitTests
Prefixes = { listenerAddress }
};
listener.Start();
listener.GetContextAsync().ContinueWith(t =>
listener.GetContextAsync().ContinueWith(async t =>
{
if (t.IsCompleted)
{
HandleContext(t.Result);
await HandleContext(t.Result);
}
});
}
@ -61,15 +61,13 @@ namespace CloudNative.CloudEvents.UnitTests
{
await pending(requestContext);
}
#pragma warning disable 4014
listener.GetContextAsync().ContinueWith(t =>
await listener.GetContextAsync().ContinueWith(async t =>
{
if (t.IsCompleted)
{
HandleContext(t.Result);
await HandleContext(t.Result);
}
});
#pragma warning restore 4014
}
[Fact]
@ -161,7 +159,7 @@ namespace CloudNative.CloudEvents.UnitTests
var content = new CloudEventContent(cloudEvent, ContentMode.Binary, new JsonEventFormatter());
content.Headers.Add(testContextHeader, ctx);
pendingRequests.TryAdd(ctx, async context =>
pendingRequests.TryAdd(ctx, context =>
{
try
{
@ -196,6 +194,7 @@ namespace CloudNative.CloudEvents.UnitTests
}
context.Response.Close();
return Task.CompletedTask;
});
var httpClient = new HttpClient();
@ -282,7 +281,7 @@ namespace CloudNative.CloudEvents.UnitTests
var content = new CloudEventContent(cloudEvent, ContentMode.Structured, new JsonEventFormatter());
content.Headers.Add(testContextHeader, ctx);
pendingRequests.TryAdd(ctx, async context =>
pendingRequests.TryAdd(ctx, context =>
{
try
{
@ -313,6 +312,7 @@ namespace CloudNative.CloudEvents.UnitTests
}
context.Response.Close();
return Task.CompletedTask;
});
var httpClient = new HttpClient();
@ -344,7 +344,7 @@ namespace CloudNative.CloudEvents.UnitTests
await httpWebRequest.CopyFromAsync(cloudEvent, ContentMode.Structured, new JsonEventFormatter());
httpWebRequest.Headers.Add(testContextHeader, ctx);
pendingRequests.TryAdd(ctx, async context =>
pendingRequests.TryAdd(ctx, context =>
{
try
{
@ -373,6 +373,7 @@ namespace CloudNative.CloudEvents.UnitTests
}
context.Response.Close();
return Task.CompletedTask;
});
var result = (HttpWebResponse)await httpWebRequest.GetResponseAsync();