Commit Graph

11 Commits

Author SHA1 Message Date
Jon Skeet 14cb9f5c02 Fix Kafka test which was broken by xUnit upgrade
The production code behavior hasn't changed here, but Assert.Equal used to pass when presented with an empty string and an empty byte array.

Signed-off-by: Jon Skeet <jonskeet@google.com>
2024-08-02 09:43:18 +01:00
Jon Skeet d9831a393d Update unit test parameter nullability
Signed-off-by: Jon Skeet <jonskeet@google.com>
2024-08-02 09:43:15 +01:00
Jon Skeet ae75b32c28 chore: Fix whitespace in all files
These changes were generated automatically by running "Analyze and Code Cleanup".

Showing a diff ignoring whitespace shows the removal of the UTF-8 BOM from three files, but that's all.

Signed-off-by: Jon Skeet <jonskeet@google.com>
2023-11-14 12:20:57 +00:00
Magne Helleborg 81c82e04c6
feat: Allow empty payloads in Kafka, in order to support compaction tombstones (#224)
Signed-off-by: Magne Helleborg <magne.helleborg@gmail.com>
2022-08-30 09:18:51 +01:00
Jon Skeet b1f29cf25b Support data content type inference
- New methods in CloudEventFormatter to support inference
- JsonEventFormatter infers a content type of application/json for non-binary data
- All transports use the inferred content type when formatting in binary mode
- Documentation for both formatters and bindings has been updated

Signed-off-by: Jon Skeet <jonskeet@google.com>
2022-02-25 07:11:13 +00:00
Jon Skeet e7ebdd7c1c Enable nullable reference types for unit test project
Signed-off-by: Jon Skeet <jonskeet@google.com>
2021-07-10 07:03:43 +01:00
Jon Skeet 62da9c0779 Fix case sensitivity issues
- Web hook method must be exactly "OPTIONS"
- Kafka header keys are case sensitive

Fixes #90

Signed-off-by: Jon Skeet <jonskeet@google.com>
2021-05-21 20:20:13 +01:00
Jon Skeet 7f6fa9380b fix: Make Kafka binary mode conversion use event formatter
Fixes #103, by always delegating to event formatters. (We'll provide
guidance on how those should handle data.)

Signed-off-by: Jon Skeet <jonskeet@google.com>
2021-03-16 11:23:34 +00:00
Jon Skeet 72a5dc31f4 Remove unnecessary inheritance for Kafka messages
Signed-off-by: Jon Skeet <jonskeet@google.com>
2021-03-01 08:56:48 +00:00
Jon Skeet 8b63348296 feat: Extract the existing JSON event formatter from the main SDK
This allows us to remove the Newtonsoft.Json dependency from the
SDK, and implement another event formatter based on System.Text.Json
later on. That should probably wait until we've iterated on the
design of event formatters though.

This commit moves us closer towards (but doesn't fix) #42.

Signed-off-by: Jon Skeet <jonskeet@google.com>
2021-02-13 06:42:43 +00:00
Jon Skeet 70b5ae99fd Overhaul of codebase with new approach to attributes
This touches almost file in the repository, because it's hard not to
with such a fundamental change.

There are *lots* of TODOs now, all of which we should chase down
before release. In most cases this isn't a new problem - it's just
one that wasn't noted before,

The two main changes are:

- Spec versions, attributes, and attributes types are now first-class
  types. Rather than being able to set attributes to any value you
  want, values have to be of the right type and have a valid value
  (e.g. for datacontenttype). This centralizes value conversion
  for the most part (although transport/format-specific conversions
  may still be required) and makes everything more predictable.
- Extensions are now *not* first-class types; instead, the extension
  attributes can be registered with the CloudEvent in order to perform
  appropriate validation etc, and a pattern around extensions
  providing extension methods on CloudEvent allows them to be used
  easily.

This work has revealed a lot of smaller problems, such as the HTTP
transports propagating a content of "null" (rather than no content)
when no data was set in the CloudEvent. More testing is certainly
required.

It's worth noting that this is a really big breaking change. The 2.0
release was already going to be breaking, but this is much larger
than the previous changes. I assert that the benefits outweight the
costs though, and even though the package already has many users,
we hope there will be many times more users in the future.

Proposed process for this PR:

- This initial commit does not include nearly as many unit tests for
  CloudEvent, CloudEventAttribute or CloudEventAttributeType as I'd
  like. Those will come in a follow-up commit (which should be
  reviewed before merging) but don't affect the review of the overall
  ideas.
- If the general thrust of this PR is acceptable, then I propose we
  merge it, only making changes to the most egregious problems, and
  leaving further clean-up work (of which there's likely to be a lot)
  to later PRs. It's easier to create a clean-up PR in Visual Studio
  than to suggest fixes via GitHub.

Style changes:

- Use explicit access modifiers
- Move using directives before the namespace declaration
- Unit tests are generally more separated out to correspond to
  production classes, and are in separate directories/namespaces
  by project instead of all at the top level.

Currently StyleCop is not installed, but we should probably either
do that or use regular Roslyn analyzers in the long term - along
with turning on XML documentation generation.

Signed-off-by: Jon Skeet <jonskeet@google.com>
2021-02-11 07:57:38 +00:00