cloudevents
/
sdk-javascript
mirror of https://github.com/cloudevents/sdk-javascript.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

lib: correct name of CONTENT_ENCODING constant (#168) 

Signed-off-by: Daniel Bevenius <daniel.bevenius@gmail.com>
This commit is contained in:
Daniel Bevenius 2020-05-18 15:44:58 +02:00 committed by GitHub
parent d836b06ffe
commit b99e6ea228
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/bindings/http/constants.js
View File

@ -32,7 +32,7 @@ module.exports = Object.freeze({
ID: "ce-id", ID: "ce-id",
TIME: "ce-time", TIME: "ce-time",
SCHEMA_URL: "ce-schemaurl", SCHEMA_URL: "ce-schemaurl",
CONTENT_ENCONDING: "ce-datacontentencoding", CONTENT_ENCODING: "ce-datacontentencoding",
SUBJECT: "ce-subject", SUBJECT: "ce-subject",
EXTENSIONS_PREFIX: "ce-" EXTENSIONS_PREFIX: "ce-"
}, },
@ -43,7 +43,7 @@ module.exports = Object.freeze({
ID: "id", ID: "id",
TIME: "time", TIME: "time",
SCHEMA_URL: "schemaurl", SCHEMA_URL: "schemaurl",
CONTENT_ENCONDING: "datacontentencoding", CONTENT_ENCODING: "datacontentencoding",
CONTENT_TYPE: "datacontenttype", CONTENT_TYPE: "datacontenttype",
SUBJECT: "subject", SUBJECT: "subject",
DATA: "data" DATA: "data"

2
lib/bindings/http/emitter_binary_0_3.js
View File

@ -11,7 +11,7 @@ headerByGetter.getDataContentType = {
}; };
headerByGetter.getDataContentEncoding = { headerByGetter.getDataContentEncoding = {
name: BINARY_HEADERS_03.CONTENT_ENCONDING, name: BINARY_HEADERS_03.CONTENT_ENCODING,
parser: (v) => v parser: (v) => v
}; };

4
lib/bindings/http/receiver_binary_0_3.js
View File

@ -67,7 +67,7 @@ setterByHeader[Constants.HEADER_CONTENT_TYPE] = {
name: "dataContentType", name: "dataContentType",
parser: (v) => v parser: (v) => v
}; };
setterByHeader[Constants.BINARY_HEADERS_03.CONTENT_ENCONDING] = { setterByHeader[Constants.BINARY_HEADERS_03.CONTENT_ENCODING] = {
name: "dataContentEncoding", name: "dataContentEncoding",
parser: (v) => v parser: (v) => v
}; };
@ -82,7 +82,7 @@ function checkDecorator(payload, headers) {
Object.keys(headers) Object.keys(headers)
.map((header) => header.toLocaleLowerCase("en-US")) .map((header) => header.toLocaleLowerCase("en-US"))
.filter((header) => .filter((header) =>
header === Constants.BINARY_HEADERS_03.CONTENT_ENCONDING) header === Constants.BINARY_HEADERS_03.CONTENT_ENCODING)
.filter((header) => !allowedEncodings.includes(headers[header])) .filter((header) => !allowedEncodings.includes(headers[header]))
.forEach((header) => { .forEach((header) => {
// TODO: using forEach here seems off // TODO: using forEach here seems off

4
test/bindings/http/unmarshaller_0_3_tests.js
View File

@ -183,7 +183,7 @@ describe("HTTP Transport Binding Unmarshaller for CloudEvents v0.3", () => {
[BINARY_HEADERS_03.TIME]: "2019-06-16T11:42:00Z", [BINARY_HEADERS_03.TIME]: "2019-06-16T11:42:00Z",
[BINARY_HEADERS_03.SCHEMA_URL]: "http://schema.registry/v1", [BINARY_HEADERS_03.SCHEMA_URL]: "http://schema.registry/v1",
[HEADER_CONTENT_TYPE]: "application/json", [HEADER_CONTENT_TYPE]: "application/json",
[BINARY_HEADERS_03.CONTENT_ENCONDING]: BINARY [BINARY_HEADERS_03.CONTENT_ENCODING]: BINARY
}; };
expect(() => un.unmarshall(payload, attributes)).to expect(() => un.unmarshall(payload, attributes)).to
@ -205,7 +205,7 @@ describe("HTTP Transport Binding Unmarshaller for CloudEvents v0.3", () => {
[BINARY_HEADERS_03.TIME]: "2019-06-16T11:42:00Z", [BINARY_HEADERS_03.TIME]: "2019-06-16T11:42:00Z",
[BINARY_HEADERS_03.SCHEMA_URL]: "http://schema.registry/v1", [BINARY_HEADERS_03.SCHEMA_URL]: "http://schema.registry/v1",
[HEADER_CONTENT_TYPE]: "application/json", [HEADER_CONTENT_TYPE]: "application/json",
[BINARY_HEADERS_03.CONTENT_ENCONDING]: "base64" [BINARY_HEADERS_03.CONTENT_ENCODING]: "base64"
}; };
const event = un.unmarshall(payload, attributes); const event = un.unmarshall(payload, attributes);

4
test/constants_test.js
View File

@ -92,7 +92,7 @@ describe("Constants exposed by top level exports", () => {
expect(BINARY_HEADERS_03.SCHEMA_URL).to.equal("ce-schemaurl"); expect(BINARY_HEADERS_03.SCHEMA_URL).to.equal("ce-schemaurl");
}); });
it("Provides a CONTENT_ENCODING header", () => { it("Provides a CONTENT_ENCODING header", () => {
expect(BINARY_HEADERS_03.CONTENT_ENCONDING).to.equal("ce-datacontentencoding"); expect(BINARY_HEADERS_03.CONTENT_ENCODING).to.equal("ce-datacontentencoding");
}); });
it("Provides a SUBJECT header", () => { it("Provides a SUBJECT header", () => {
expect(BINARY_HEADERS_03.SUBJECT).to.equal("ce-subject"); expect(BINARY_HEADERS_03.SUBJECT).to.equal("ce-subject");
@ -121,7 +121,7 @@ describe("Constants exposed by top level exports", () => {
expect(STRUCTURED_ATTRS_03.SCHEMA_URL).to.equal("schemaurl"); expect(STRUCTURED_ATTRS_03.SCHEMA_URL).to.equal("schemaurl");
}); });
it("Provides a CONTENT_ENCODING attribute", () => { it("Provides a CONTENT_ENCODING attribute", () => {
expect(STRUCTURED_ATTRS_03.CONTENT_ENCONDING).to.equal("datacontentencoding"); expect(STRUCTURED_ATTRS_03.CONTENT_ENCODING).to.equal("datacontentencoding");
}); });
it("Provides a SUBJECT attribute", () => { it("Provides a SUBJECT attribute", () => {
expect(STRUCTURED_ATTRS_03.SUBJECT).to.equal("subject"); expect(STRUCTURED_ATTRS_03.SUBJECT).to.equal("subject");