cloudevents
/
sdk-javascript
mirror of https://github.com/cloudevents/sdk-javascript.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

lib: make HTTPEmitter headers method a property of the class (#186) 

Signed-off-by: Lance Ball <lball@redhat.com>
This commit is contained in:
Lance Ball 2020-05-24 13:03:40 -04:00 committed by GitHub
parent abc114b24e
commit f50e80fbf6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 31 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lib/bindings/http/http_emitter.js
View File

@ -1,5 +1,7 @@
const BinaryHTTPEmitter = require("./emitter_binary.js"); const BinaryHTTPEmitter = require("./emitter_binary.js");
const StructuredEmitter = require("./emitter_structured.js"); const StructuredEmitter = require("./emitter_structured.js");
const EmitterV1 = require("./v1").BinaryEmitter;
const EmitterV03 = require("./v03").BinaryEmitter;
/** @typedef {import("../../cloudevent")} CloudEvent */ /** @typedef {import("../../cloudevent")} CloudEvent */
@ -66,18 +68,25 @@ class HTTPEmitter {
} }
throw new TypeError(`Unknown transport mode ${mode}.`); throw new TypeError(`Unknown transport mode ${mode}.`);
} }
}
/** /**
* Returns the HTTP headers that will be sent for this event when the HTTP transmission * Returns the HTTP headers that will be sent for this event when the HTTP transmission
* mode is "binary". Events sent over HTTP in structured mode only have a single CE header * mode is "binary". Events sent over HTTP in structured mode only have a single CE header
* and that is "ce-id", corresponding to the event ID. * and that is "ce-id", corresponding to the event ID.
* @param {CloudEvent} event a CloudEvent * @param {CloudEvent} event a CloudEvent
* @param {string} [version] spec version number - default 1.0
* @returns {Object} the headers that will be sent for the event * @returns {Object} the headers that will be sent for the event
*/ */
headers(event) { function headers(event, version = SPEC_V1) {
const headers = {}; const headers = {};
let headerMap;
this.binary.headerParserMap.forEach((parser, getterName) => { if (version === SPEC_V1) {
headerMap = EmitterV1;
} else if (version === SPEC_V03) {
headerMap = EmitterV03;
}
headerMap.forEach((parser, getterName) => {
const value = event[getterName]; const value = event[getterName];
if (value) { if (value) {
headers[parser.headerName] = parser.parse(value); headers[parser.headerName] = parser.parse(value);
@ -86,6 +95,6 @@ class HTTPEmitter {
return headers; return headers;
} }
}
HTTPEmitter.headers = headers;
module.exports = HTTPEmitter; module.exports = HTTPEmitter;

7
test/bindings/http/http_emitter_test.js
View File

@ -11,9 +11,6 @@ const {
const { CloudEvent, HTTPEmitter } = require("../../../"); const { CloudEvent, HTTPEmitter } = require("../../../");
const V1Spec = require("../../../lib/bindings/http/v1").Spec;
const V03Spec = require("../../../lib/bindings/http/v03").Spec;
const receiver = "https://cloudevents.io/"; const receiver = "https://cloudevents.io/";
const type = "com.example.test"; const type = "com.example.test";
const source = "urn:event:from:myapi/resource/123"; const source = "urn:event:from:myapi/resource/123";
@ -67,7 +64,7 @@ describe("HTTP Transport Binding Emitter for CloudEvents", () => {
}); });
it("Provides the HTTP headers for a binary event", () => { it("Provides the HTTP headers for a binary event", () => {
const headers = emitter.headers(event); const headers = HTTPEmitter.headers(event);
expect(headers[BINARY_HEADERS_1.TYPE]).to.equal(event.type); expect(headers[BINARY_HEADERS_1.TYPE]).to.equal(event.type);
expect(headers[BINARY_HEADERS_1.SPEC_VERSION]).to.equal(event.specversion); expect(headers[BINARY_HEADERS_1.SPEC_VERSION]).to.equal(event.specversion);
expect(headers[BINARY_HEADERS_1.SOURCE]).to.equal(event.source); expect(headers[BINARY_HEADERS_1.SOURCE]).to.equal(event.source);
@ -140,7 +137,7 @@ describe("HTTP Transport Binding Emitter for CloudEvents", () => {
}); });
it("Provides the HTTP headers for a binary event", () => { it("Provides the HTTP headers for a binary event", () => {
const headers = emitter.headers(event); const headers = HTTPEmitter.headers(event, SPEC_V03);
expect(headers[BINARY_HEADERS_03.TYPE]).to.equal(event.type); expect(headers[BINARY_HEADERS_03.TYPE]).to.equal(event.type);
expect(headers[BINARY_HEADERS_03.SPEC_VERSION]).to.equal(event.specversion); expect(headers[BINARY_HEADERS_03.SPEC_VERSION]).to.equal(event.specversion);
expect(headers[BINARY_HEADERS_03.SOURCE]).to.equal(event.source); expect(headers[BINARY_HEADERS_03.SOURCE]).to.equal(event.source);