cloudevents
/
sdk-python
mirror of https://github.com/cloudevents/sdk-python.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Adding type info to Converter interface. 

Signed-off-by: Evan Anderson <argent@google.com>
This commit is contained in:
Evan Anderson 2019-01-14 00:21:49 +00:00
parent d90a4861f9
commit 47873fbca1
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cloudevents/sdk/converters/base.py
View File

@ -25,10 +25,10 @@ class Converter(object):
data_unmarshaller: typing.Callable) -> base.BaseEvent: data_unmarshaller: typing.Callable) -> base.BaseEvent:
raise Exception("not implemented") raise Exception("not implemented")
def event_supported(self, event): def event_supported(self, event: object) -> bool:
raise Exception("not implemented") raise Exception("not implemented")
def can_read(self, content_type): def can_read(self, content_type: str) -> bool:
raise Exception("not implemented") raise Exception("not implemented")
def write(self, event: base.BaseEvent, def write(self, event: base.BaseEvent,

4
cloudevents/sdk/converters/binary.py
View File

@ -25,10 +25,10 @@ class BinaryHTTPCloudEventConverter(base.Converter):
TYPE = "binary" TYPE = "binary"
SUPPORTED_VERSIONS = [v02.Event, ] SUPPORTED_VERSIONS = [v02.Event, ]
def can_read(self, content_type): def can_read(self, content_type: str) -> bool:
return True return True
def event_supported(self, event): def event_supported(self, event: object) -> bool:
return type(event) in self.SUPPORTED_VERSIONS return type(event) in self.SUPPORTED_VERSIONS
def read(self, def read(self,

4
cloudevents/sdk/converters/structured.py
View File

@ -23,10 +23,10 @@ class JSONHTTPCloudEventConverter(base.Converter):
TYPE = "structured" TYPE = "structured"
MIME_TYPE = "application/cloudevents+json" MIME_TYPE = "application/cloudevents+json"
def can_read(self, content_type): def can_read(self, content_type: str) -> bool:
return content_type and content_type.startswith(self.MIME_TYPE) return content_type and content_type.startswith(self.MIME_TYPE)
def event_supported(self, event): def event_supported(self, event: object) -> bool:
# structured format supported by both spec 0.1 and 0.2 # structured format supported by both spec 0.1 and 0.2
return True return True