From 494170b997175ca0ce71ebc91f5f35d1f9a0896c Mon Sep 17 00:00:00 2001 From: Alexander Tkachev Date: Mon, 11 Jul 2022 14:05:24 +0300 Subject: [PATCH] test: cloudevent equality bug regression (#171) Signed-off-by: Alexander Tkachev --- cloudevents/tests/test_http_cloudevent.py | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/cloudevents/tests/test_http_cloudevent.py b/cloudevents/tests/test_http_cloudevent.py index 11337e0..fd409f1 100644 --- a/cloudevents/tests/test_http_cloudevent.py +++ b/cloudevents/tests/test_http_cloudevent.py @@ -45,6 +45,18 @@ def non_exiting_attribute_name(dummy_event): return result +@pytest.fixture( + params=( + 1, + None, + object(), + "Hello World", + ) +) +def non_cloudevent_value(request): + return request.param + + def test_http_cloudevent_equality(dummy_attributes, my_dummy_data, your_dummy_data): data = my_dummy_data event1 = CloudEvent(dummy_attributes, data) @@ -69,6 +81,16 @@ def test_http_cloudevent_equality(dummy_attributes, my_dummy_data, your_dummy_da assert event1 != event2 and event3 != event1 +def test_http_cloudevent_equality_must_not_throw(dummy_event, non_cloudevent_value): + assert isinstance(dummy_event == non_cloudevent_value, bool) + + +def test_http_cloudevent_must_not_equal_to_non_cloudevent_value( + dummy_event, non_cloudevent_value +): + assert not dummy_event == non_cloudevent_value + + def test_http_cloudevent_mutates_equality( dummy_attributes, my_dummy_data, your_dummy_data ):