cloudevents
/
sdk-python
mirror of https://github.com/cloudevents/sdk-python.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix small bug with extensions (#25) 

* Add a failing test

Signed-off-by: Dustin Ingram <di@users.noreply.github.com>

* fix small bug with extensions

Signed-off-by: ryandawsonuk <rd@seldon.io>

Co-authored-by: Dustin Ingram <di@users.noreply.github.com>
This commit is contained in:
Ryan Dawson 2020-04-20 23:52:14 +01:00 committed by GitHub
parent 173ed417d8
commit 76654a98ed
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cloudevents/sdk/event/base.py
View File

@ -154,7 +154,7 @@ class BaseEvent(EventGetterSetter):
if value is not None:
headers["ce-{0}".format(key)] = value
for key, value in props.get("extensions"):
for key, value in props.get("extensions").items():
headers["ce-{0}".format(key)] = value
data, _ = self.Get("data")

15
cloudevents/tests/test_event_pipeline.py
View File

@ -37,6 +37,7 @@ def test_event_pipeline_upstream():
)
m = marshaller.NewDefaultHTTPMarshaller()
new_headers, body = m.ToRequest(event, converters.TypeBinary, lambda x: x)
assert new_headers is not None
assert "ce-specversion" in new_headers
assert "ce-type" in new_headers
@ -48,6 +49,20 @@ def test_event_pipeline_upstream():
assert data.body == body
def test_extensions_are_set_upstream():
extensions = {'extension-key': 'extension-value'}
event = (
v02.Event()
.SetExtensions(extensions)
)
m = marshaller.NewDefaultHTTPMarshaller()
new_headers, body = m.ToRequest(event, converters.TypeBinary, lambda x: x)
assert event.Extensions() == extensions
assert "ce-extension-key" in new_headers
def test_event_pipeline_v01():
event = (
v01.Event()