From fa0d72f516ced0feceafbeff90bfaf9bbb6421fb Mon Sep 17 00:00:00 2001 From: Maksym Pavlenko Date: Thu, 24 Feb 2022 11:46:22 -0800 Subject: [PATCH] Fix clippy warnings Signed-off-by: Maksym Pavlenko --- crates/runc-shim/src/service.rs | 10 ++++------ crates/shim/src/lib.rs | 2 ++ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/crates/runc-shim/src/service.rs b/crates/runc-shim/src/service.rs index 4545c8e..89ee63a 100644 --- a/crates/runc-shim/src/service.rs +++ b/crates/runc-shim/src/service.rs @@ -57,15 +57,13 @@ impl Shim for Service { _publisher: RemotePublisher, _config: &mut Config, ) -> Self { - let mut service = Service { + // TODO: add publisher + + Service { exit: Arc::new(ExitSignal::default()), id: id.to_string(), namespace: namespace.to_string(), - }; - - // TODO: add publisher - - service + } } fn start_shim(&mut self, opts: StartOpts) -> Result { diff --git a/crates/shim/src/lib.rs b/crates/shim/src/lib.rs index ddc0ea1..e3c7912 100644 --- a/crates/shim/src/lib.rs +++ b/crates/shim/src/lib.rs @@ -113,9 +113,11 @@ pub struct StartOpts { /// Helper structure that wraps atomic bool to signal shim server when to shutdown the TTRPC server. /// /// Shim implementations are responsible for calling [`Self::signal`]. +#[allow(clippy::mutex_atomic)] // Condvar expected to be used with Mutex, not AtomicBool. #[derive(Default)] pub struct ExitSignal(Mutex, Condvar); +#[allow(clippy::mutex_atomic)] impl ExitSignal { /// Set exit signal to shutdown shim server. pub fn signal(&self) {