From a525f15fc3a1f5f306cdf7ec7988eb95f6b5c07d Mon Sep 17 00:00:00 2001 From: Ygal Blum Date: Mon, 4 Dec 2023 14:32:14 +0200 Subject: [PATCH] Image copier: make sure ReportWriter is not nil before accessing When running in Quiet mode, the ReportWriter can be nil causing a crash Signed-off-by: Ygal Blum --- common/libimage/copier.go | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/common/libimage/copier.go b/common/libimage/copier.go index d6acc73250..1edf7d6cb9 100644 --- a/common/libimage/copier.go +++ b/common/libimage/copier.go @@ -364,11 +364,13 @@ func (c *copier) copy(ctx context.Context, source, destination types.ImageRefere defer cancel() defer timer.Stop() - fmt.Fprintf(c.imageCopyOptions.ReportWriter, - "Pulling image %s inside systemd: setting pull timeout to %s\n", - source.StringWithinTransport(), - time.Duration(numExtensions)*extension, - ) + if c.imageCopyOptions.ReportWriter != nil { + fmt.Fprintf(c.imageCopyOptions.ReportWriter, + "Pulling image %s inside systemd: setting pull timeout to %s\n", + source.StringWithinTransport(), + time.Duration(numExtensions)*extension, + ) + } // From `man systemd.service(5)`: //