Merge pull request #6478 from rhatdan/abisupport

Remove use of ABISupport buildtag

Makefile

@@ -22,7 +22,7 @@ ETCDIR ?= /etc
 TMPFILESDIR ?= ${PREFIX}/lib/tmpfiles.d
 SYSTEMDDIR ?= ${PREFIX}/lib/systemd/system
 USERSYSTEMDDIR ?= ${PREFIX}/lib/systemd/user
-REMOTETAGS ?= !ABISupport remote exclude_graphdriver_btrfs btrfs_noversion exclude_graphdriver_devicemapper containers_image_openpgp
+REMOTETAGS ?= remote exclude_graphdriver_btrfs btrfs_noversion exclude_graphdriver_devicemapper containers_image_openpgp
 BUILDTAGS ?= \
 	$(shell hack/apparmor_tag.sh) \
 	$(shell hack/btrfs_installed_tag.sh) \
@@ -44,7 +44,7 @@ ifeq ($(shell go help mod >/dev/null 2>&1 && echo true), true)
 	GO_BUILD=GO111MODULE=on $(GO) build -mod=vendor
 endif
 
-BUILDTAGS_CROSS ?= ABISupport containers_image_openpgp exclude_graphdriver_btrfs exclude_graphdriver_devicemapper exclude_graphdriver_overlay
+BUILDTAGS_CROSS ?= containers_image_openpgp exclude_graphdriver_btrfs exclude_graphdriver_devicemapper exclude_graphdriver_overlay
 ifneq (,$(findstring varlink,$(BUILDTAGS)))
 	PODMAN_VARLINK_DEPENDENCIES = pkg/varlink/iopodman.go
 endif
@@ -185,7 +185,7 @@ ifeq (,$(findstring systemd,$(BUILDTAGS)))
 	@echo "Podman is being compiled without the systemd build tag. Install libsystemd on \
 		Ubuntu or systemd-devel on rpm based distro for journald support."
 endif
-	$(GO_BUILD) $(BUILDFLAGS) -gcflags '$(GCFLAGS)' -asmflags '$(ASMFLAGS)' -ldflags '$(LDFLAGS_PODMAN)' -tags "ABISupport $(BUILDTAGS)" -o $@ $(PROJECT)/cmd/podman
+	$(GO_BUILD) $(BUILDFLAGS) -gcflags '$(GCFLAGS)' -asmflags '$(ASMFLAGS)' -ldflags '$(LDFLAGS_PODMAN)' -tags "$(BUILDTAGS)" -o $@ $(PROJECT)/cmd/podman
 
 .PHONY: podman
 podman: bin/podman

cmd/podman/registry/config_abi.go

@@ -1,4 +1,4 @@
-// +build ABISupport
+// +build !remote
 
 package registry
 

cmd/podman/registry/config_tunnel.go

@@ -1,4 +1,4 @@
-// +build !ABISupport
+// +build remote
 
 package registry
 

cmd/podman/system/service_abi.go

@@ -1,4 +1,4 @@
-// +build ABISupport,!remote
+// +build linux,!remote
 
 package system
 

cmd/podman/system/service_unsupported.go

@@ -1,14 +0,0 @@
-// +build !ABISupport,!remote
-
-package system
-
-import (
-	"errors"
-
-	"github.com/containers/libpod/pkg/domain/entities"
-	"github.com/spf13/pflag"
-)
-
-func restService(opts entities.ServiceOptions, flags *pflag.FlagSet, cfg *entities.PodmanConfig) error {
-	return errors.New("not supported")
-}

hack/golangci-lint.sh

@@ -5,12 +5,12 @@
 declare -A BUILD_TAGS
 # TODO: add systemd tag
 BUILD_TAGS[default]="apparmor,seccomp,selinux"
-BUILD_TAGS[abi]="${BUILD_TAGS[default]},ABISupport,varlink,!remoteclient"
-BUILD_TAGS[tunnel]="${BUILD_TAGS[default]},!ABISupport,varlink,remoteclient"
+BUILD_TAGS[abi]="${BUILD_TAGS[default]},varlink,!remoteclient"
+BUILD_TAGS[tunnel]="${BUILD_TAGS[default]},remote,varlink,remoteclient"
 
 declare -A SKIP_DIRS
 SKIP_DIRS[abi]=""
-# TODO: add "ABISupport" build tag to pkg/api
+# TODO: add "remote" build tag to pkg/api
 SKIP_DIRS[tunnel]="pkg/api"
 
 [[ $1 == run ]] && shift

pkg/domain/infra/abi/manifest.go

@@ -1,4 +1,4 @@
-// +build ABISupport
+// +build !remote
 
 package abi
 

pkg/domain/infra/runtime_abi.go

@@ -1,4 +1,4 @@
-// +build ABISupport
+// +build !remote
 
 package infra
 

pkg/domain/infra/runtime_abi_unsupported.go

@@ -1,4 +1,4 @@
-// +build !ABISupport
+// +build remote
 
 package infra
 

pkg/domain/infra/runtime_libpod.go

@@ -1,4 +1,4 @@
-// +build ABISupport
+// +build !remote
 
 package infra
 

pkg/domain/infra/runtime_proxy.go

@@ -1,4 +1,4 @@
-// +build ABISupport
+// +build !remote
 
 package infra
 

pkg/domain/infra/runtime_tunnel.go

@@ -1,4 +1,4 @@
-// +build !ABISupport
+// +build remote
 
 package infra