test/e2e: do not remove CNI directory
This is not safe at all when run in parallel, CNI needs that directory
to detect duplicated ips and also stores other important network info in
it. Removing it while container network is setup is not safe at all and
could cause a lot of weird flakes.
This "hack" was added in commit 55508c11 but provides zero context what
this was supposed to fix so I don't know what the actual issue is or was.
Fixes #18399
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This commit is contained in:
parent
3f5f906903
commit
5026545803
|
|
@ -24,8 +24,6 @@ var _ = Describe("Podman create with --ip flag", func() {
|
||||||
}
|
}
|
||||||
podmanTest = PodmanTestCreate(tempdir)
|
podmanTest = PodmanTestCreate(tempdir)
|
||||||
podmanTest.Setup()
|
podmanTest.Setup()
|
||||||
// Clean up the CNI networks used by the tests
|
|
||||||
os.RemoveAll("/var/lib/cni/networks/podman")
|
|
||||||
})
|
})
|
||||||
|
|
||||||
AfterEach(func() {
|
AfterEach(func() {
|
||||||
|
|
|
||||||
|
|
@ -24,8 +24,6 @@ var _ = Describe("Podman run with --mac-address flag", func() {
|
||||||
}
|
}
|
||||||
podmanTest = PodmanTestCreate(tempdir)
|
podmanTest = PodmanTestCreate(tempdir)
|
||||||
podmanTest.Setup()
|
podmanTest.Setup()
|
||||||
// Clean up the CNI networks used by the tests
|
|
||||||
os.RemoveAll("/var/lib/cni/networks/podman")
|
|
||||||
})
|
})
|
||||||
|
|
||||||
AfterEach(func() {
|
AfterEach(func() {
|
||||||
|
|
|
||||||
|
|
@ -28,8 +28,6 @@ var _ = Describe("Podman run with --ip flag", func() {
|
||||||
}
|
}
|
||||||
podmanTest = PodmanTestCreate(tempdir)
|
podmanTest = PodmanTestCreate(tempdir)
|
||||||
podmanTest.Setup()
|
podmanTest.Setup()
|
||||||
// Clean up the CNI networks used by the tests
|
|
||||||
os.RemoveAll("/var/lib/cni/networks/podman")
|
|
||||||
})
|
})
|
||||||
|
|
||||||
AfterEach(func() {
|
AfterEach(func() {
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue