Merge pull request #21636 from jakecorrenti/inspectinfo-hostuser

machine: Remove unnecessary TODOs
This commit is contained in:
openshift-merge-bot[bot] 2024-02-22 10:29:51 +00:00 committed by GitHub
commit 669e718561
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 1 additions and 4 deletions

View File

@ -96,8 +96,7 @@ func inspect(cmd *cobra.Command, args []string) error {
SSHConfig: mc.SSH,
State: state,
UserModeNetworking: provider.UserModeNetworkEnabled(mc),
// TODO I think this should be the HostUser
Rootful: mc.HostUser.Rootful,
Rootful: mc.HostUser.Rootful,
}
vms = append(vms, ii)

View File

@ -21,7 +21,6 @@ func (a *AppleHVStubber) Remove(mc *vmconfigs.MachineConfig) ([]string, func() e
mc.Lock()
defer mc.Unlock()
// TODO we could delete the vfkit pid/log files if we wanted to be thorough
return []string{}, func() error { return nil }, nil
}

View File

@ -306,7 +306,6 @@ func getMCsOverProviders(vmstubbers []vmconfigs.VMProvider) (map[string]*vmconfi
}
// Stop stops the machine as well as supporting binaries/processes
// TODO: I think this probably needs to go somewhere that remove can call it.
func Stop(mc *vmconfigs.MachineConfig, mp vmconfigs.VMProvider, dirs *machineDefine.MachineDirs, hardStop bool) error {
// state is checked here instead of earlier because stopping a stopped vm is not considered
// an error. so putting in one place instead of sprinkling all over.