'docker run' with no argument no longer hardcodes a default image and command
This commit is contained in:
parent
12905cfcdd
commit
72cbaaa5a1
|
@ -806,24 +806,12 @@ func (srv *Server) CmdRun(stdin io.ReadCloser, stdout io.Writer, args ...string)
|
||||||
if err := cmd.Parse(args); err != nil {
|
if err := cmd.Parse(args); err != nil {
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
if cmd.NArg() < 2 {
|
||||||
|
cmd.Usage()
|
||||||
|
return nil
|
||||||
|
}
|
||||||
name := cmd.Arg(0)
|
name := cmd.Arg(0)
|
||||||
var cmdline []string
|
cmdline := cmd.Args()[1:]
|
||||||
|
|
||||||
if len(cmd.Args()) >= 2 {
|
|
||||||
cmdline = cmd.Args()[1:]
|
|
||||||
}
|
|
||||||
// Choose a default image if needed
|
|
||||||
if name == "" {
|
|
||||||
name = "base"
|
|
||||||
}
|
|
||||||
|
|
||||||
// Choose a default command if needed
|
|
||||||
if len(cmdline) == 0 {
|
|
||||||
*fl_stdin = true
|
|
||||||
*fl_tty = true
|
|
||||||
cmdline = []string{"/bin/bash", "-i"}
|
|
||||||
}
|
|
||||||
|
|
||||||
// Create new container
|
// Create new container
|
||||||
container, err := srv.runtime.Create(cmdline[0], cmdline[1:], name,
|
container, err := srv.runtime.Create(cmdline[0], cmdline[1:], name,
|
||||||
&Config{
|
&Config{
|
||||||
|
|
Loading…
Reference in New Issue