containers
/
automation-tests
mirror of https://github.com/containers/automation-tests.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #9524 from riyad/apiv3-print-tags-when-building 

[Compat API] Also print successfully tagging images in /build endpoint
This commit is contained in:
OpenShift Merge Robot 2021-03-11 17:55:00 +01:00 committed by GitHub
parent e2d35e55d0 ba319e3ba6
commit 8d33bfabaa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/api/handlers/compat/images_build.go
View File

@ -445,6 +445,13 @@ loop:
logrus.Warnf("Failed to json encode error %v", err) logrus.Warnf("Failed to json encode error %v", err)
} }
flush() flush()
for _, tag := range query.Tag {
m.Stream = fmt.Sprintf("Successfully tagged %s\n", tag)
if err := enc.Encode(m); err != nil {
logrus.Warnf("Failed to json encode error %v", err)
}
flush()
}
} }
} }
break loop break loop

2
pkg/api/server/register_images.go
View File

@ -652,6 +652,7 @@ func (s *APIServer) registerImagesHandlers(r *mux.Router) error {
// example: | // example: |
// (build details...) // (build details...)
// Successfully built 8ba084515c724cbf90d447a63600c0a6 // Successfully built 8ba084515c724cbf90d447a63600c0a6
// Successfully tagged your_image:latest
// 400: // 400:
// $ref: "#/responses/BadParamError" // $ref: "#/responses/BadParamError"
// 500: // 500:
@ -1485,7 +1486,6 @@ func (s *APIServer) registerImagesHandlers(r *mux.Router) error {
// description: output from build process // description: output from build process
// example: | // example: |
// (build details...) // (build details...)
// Successfully built 8ba084515c724cbf90d447a63600c0a6
// 400: // 400:
// $ref: "#/responses/BadParamError" // $ref: "#/responses/BadParamError"
// 500: // 500: