Merge pull request from baude/commitimage

make image reference for commit optional
This commit is contained in:
OpenShift Merge Robot 2020-01-30 17:10:20 -08:00 committed by GitHub
commit ba1d1304a6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 4 deletions
cmd/podman
docs/source/markdown

View File

@ -56,12 +56,15 @@ func commitCmd(c *cliconfig.CommitValues) error {
defer runtime.DeferredShutdown(false)
args := c.InputArgs
if len(args) != 2 {
return errors.Errorf("you must provide a container name or ID and a target image name")
if len(args) < 1 {
return errors.Errorf("you must provide a container name or ID and optionally a target image name")
}
container := args[0]
reference := args[1]
reference := ""
if len(args) > 1 {
reference = args[1]
}
if c.Flag("change").Changed {
for _, change := range c.Change {
splitChange := strings.Split(strings.ToUpper(change), "=")

View File

@ -6,7 +6,7 @@ podman\-commit - Create new image based on the changed container
## SYNOPSIS
**podman commit** [*options*] *container* *image*
**podman container commit** [*options*] *container* *image*
**podman container commit** [*options*] *container* [*image*]
## DESCRIPTION
**podman commit** creates an image based on a changed container. The author of the