containers
/
automation-tests
mirror of https://github.com/containers/automation-tests.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

WIP: Fix remote logs 

Docker compatibility  - logs endpoint does not write stream headers if container has a tty

Signed-off-by: Ashley Cui <acui@redhat.com>
This commit is contained in:
Ashley Cui 2020-09-16 13:53:15 -04:00
parent 0d14d7b715
commit e1ac8d9aa2
1 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
pkg/api/handlers/compat/containers_logs.go
View File

@ -105,6 +105,18 @@ func LogsFromContainer(w http.ResponseWriter, r *http.Request) {
var frame strings.Builder var frame strings.Builder
header := make([]byte, 8) header := make([]byte, 8)
writeHeader := true
// Docker does not write stream headers iff the container has a tty.
if !utils.IsLibpodRequest(r) {
inspectData, err := ctnr.Inspect(false)
if err != nil {
utils.InternalServerError(w, errors.Wrapf(err, "Failed to obtain logs for Container '%s'", name))
return
}
writeHeader = !inspectData.Config.Tty
}
for line := range logChannel { for line := range logChannel {
if _, found := r.URL.Query()["until"]; found { if _, found := r.URL.Query()["until"]; found {
if line.Time.After(until) { if line.Time.After(until) {
@ -138,10 +150,13 @@ func LogsFromContainer(w http.ResponseWriter, r *http.Request) {
} }
frame.WriteString(line.Msg) frame.WriteString(line.Msg)
binary.BigEndian.PutUint32(header[4:], uint32(frame.Len())) if writeHeader {
if _, err := w.Write(header[0:8]); err != nil { binary.BigEndian.PutUint32(header[4:], uint32(frame.Len()))
log.Errorf("unable to write log output header: %q", err) if _, err := w.Write(header[0:8]); err != nil {
log.Errorf("unable to write log output header: %q", err)
}
} }
if _, err := io.WriteString(w, frame.String()); err != nil { if _, err := io.WriteString(w, frame.String()); err != nil {
log.Errorf("unable to write frame string: %q", err) log.Errorf("unable to write frame string: %q", err)
} }