Daniel J Walsh
47ef35244c
remove fchmodat2 from seccomp.json file
...
This syscall is proposed for the kernel but does not exists yet. Having it in
the default syscall table is causing crun to print warning messages.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-09-21 07:57:43 -04:00
OpenShift Merge Robot
0ddca34c49
Merge pull request #312 from rhatdan/conn
...
Add support for CONTAINER_CONNECTION environment variable
2020-09-18 03:18:42 -04:00
Daniel J Walsh
00631f7fa2
Add support for CONTAINER_CONNECTION environment variable
...
Users on the MAC have pointed out that they could have multiple connections
to different servers, and they asked to be able to specify the connection
name via environmnet variable rather then to always have to specify the
connection on the command line if they did not want to use the default
setting.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-09-16 07:06:04 -04:00
Daniel J Walsh
d6cb241bed
Merge pull request #310 from containers/dependabot/go_modules/github.com/containers/image/v5-5.6.0
...
Bump github.com/containers/image/v5 from 5.5.2 to 5.6.0
2020-09-15 15:50:33 -04:00
dependabot-preview[bot]
5ea76e34fc
Bump github.com/containers/image/v5 from 5.5.2 to 5.6.0
...
Bumps [github.com/containers/image/v5](https://github.com/containers/image ) from 5.5.2 to 5.6.0.
- [Release notes](https://github.com/containers/image/releases )
- [Commits](https://github.com/containers/image/compare/v5.5.2...v5.6.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-09-15 06:08:00 -04:00
OpenShift Merge Robot
e824610e92
Merge pull request #308 from rhatdan/VERSION
...
Fix problems found by codespell
2020-09-13 16:52:59 -04:00
OpenShift Merge Robot
03032a3e9e
Merge pull request #309 from rhatdan/pidfd
...
Allow pidfd_getfd by default in seccomp.json
2020-09-13 13:46:41 -04:00
Daniel J Walsh
d3e2a9fb55
Allow pidfd_getfd by default in seccomp.json
...
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-09-12 07:44:52 -04:00
Daniel J Walsh
fd6f9bf750
Fix problems found by codespell
...
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-09-12 05:50:05 -04:00
Daniel J Walsh
a3a0f87c00
Merge pull request #307 from rhatdan/VERSION
...
Bump to v0.22.0
2020-09-11 09:31:10 -04:00
Daniel J Walsh
4b6800b16f
Move to v0.22.1-dev
...
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-09-11 09:29:28 -04:00
Daniel J Walsh
dc36ecf2d7
Bump to v0.22.0
...
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-09-11 09:29:28 -04:00
OpenShift Merge Robot
ec977cfa6d
Merge pull request #306 from rhatdan/seccomp
...
Add new syscalls to allowed seccomp.json
2020-09-11 08:33:44 -04:00
Daniel J Walsh
746c707914
Add new syscalls to allowed seccomp.json
...
faccessat2, openat2, fchmodat2 are all new syscalls to help eliminate
race conditions, current containers get the older versions of these syscalls
so adding them by default makes sense.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-09-11 07:11:16 -04:00
Daniel J Walsh
46d34d7c75
Merge pull request #305 from containers/dependabot/go_modules/github.com/containers/storage-1.23.5
...
Bump github.com/containers/storage from 1.23.4 to 1.23.5
2020-09-11 07:01:04 -04:00
dependabot-preview[bot]
89b1e95e53
Bump github.com/containers/storage from 1.23.4 to 1.23.5
...
Bumps [github.com/containers/storage](https://github.com/containers/storage ) from 1.23.4 to 1.23.5.
- [Release notes](https://github.com/containers/storage/releases )
- [Changelog](https://github.com/containers/storage/blob/master/docs/containers-storage-changes.md )
- [Commits](https://github.com/containers/storage/compare/v1.23.4...v1.23.5 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-09-11 06:17:07 -04:00
Valentin Rothberg
8015f7ef72
Merge pull request #304 from QiWang19/valid-policy
...
ValidatePullPolicy case-insensitive
2020-09-11 11:14:48 +02:00
Qi Wang
f1c4d645f6
ValidatePullPolicy case-insensitive
...
Set pullpolicy case-insensitive for fixing https://github.com/containers/podman/issues/7246 . And replce the duplicate code in podman with c/common code.
Signed-off-by: Qi Wang <qiwan@redhat.com>
2020-09-10 17:05:35 -04:00
Daniel J Walsh
04041034b2
Merge pull request #294 from rhatdan/seccomp
...
Update default seccomp rules to match fedora rules
2020-09-10 07:24:41 -04:00
Daniel J Walsh
826c76f723
Update default seccomp rules to match fedora rules
...
Add the following default syscalls:
"clock_adjtime" -- Already allow adjtimex
"clone" -- Needed so we can use a usernamespace within a container.
Since this is allowed for non root users, it should be safe
to use, and can allow us to support containers/user namespaces
within locked down containers.
"pivot_root" -- Can be used by containers within containers
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-09-09 15:32:50 -04:00
OpenShift Merge Robot
f7dfbf3624
Merge pull request #302 from containers/dependabot/go_modules/github.com/onsi/gomega-1.10.2
...
Bump github.com/onsi/gomega from 1.10.1 to 1.10.2
2020-09-08 14:24:40 -04:00
Daniel J Walsh
c3c1d320ce
Bump github.com/onsi/gomega from 1.10.1 to 1.10.2
...
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega ) from 1.10.1 to 1.10.2.
- [Release notes](https://github.com/onsi/gomega/releases )
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md )
- [Commits](onsi/gomega@v1.10.1...v1.10.2)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-09-08 05:57:56 -04:00
OpenShift Merge Robot
abce3892d1
Merge pull request #301 from containers/dependabot/go_modules/github.com/onsi/ginkgo-1.14.1
...
Bump github.com/onsi/ginkgo from 1.14.0 to 1.14.1
2020-09-07 07:12:26 -04:00
dependabot-preview[bot]
609861576d
Bump github.com/onsi/ginkgo from 1.14.0 to 1.14.1
...
Bumps [github.com/onsi/ginkgo](https://github.com/onsi/ginkgo ) from 1.14.0 to 1.14.1.
- [Release notes](https://github.com/onsi/ginkgo/releases )
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md )
- [Commits](https://github.com/onsi/ginkgo/compare/v1.14.0...v1.14.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-09-07 06:35:24 -04:00
OpenShift Merge Robot
63fb88e93e
Merge pull request #300 from containers/dependabot/go_modules/github.com/containers/storage-1.23.4
...
Bump github.com/containers/storage from 1.23.3 to 1.23.4
2020-09-06 06:46:11 -04:00
dependabot-preview[bot]
2eea661e71
Bump github.com/containers/storage from 1.23.3 to 1.23.4
...
Bumps [github.com/containers/storage](https://github.com/containers/storage ) from 1.23.3 to 1.23.4.
- [Release notes](https://github.com/containers/storage/releases )
- [Changelog](https://github.com/containers/storage/blob/master/docs/containers-storage-changes.md )
- [Commits](https://github.com/containers/storage/compare/v1.23.3...v1.23.4 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-09-05 06:19:55 -04:00
OpenShift Merge Robot
da920bbbc1
Merge pull request #299 from saschagrunert/unit-test
...
Add seccomp validation unit test for failing BuildProfile()
2020-08-30 06:20:27 -04:00
Sascha Grunert
328946174a
Add seccomp validation unit test for failing BuildProfile()
...
This tests the last failure branch of the profile validation.
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
2020-08-28 21:35:03 +02:00
Daniel J Walsh
4a0e7ef832
Merge pull request #298 from rhatdan/VERSION
...
Bump to v0.21.0
2020-08-28 09:44:21 -04:00
Daniel J Walsh
28dc0fae39
Move to v0.21.1-dev
...
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-08-28 09:42:51 -04:00
Daniel J Walsh
0adbc1949e
Bump to v0.21.0
...
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-08-28 09:42:19 -04:00
OpenShift Merge Robot
7c47fd098d
Merge pull request #296 from saschagrunert/validate-build-filter
...
Add BuildFilter() and ValidateProfile() API
2020-08-28 09:38:09 -04:00
OpenShift Merge Robot
85f1358d88
Merge pull request #297 from containers/dependabot/go_modules/github.com/containers/storage-1.23.3
...
Bump github.com/containers/storage from 1.23.2 to 1.23.3
2020-08-28 06:46:44 -04:00
dependabot-preview[bot]
a6436ead85
Bump github.com/containers/storage from 1.23.2 to 1.23.3
...
Bumps [github.com/containers/storage](https://github.com/containers/storage ) from 1.23.2 to 1.23.3.
- [Release notes](https://github.com/containers/storage/releases )
- [Changelog](https://github.com/containers/storage/blob/master/docs/containers-storage-changes.md )
- [Commits](https://github.com/containers/storage/compare/v1.23.2...v1.23.3 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-08-28 05:18:01 -04:00
Sascha Grunert
8270dcffb5
Add BuildFilter() and ValidateProfile() API
...
The new `BuildFilter()` API can be used by runc/libcontainer to build
a libseccomp filter from the spec. This means that they also do not need
any internal structures any more because we indirectly build it from the
internal `Seccomp` type.
The new `ValidateProfile()` API can be used by higher level consumers,
which want to ensure that a seccomp profile string can be transferred
into a libseccomp filter.
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
2020-08-27 21:09:59 +02:00
OpenShift Merge Robot
7bf7bec906
Merge pull request #293 from nalind/retry-delay
...
RetryIfNecessary: add a field for setting the delay in RetryOptions
2020-08-27 05:17:01 -04:00
OpenShift Merge Robot
0659935ede
Merge pull request #276 from openSUSE/containers-golang
...
Migrate seccomp/containers-golang
2020-08-27 05:13:56 -04:00
OpenShift Merge Robot
a19cbe5f81
Merge pull request #291 from openSUSE/gocritic
...
Fix all gocritic lints
2020-08-27 05:10:38 -04:00
Sascha Grunert
5f1c701c68
Migrate seccomp/containers-golang
...
This migrates the repository from github.com/seccomp/containers-golang
into this library.
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
2020-08-27 10:15:31 +02:00
Nalin Dahyabhai
386a2fd659
RetryIfNecessary: add a field for setting the delay in RetryOptions
...
Allow RetryIfNecessary()'s caller to specify the delay between retry
attempts. If the delay is not set, continue to default to 2 seconds for
the first retry, doubling the delay for every subsequent attempt.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2020-08-26 15:02:49 -04:00
OpenShift Merge Robot
2a2e5a601e
Merge pull request #290 from baude/cirrus
...
migrate off travis
2020-08-26 04:58:57 -04:00
OpenShift Merge Robot
ab4bd84bac
Merge pull request #292 from Luap99/fix-windows-conf
...
fix windows containers.conf path
2020-08-26 04:52:52 -04:00
Paul Holzinger
4abbe16f3b
fix windows containers.conf path
...
customConfigFile() has to return the full path to the file
LOCALAPPDATA only returns a directory.
I also recommend using APPDATA instead of LOCALAPPDATA.
If a domain user would logon to a new computer they would
automatically have their containers.conf from the last
login at a different pc. No manual copy is needed since
windows syncs the APPDATA dir by default in a domain
environment at login.
So the config file path on windows would be:
`C:\Users\<username>\AppData\Roaming\containers\containers.conf`
Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
2020-08-25 22:06:13 +02:00
Sascha Grunert
89b399d4cf
Fix all gocritic lints
...
This enables the missing gocritic checks and fixes all of the lints.
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
2020-08-25 20:58:15 +02:00
OpenShift Merge Robot
c33cd39910
Merge pull request #284 from containers/dependabot/go_modules/github.com/containers/storage-1.23.2
...
Bump github.com/containers/storage from 1.23.1 to 1.23.2
2020-08-25 14:55:53 -04:00
Brent Baude
a8d90937eb
begin migration off travis
...
we prefer cirrus. initial implementation for containers/common
Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-08-25 13:34:31 -05:00
OpenShift Merge Robot
93abcad4da
Merge pull request #289 from baude/owners
...
Add owners file
2020-08-25 13:39:10 -04:00
OpenShift Merge Robot
566fc3aa95
Merge pull request #287 from openSUSE/fmt-errorf
...
Change fmt.Errorf calls to be replaced by errors package
2020-08-25 13:35:33 -04:00
dependabot-preview[bot]
17342e16dc
Bump github.com/containers/storage from 1.23.1 to 1.23.2
...
Bumps [github.com/containers/storage](https://github.com/containers/storage ) from 1.23.1 to 1.23.2.
- [Release notes](https://github.com/containers/storage/releases )
- [Changelog](https://github.com/containers/storage/blob/master/docs/containers-storage-changes.md )
- [Commits](https://github.com/containers/storage/compare/v1.23.1...v1.23.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-08-25 13:31:15 -04:00
Brent Baude
07edc1f14d
Add owners file
...
add owners file so that openshift merge bot can do its thing.
Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-08-25 10:59:53 -05:00