Commit Graph

12597 Commits

Author SHA1 Message Date
OpenShift Merge Robot 4dc52f61cc
Merge pull request #10316 from containers/dependabot/go_modules/github.com/containers/storage-1.30.3
Bump github.com/containers/storage from 1.30.2 to 1.30.3
2021-05-12 20:53:08 -04:00
OpenShift Merge Robot 0762970096
Merge pull request #10294 from Luap99/system-upgrade-tests
fix system upgrade tests
2021-05-12 19:54:45 -04:00
OpenShift Merge Robot a31a1f5942
Merge pull request #10300 from jwhonce/issues/10289
Add host.serviceIsRemote to podman info results
2021-05-12 18:06:46 -04:00
OpenShift Merge Robot 7b59119c47
Merge pull request #10239 from alvistack/master-linux-amd64
Update nix pin with `make nixpkgs`
2021-05-12 18:00:46 -04:00
OpenShift Merge Robot c5e7caaec1
Merge pull request #10313 from edsantiago/bats
[CI:DOCS] hack/bats - new helper for running system tests
2021-05-12 17:09:47 -04:00
OpenShift Merge Robot 071799f259
Merge pull request #10324 from containers/uncompressing
[NO TESTS NEEDED] Print "extracting" only on compressed file
2021-05-12 16:10:48 -04:00
OpenShift Merge Robot d6507fcfbc
Merge pull request #10222 from vrothberg/image-tree
podman image tree: restore previous behavior
2021-05-12 15:59:46 -04:00
Paul Holzinger 5992c76f8f fix system upgrade tests
Fix many FIXMEs in the upgrade tests. Also add a basic test for pods.

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
2021-05-12 21:45:43 +02:00
Ashley Cui 01f6e4b53e Print "extracting" only on compressed file
We should only print "extracting compressed file" when the file is
actually compressed

Signed-off-by: Ashley Cui <acui@redhat.com>
2021-05-12 14:35:49 -04:00
Valentin Rothberg d32863bbb4 podman image tree: restore previous behavior
The initial version of libimage changed the order of layers which has
now been restored to remain backwards compatible.

Further changes:

 * Fix a bug in the journald logging which requires to strip trailing
   new lines from the message.  The system tests did not pass due to
   empty new lines.  Triggered by changing the default logger to
   journald in containers/common.

 * Fix another bug in the journald logging which embedded the container
   ID inside the message rather than the specifid field.  That surfaced
   in a preceeding whitespace of each log line which broke the system
   tests.

 * Alter the system tests to make sure that the k8s-file and the
   journald logging drivers are executed.

 * A number of e2e tests have been changed to force the k8s-file driver
   to make them pass when running inside a root container.

 * Increase the timeout in a kill test which seems to take longer now.
   Reasons are unknown.  Tests passed earlier and no signal-related
   changes happend.  It may be CI VM flake since some system tests but
   other flaked.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2021-05-12 17:56:59 +02:00
OpenShift Merge Robot d8dc56ba67
Merge pull request #10318 from Luap99/fix-network-test
fix network restart always test
2021-05-12 07:46:46 -04:00
OpenShift Merge Robot e1d6e65536
Merge pull request #10317 from Luap99/fix-log-driver
fix incorrect log driver in podman container image
2021-05-12 07:13:46 -04:00
Paul Holzinger fa6b6b873f fix network restart always test
The added test in 30544f225e is flaking. Podman inspect is always
working so we have to check the pid instead.

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
2021-05-12 11:27:39 +02:00
Paul Holzinger 439a515026 fix incorrect log driver in podman container image
Commit 7f2c27d43f added an invalid value for the log_driver in the
containers.conf file inside the podman image.

Fixes #10312

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
2021-05-12 09:34:59 +02:00
Jakub Guzik 5e6405334c Add support for cli network prune --filter flag
Signed-off-by: Jakub Guzik <jakubmguzik@gmail.com>
2021-05-12 09:05:06 +02:00
Jakub Guzik 3aae346946 Move filter parsing to common utils
Signed-off-by: Jakub Guzik <jakubmguzik@gmail.com>
2021-05-12 08:35:59 +02:00
dependabot[bot] eccd03f3c4
Bump github.com/containers/storage from 1.30.2 to 1.30.3
Bumps [github.com/containers/storage](https://github.com/containers/storage) from 1.30.2 to 1.30.3.
- [Release notes](https://github.com/containers/storage/releases)
- [Changelog](https://github.com/containers/storage/blob/master/docs/containers-storage-changes.md)
- [Commits](https://github.com/containers/storage/compare/v1.30.2...v1.30.3)

Signed-off-by: dependabot[bot] <support@github.com>
2021-05-12 06:22:36 +00:00
Wong Hoi Sing Edison 9ac124809f
Update nix pin with `make nixpkgs`
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
2021-05-12 09:19:33 +08:00
Ed Santiago b18931cef3 [CI:DOCS] hack/bats - new helper for running system tests
Well, new to you. It's been something I've used for years.
Simple, but it takes care of a lot of housekeeping, and
makes it ever-so-much-more pleasant to invoke bats tests.
And when it's easier to run tests, tests get run.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2021-05-11 16:31:56 -06:00
OpenShift Merge Robot 59dd357509
Merge pull request #10310 from Luap99/restart-slirp
fix restart always with slirp4netns
2021-05-11 18:30:52 -04:00
Paul Holzinger 30544f225e fix restart always with slirp4netns
When a container is automatically restarted due its restart policy and
the container used the slirp4netns netmode, the slirp4netns process
died. This caused the container to lose network connectivity.

To fix this we have to start a new slirp4netns process.

Fixes #8047

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
2021-05-11 22:37:32 +02:00
OpenShift Merge Robot 8dcd5b893f
Merge pull request #10304 from containers/dependabot/go_modules/github.com/opencontainers/runc-1.0.0-rc94
Bump github.com/opencontainers/runc from 1.0.0-rc93 to 1.0.0-rc94
2021-05-11 10:36:54 -04:00
OpenShift Merge Robot 58915f2974
Merge pull request #10303 from containers/dependabot/go_modules/github.com/coreos/go-systemd/v22-22.3.2
Bump github.com/coreos/go-systemd/v22 from 22.3.1 to 22.3.2
2021-05-11 10:35:54 -04:00
dependabot[bot] d71672c57b
Bump github.com/opencontainers/runc from 1.0.0-rc93 to 1.0.0-rc94
Bumps [github.com/opencontainers/runc](https://github.com/opencontainers/runc) from 1.0.0-rc93 to 1.0.0-rc94.
- [Release notes](https://github.com/opencontainers/runc/releases)
- [Commits](https://github.com/opencontainers/runc/compare/v1.0.0-rc93...v1.0.0-rc94)

Signed-off-by: dependabot[bot] <support@github.com>
2021-05-11 06:19:24 +00:00
dependabot[bot] 0c05919e90
Bump github.com/coreos/go-systemd/v22 from 22.3.1 to 22.3.2
Bumps [github.com/coreos/go-systemd/v22](https://github.com/coreos/go-systemd) from 22.3.1 to 22.3.2.
- [Release notes](https://github.com/coreos/go-systemd/releases)
- [Commits](https://github.com/coreos/go-systemd/compare/v22.3.1...v22.3.2)

Signed-off-by: dependabot[bot] <support@github.com>
2021-05-11 06:19:04 +00:00
Jhon Honce 8ad40a85d5 Add host.serviceIsRemote to podman info results
Developers asked for a deterministic field to verify if podman is
running via API or linked directly to libpod library.

$ podman info --format '{{.Host.ServiceIsRemote}}'
false
$ podman-remote info --format '{{.Host.ServiceIsRemote}}'
true
$ podman --remote info --format '{{.Host.ServiceIsRemote}}'
true

* docs/conf.py formatted via black

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2021-05-10 14:13:15 -07:00
OpenShift Merge Robot 57b642525b
Merge pull request #10271 from matejvasek/fix-wait-next-exit
fix: improved "containers/{name}/wait" endpoint
2021-05-10 14:31:40 -04:00
OpenShift Merge Robot 02b0979528
Merge pull request #10291 from edsantiago/remove_obsolete_skips
Remove obsolete skips
2021-05-10 14:30:40 -04:00
OpenShift Merge Robot 76c8577040
Merge pull request #10295 from jwhonce/issues/10154
Add client disconnect check to build handler loop
2021-05-10 13:57:39 -04:00
Jhon Honce 290a58286f Add client disconnect to build handler loop
[NO TESTS NEEDED]
In process of debugging added request channel check and logging message
to build loop. Unable to recreate build drop issue after this. 68k build
iterations without fail.

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2021-05-10 09:46:40 -07:00
OpenShift Merge Robot fbc128ee93
Merge pull request #10236 from Luap99/generate-systemd-env
Add envars to the generated systemd unit
2021-05-10 11:43:40 -04:00
OpenShift Merge Robot 446e5b3006
Merge pull request #10292 from rhatdan/buildah
Fix podman-remote build --rm=false ...
2021-05-10 10:44:39 -04:00
Ed Santiago 471f4898f0 Remove obsolete skips
The following bugs seem to be fixed:

* #6510 (e2e tests) - podman rmi gives "layer not known"

* #9915 (buildah-bud tests) - podman build --arch

* #10248 - spurious warning from first-ever invocation
  of rootless podman

Signed-off-by: Ed Santiago <santiago@redhat.com>
2021-05-10 07:43:35 -06:00
Daniel J Walsh 07164c119a
Fix podman-remote build --rm=false ...
Fixes: https://github.com/containers/podman/issues/9869

[NO TESTS NEEDED] Since the podman-remote buildah tests will test this,
and this is clearly correct.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-05-10 09:16:52 -04:00
OpenShift Merge Robot 5a8b3cf835
Merge pull request #10288 from Luap99/fix-10274
fix container startup for empty pidfile
2021-05-10 09:13:55 -04:00
OpenShift Merge Robot 195895eb7e
Merge pull request #10268 from flouthoc/kube-default-shared-namespace
Kube like pods should share ipc,net,uts by default
2021-05-10 09:12:54 -04:00
OpenShift Merge Robot 9e0aa474a9
Merge pull request #10290 from containers/dependabot/go_modules/github.com/containers/storage-1.30.2
Bump github.com/containers/storage from 1.30.1 to 1.30.2
2021-05-10 08:24:54 -04:00
OpenShift Merge Robot 821aea79a1
Merge pull request #10286 from matejvasek/use-utc-ts
fix: use UTC for `containers/{name}/json` endpoint
2021-05-10 08:01:54 -04:00
Matej Vasek 66e38ca55d fix: improved "containers/{name}/wait" endpoint
Using event API to detect changes to container instead of polling.
Polling was unreliable, sometime change of a state might have been
missed.

Signed-off-by: Matej Vasek <mvasek@redhat.com>
2021-05-10 13:40:06 +02:00
dependabot[bot] d2f7d5cbab
Bump github.com/containers/storage from 1.30.1 to 1.30.2
Bumps [github.com/containers/storage](https://github.com/containers/storage) from 1.30.1 to 1.30.2.
- [Release notes](https://github.com/containers/storage/releases)
- [Changelog](https://github.com/containers/storage/blob/master/docs/containers-storage-changes.md)
- [Commits](https://github.com/containers/storage/compare/v1.30.1...v1.30.2)

Signed-off-by: dependabot[bot] <support@github.com>
2021-05-10 10:16:27 +00:00
Paul Holzinger 77e6ae2436 Add envars to the generated systemd unit
The with --new generated systemd unit loses the environment variables
when the create command only contains the key without the value. Since
podman tries to lookup those values from the environment the unit can
fail.

This commits ensures that we will add the environment variables to the
unit file when this is the case. The container environment variables are
looked up in the container spec.

Fixes #10101

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
2021-05-10 12:01:24 +02:00
Matej Vasek dd98e70302 fix: use UTC Time Stamps in response JSON
Signed-off-by: Matej Vasek <mvasek@redhat.com>
2021-05-10 11:21:14 +02:00
Paul Holzinger 157459a638 fix container startup for empty pidfile
Commit 728b73d7c4 introduced a regression. Containers created with a
previous version do no longer start successfully. The problem is that
the PidFile in the container config is empty for those containers. If
the PidFile is empty we have to set it to the previous default.

[NO TESTS NEEDED] We should investigate why the system upgrade test did
not caught this.

Fixes #10274

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
2021-05-10 10:59:04 +02:00
flouthoc 14a1a4546c Kube like pods should share ipc,net,uts by default
Signed-off-by: flouthoc <flouthoc.git@gmail.com>
2021-05-10 11:29:11 +05:30
OpenShift Merge Robot 54bed1025d
Merge pull request #10265 from matejvasek/fix-get-multiple-imgs-compat
fix: compat API "images/get" for multiple images
2021-05-08 06:20:19 -04:00
OpenShift Merge Robot 141d3f1ac3
Merge pull request #10259 from rhatdan/pull
Report Download complete in Compatibility mode
2021-05-07 15:06:51 -04:00
OpenShift Merge Robot d3e441fda3
Merge pull request #10260 from Luap99/man-dash
[CI:DOCS] Revert escaped double dash man page flag syntax
2021-05-07 15:04:53 -04:00
Matej Vasek c8deab8296 fix: compat API "images/get" for multiple images
Signed-off-by: Matej Vasek <mvasek@redhat.com>
2021-05-07 20:35:03 +02:00
Paul Holzinger 30e731ecc8 Revert escaped double dash man page flag syntax
Commit 800a2e2d35 introduced a way to disable the conversion of `--`into
an en dash on docs.podman.io, so the ugly workaround of escaping the
dashes is no longer necessary.

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
2021-05-07 18:30:00 +02:00
OpenShift Merge Robot 0ce6a65b39
Merge pull request #10230 from matejvasek/fix-compat-img-get
fix: docker APIv2 `images/get`
2021-05-07 12:28:26 -04:00