Commit Graph

12597 Commits

Author SHA1 Message Date
OpenShift Merge Robot 5b872c2228
Merge pull request #10165 from edsantiago/bats
system tests: networking: fix another race condition
2021-04-28 13:26:46 -04:00
Rob Cowsill e18ef90566
[CI:DOCS] Improve titles of command HTML pages
When building Sphinx HTML docs, preprocess markdown files and convert
pandoc-style title lines into recommonmark eval_rst blocks

This gives command HTML pages the same title as the equivalent manpage

Fixes: containers/podman.io#385

Signed-off-by: Rob Cowsill <42620235+rcowsill@users.noreply.github.com>
2021-04-28 16:21:24 +01:00
Ed Santiago 0dfd5a151d system tests: networking: fix another race condition
Our current #1 flake; this is a simple one: we can't run 'logs'
on a container run with '-d --rm'.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2021-04-28 08:41:27 -06:00
OpenShift Merge Robot 633cc473b5
Merge pull request #10139 from rhatdan/troubleshoot
[CI:DOCS] Add troubleshooting advice about the --userns option.
2021-04-28 10:14:31 -04:00
Pablo Correa Gómez 18cb17ffeb
Use seccomp_profile as default profile if defined in containers.conf
Edits `podman info` to provide the default seccomp profile
detected in the output

Signed-off-by: Pablo Correa Gómez <ablocorrea@hotmail.com>
2021-04-28 15:19:48 +02:00
OpenShift Merge Robot 4ca34fce08
Merge pull request #10162 from containers/dependabot/go_modules/github.com/json-iterator/go-1.1.11
Bump github.com/json-iterator/go from 1.1.10 to 1.1.11
2021-04-28 08:32:27 -04:00
OpenShift Merge Robot 99e5a76f09
Merge pull request #10157 from edsantiago/bats
System tests: fix two race conditions
2021-04-28 06:22:45 -04:00
dependabot[bot] 41e8a0af6a
Bump github.com/json-iterator/go from 1.1.10 to 1.1.11
Bumps [github.com/json-iterator/go](https://github.com/json-iterator/go) from 1.1.10 to 1.1.11.
- [Release notes](https://github.com/json-iterator/go/releases)
- [Commits](https://github.com/json-iterator/go/compare/v1.1.10...v1.1.11)

Signed-off-by: dependabot[bot] <support@github.com>
2021-04-28 08:09:20 +00:00
Parker Van Roy 150e2a3ca0 Vendored
Signed-off-by: Parker Van Roy <pvanroy@redhat.com>
2021-04-28 01:54:03 -04:00
Parker Van Roy 14b9f9ad7e Autoupdate local label functional
Digests were used to compare local image and container image

Registry alias added for Image Policy

Refactored to integrate new feature + change some naming conventions

Tested this using a modified version of the docs autoupdate instructions & it worked successfully

Signed-off-by: Parker Van Roy <pvanroy@redhat.com>
2021-04-28 01:54:03 -04:00
Ed Santiago c11e9b01b3 System tests: fix two race conditions
Basically, add 'podman wait' before 'podman rm'. See if this
fixes gating tests run on ppc64le (possibly very very slow hosts)

Signed-off-by: Ed Santiago <santiago@redhat.com>
2021-04-27 15:10:18 -06:00
OpenShift Merge Robot 5dc9faf624
Merge pull request #10134 from rhatdan/conmon
[CI:DOCS] Add more documentation on conmon
2021-04-27 16:57:31 -04:00
OpenShift Merge Robot f613a2a8d5
Merge pull request #10119 from rhatdan/timeout
Add podman run --timeout option
2021-04-27 16:47:32 -04:00
OpenShift Merge Robot dbc13f3dac
Merge pull request #10137 from cevich/update_ubuntu_2104
Cirrus: Update Ubuntu images to 21.04
2021-04-27 16:44:31 -04:00
OpenShift Merge Robot ba9c1f3f17
Merge pull request #10149 from rhatdan/volume
Allow docker volume create API to pass without name
2021-04-27 12:02:31 -04:00
Daniel J Walsh 63fd3a3fca
Add more documentation on conmon
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-04-27 11:57:19 -04:00
Daniel J Walsh 825c84efe1
Allow docker volume create API to pass without name
The Docker API does not require Volume name to be specified when
creating a volume.

Fixes: https://github.com/containers/podman/issues/9803

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-04-27 10:32:06 -04:00
Chris Evich 0a08216990
Cirrus: Update Ubuntu images to 21.04
Also simplify `lib.sh` after supporting changes incorporated
into automation library 2.x+ (present in all VM and container images).

* No need to force-load `/etc/profile` and handle it's expectation
  to **not** being in `errexit` mode.
* Slightly re-arrange loading of automation library files for
  clarity.
* Update comments.

Signed-off-by: Chris Evich <cevich@redhat.com>
2021-04-27 10:28:09 -04:00
Chris Evich 7e90bcbb9a
Skip blkio-weight test when no kernel BFQ support
Namely the Ubuntu 21.04 Kernel does not support BFQ.  Regardless of the
distro. skip this test if the required cgroup node doesn't exist.

Signed-off-by: Chris Evich <cevich@redhat.com>
2021-04-27 10:28:09 -04:00
OpenShift Merge Robot abda7961d6
Merge pull request #9788 from andrewshadura/rootless-friendly-error
[CI:DOCS] rootless: Tell the user what was led to the error, not just what it is
2021-04-27 10:24:44 -04:00
OpenShift Merge Robot 3148e01651
Merge pull request #10132 from rcowsill/restore-lost-text
[CI:DOCS] Restore missing content to manpages
2021-04-27 08:39:35 -04:00
OpenShift Merge Robot 5baa0ae85e
Merge pull request #10136 from zhangguanzhang/generate-kube-volume
Fixes generate kube incorrect when bind-mounting "/" and "/root"
2021-04-27 06:08:22 -04:00
OpenShift Merge Robot e6fc34b71a
Merge pull request #9941 from Luap99/fix-9828
Fix rootlesskit port forwarder with custom slirp cidr
2021-04-27 05:44:22 -04:00
Andrej Shadura 09e640d1b5
rootless: Tell the user what was led to the error, not just what it is
Users coming e.g. from Docker do not always read the manual and
expect podman to not require sudo or uidmap, for them the default
message is not very helpful:

    Error: Cannot connect to the Podman socket, make sure there is a Podman REST API service running.:
    cannot find newuidmap: exec: "newuidmap": executable file not found in $PATH

Adding a bit more context to this would help to nudge them into the
right direction and tell them what to look for in the documentation:

    command required for rootless mode with multiple IDs: exec: "newuidmap": executable file not found in $PATH

Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>

[NO TESTS NEEDED]
2021-04-27 11:20:43 +02:00
OpenShift Merge Robot 54344d3a64
Merge pull request #10074 from flouthoc/ancestor-truncate-bug
Fix podman ps --filter ancestor to match exact ImageName/ImageID
2021-04-26 20:23:54 -04:00
OpenShift Merge Robot bdcfdadb2f
Merge pull request #10144 from jmguzik/fix-prune-until-filter-images
Fix images prune filter until
2021-04-26 20:05:56 -04:00
OpenShift Merge Robot 5070ae3bce
Merge pull request #10142 from cevich/fix_push_logic
[CI:DOCS] Fix logic for pushing stable multi-arch images
2021-04-26 19:52:54 -04:00
Josh Berkus 166149b12d
Add troubleshooting advice about the --userns option.
Also a link to the troubleshooting guide into the issue template.

Replaces: https://github.com/containers/podman/pull/9770

Signed-off-by: Josh Berkus <josh@agliodbs.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-04-26 17:31:29 -04:00
OpenShift Merge Robot 2039be00d1
Merge pull request #10140 from vrothberg/image-unit
libpod/image: unit tests: don't use system's registries.conf.d
2021-04-26 17:30:16 -04:00
OpenShift Merge Robot 258a490fe4
Merge pull request #10125 from ashley-cui/machenabled
[NO TESTS NEEDED] Add machine-enabled to containers.conf for machine
2021-04-26 17:28:12 -04:00
Jakub Guzik 8edadd4c7e Fix images prune filter until
This commits fixes until filter. It is now checking if the created
timestamp is before until filter value as expected in the docs.

Signed-off-by: Jakub Guzik <jakubmguzik@gmail.com>
2021-04-26 22:51:33 +02:00
Chris Evich 17c82caac4
Fix logic for pushing stable multi-arch images
The intention is to only push an image if there is ***NOT*** an existing
tag.  The original logic for this condition was inverted.

Also, improve radability of the `{container,podman}_push=true`
statements.

Signed-off-by: Chris Evich <cevich@redhat.com>
2021-04-26 14:12:42 -04:00
zhangguanzhang 3bf0fbf6f6 Fixes generate kube incorrect when bind-mounting "/" and "/root"
Signed-off-by: zhangguanzhang <zhangguanzhang@qq.com>
2021-04-26 23:47:39 +08:00
Valentin Rothberg 3886524d53 libpod/image: unit tests: don't use system's registries.conf.d
This should make the unit tests pass on updated CI images.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2021-04-26 17:46:36 +02:00
OpenShift Merge Robot 476c76f580
Merge pull request #10123 from cevich/fix_multi_arch_image
[CI:DOCS] Several multi-arch image build/push fixes
2021-04-26 10:14:02 -04:00
OpenShift Merge Robot fef3ea80aa
Merge pull request #10081 from sjug/cdi_device_lib
Add support for CDI device configuration
2021-04-26 09:31:06 -04:00
OpenShift Merge Robot 333817a187
Merge pull request #10079 from giuseppe/create-userns-for-root-without-CAP_SYS_ADMIN
runtime: create userns when CAP_SYS_ADMIN is not present
2021-04-26 09:19:00 -04:00
Giuseppe Scrivano 722ea2f1f8
runtime: create userns when CAP_SYS_ADMIN is not present
when deciding to create a user namespace, check for CAP_SYS_ADMIN
instead of looking at the euid.

[NO TESTS NEEDED] Needs nested Podman

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2021-04-26 08:58:55 +02:00
Giuseppe Scrivano e4c269e2d0
rootless: attempt to copy current mappings first
when creating a user namespace, attempt to create it first by copying
the current mappings and then fallback to the other methods:

1) use newidmap tools and ...
2) create a user namespace with a single user mapped.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2021-04-26 08:58:54 +02:00
OpenShift Merge Robot 9ca53cfb4f
Merge pull request #10131 from eriksjolund/fix_markdown_layout_bugs
[CI:DOCS] Fix Markdown layout bugs
2021-04-25 12:54:45 -04:00
Rob Cowsill 9731ecfc7a
[CI:DOCS] Restore missing content to manpages
The following content was omitted:
- Text after the first markdown link on a line to the end of the last
  (in lines with multiple markdown links)
- Email addresses of the form <a...@...>

Fixed by:
- Making the first two regexes match each link individually, instead
  of matching from the start of the first link to the end of the last
- Making the last regex specifically match <a> and </a> tags

Signed-off-by: Rob Cowsill <42620235+rcowsill@users.noreply.github.com>
2021-04-25 16:19:24 +01:00
Erik Sjölund a010bb912d
[CI:DOCS] Fix Markdown layout bugs
* Add missing backticks to mark the end
  of the code block.

Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
2021-04-25 14:39:54 +02:00
flouthoc b0ea40f551 Fix podman ps --filter ancestor to match exact ImageName/ImageID
Signed-off-by: flouthoc <flouthoc.git@gmail.com>
2021-04-25 13:49:40 +05:30
Ashley Cui bd76701e89 Add machine-enabled to containers.conf for machine
Add machine-enabled=true into /etc/containers/containers.conf when
initing a VM. This field should tell Podman it's being run in a
podman-machine and it will be used in future to tell podman to set up
other necessary machine stuff such as networking

[NO TESTS NEEDED]

Signed-off-by: Ashley Cui <acui@redhat.com>
2021-04-23 16:30:54 -04:00
Chris Evich 1e98a95a0e
Several multi-arch image build/push fixes
* Fix not setting `$VERSION` before reference
* Reduce need for "syntax-hilighting workaround` comment.
  Simplify context-expressions -> simple env. var. referenmces
* Fix pushing quay.io/containers/podman:master twice
  ('upstream' and 'testing' matrix items)
* Throw error on unknown/unsupported matrix items
* Improve readability of setting multi-line `$LABELS` value.

Signed-off-by: Chris Evich <cevich@redhat.com>
2021-04-23 13:35:10 -04:00
Daniel J Walsh 3538815c5b
Add podman run --timeout option
This option allows users to specify the maximum amount of time to run
before conmon sends the kill signal to the container.

Fixes: https://github.com/containers/podman/issues/6412

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-04-23 11:18:05 -04:00
OpenShift Merge Robot ba60821f0a
Merge pull request #10107 from cevich/multi_arch_images
[CI:DOCS] Add github-action workflow to build/push multi-arch
2021-04-23 10:40:45 -04:00
OpenShift Merge Robot feac25f722
Merge pull request #10122 from Luap99/fix-10110
Parse slirp4netns net options with compat api
2021-04-23 09:22:44 -04:00
OpenShift Merge Robot afdea0dccd
Merge pull request #10121 from SoMuchForSubtlety/master
Fix removal race condition in ListContainers
2021-04-23 07:20:49 -04:00
Paul Holzinger ca4f6ec1db Parse slirp4netns net options with compat api
Parse the slirp4netns network options when called via compat api. The
options must be extracted from the NetworkMode string.

Fixes #10110

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
2021-04-23 11:48:50 +02:00