Commit Graph

7 Commits

Author SHA1 Message Date
Kir Kolyshkin b951b72412 Gofumpt the code
gofumpt is a stricter version of gofmt, basically making the code more
readable, and fixing the gocritic's octalLiterar warnings like this one:

	pkg/util/util_supported.go:26:17: octalLiteral: use new octal literal style, 0o722 (gocritic)
		return (perm & 0722) == 0700
			       ^

Generated by gofumpt -w .

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
2022-04-09 16:50:11 -07:00
ttyS3 ca459dce1b fix: fixup memory usage for cgroup v2 2021-12-26 21:47:07 +08:00
Daniel J Walsh 5baa5d66c5 Fix build failure on Podman vendor
Basically Windows build is failing when hitting unix contants in
cgroups.

[NO NEW TESTS ADDED] Just shifting code around.

Added build-cross to cirrus tests, which looks like it was not being
run.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-12-14 14:43:47 -05:00
Giuseppe Scrivano cbc695fed4 cgroup: retry rmdir up to 5 seconds on EBUSY
on a busy system, the conmon process could take longer to complete or
to be reaped by the parent, leaving the cgroup busy.  If the rmdir
fails with EBUSY, try again up to 5 seconds before reporting an
error.

Closes: https://github.com/containers/podman/issues/11946

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2021-12-14 16:42:33 +01:00
Daniel J Walsh e0c3749251 Move pkg/cgroups into common to be shared with buildah
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-12-03 13:13:43 -05:00
Giuseppe Scrivano 990e0fc7c3 pkg/cgroups: delete it
at the moment the cgroups package is used only by Podman and by CRI-O
(that is already vendoring libpod).  So let's simplify and not have a
duplicate here.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-01-09 08:45:00 +01:00
Qi Wang aab667743b move cgroups pkg from libpod
move cgroups package from libpod so can be shared by Buildah and Podman.

Signed-off-by: Qi Wang <qiwan@redhat.com>
2019-12-05 12:09:11 -05:00