gofumpt is a stricter version of gofmt, basically making the code more
readable, and fixing the gocritic's octalLiterar warnings like this one:
pkg/util/util_supported.go:26:17: octalLiteral: use new octal literal style, 0o722 (gocritic)
return (perm & 0722) == 0700
^
Generated by gofumpt -w .
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Relax ValidateVolumeOpts to support more verbose options for overlay
example `upperdir, workdir` and in future maybe `volatile`.
Signed-off-by: Aditya R <arajan@redhat.com>
Destination path inside containers should be always validated as
*nix absolute path. So its recommended to use path.IsAbs() instead of
filepath.IsAbs().
[NO TEST NEEDED]
Signed-off-by: flouthoc <flouthoc.git@gmail.com>
golang builtin OS functions, include the path to the object being used,
no reason for us to wrap these errors with an object for a second time.
This just causes stuttering, and looks bad at the CLI level.
Existing tests should catch any errors.
Also stop adding "error" to something that is obviusly an error when it
shows up to the user.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
We want to split out buildah/pkg/parse for components other
containers/engines are using without pulling in the buildah library.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Kir Kolyshkin
Giuseppe Scrivano
Aditya Rajan
flouthoc
Daniel J Walsh
Eduardo Vega