automation-tests/cmd/podman
Debarshi Ray 320ce8c9f2 Consolidate the dependencies for the IsTerminal() API
The rest of the code has been using golang.org/x/* for the IsTerminal()
API for a long time, not github.com/mattn/go-isatty.  It seems better to
stick to packages from the golang.org domain, whenever possible, and one
less dependency is always a good thing.

The modules were not cleaned up with 'make vendor' because 'go mod tidy'
was running into:

go: error loading go 1.16 module graph:
  github.com/containers/image/v5@v5.23.1-0.20221015133641-1921a1993c67
  requires
      github.com/honeycombio/beeline-go@v1.9.0 requires
      github.com/mattn/go-sqlite3@v2.0.3+incompatible: reading
        github.com/mattn/go-sqlite3/go.mod at revision v2.0.3: unknown
        revision v2.0.3

If reproducibility with go 1.16 is not needed:
    go mod tidy -compat=1.17

Since go.mod already requires Go 1.17, the following commands were
manually run:
$ go mod tidy -compat=1.17
$ go mod vendor
$ go mod verify

Further modifications to go.sum were done manually based on the
complaints from postbuild.sh run by the CI.

[NO NEW TESTS NEEDED] as it's not a functional change.

Fixes: 85db895012 ("logging: new mode -l passthrough")

Signed-off-by: Debarshi Ray <rishi@fedoraproject.org>
2022-10-27 17:45:05 +02:00
..
common use cached containers.conf 2022-10-21 14:03:14 +02:00
completion build(deps): bump github.com/spf13/cobra from 1.5.0 to 1.6.0 2022-10-12 14:54:19 +02:00
containers Consolidate the dependencies for the IsTerminal() API 2022-10-27 17:45:05 +02:00
diff cmd/podman: switch to golang native error wrapping 2022-06-30 12:58:57 +02:00
generate Replace deprecated ioutil 2022-09-20 15:34:27 -04:00
healthcheck bump go module to version 4 2022-01-18 12:47:07 +01:00
images use cached containers.conf 2022-10-21 14:03:14 +02:00
inspect podman inspect return exit code > 0 on print error 2022-09-13 10:33:14 +02:00
kube Replace deprecated ioutil 2022-09-20 15:34:27 -04:00
machine use cached containers.conf 2022-10-21 14:03:14 +02:00
manifest Replace deprecated ioutil 2022-09-20 15:34:27 -04:00
networks podman network ls: use report.Formatter over Template 2022-09-13 10:33:13 +02:00
parse Replace deprecated ioutil 2022-09-20 15:34:27 -04:00
pods container/pod id file: truncate instead of throwing an error 2022-10-25 09:37:35 +02:00
registry use cached containers.conf 2022-10-21 14:03:14 +02:00
secrets use cached containers.conf 2022-10-21 14:03:14 +02:00
system Merge pull request #16234 from jakecorrenti/system-df-verbose-format-usability 2022-10-24 11:44:09 -04:00
utils bump golangci-lint to v1.49.0 2022-10-17 09:19:41 +02:00
validate bump golangci-lint to v1.49.0 2022-10-17 09:19:41 +02:00
volumes Add podman volume create --ignore 2022-10-24 17:30:31 +02:00
README.md [Techinal Debt] Cleanup ABI vs. Tunnel CLI commands 2021-05-27 11:40:43 -07:00
auto-update.go podman auto-update: use report.Formatter over Template 2022-09-13 10:33:12 +02:00
diff.go Remove unused archive flag from diff commands 2022-05-25 08:50:12 -07:00
early_init_linux.go Fix stutters 2022-09-10 07:52:00 -04:00
early_init_unsupported.go go fmt: use go 1.18 conditional-build syntax 2022-03-18 09:11:53 +01:00
inspect.go bump go module to version 4 2022-01-18 12:47:07 +01:00
login.go bump go module to version 4 2022-01-18 12:47:07 +01:00
logout.go bump go module to version 4 2022-01-18 12:47:07 +01:00
main.go Add "podman kube play" cmd 2022-07-13 15:27:03 +01:00
root.go use cached containers.conf 2022-10-21 14:03:14 +02:00
root_test.go cmd/podman: switch to golang native error wrapping 2022-06-30 12:58:57 +02:00
shell_completion_test.go bump go module to version 4 2022-01-18 12:47:07 +01:00
syslog_common.go cmd/podman: Enable --syslog on FreeBSD 2022-08-26 08:01:02 +01:00
syslog_unsupported.go cmd/podman: Enable --syslog on FreeBSD 2022-08-26 08:01:02 +01:00

README.md

Podman CLI

The following is an example of how to add a new primary command (manifest) and a sub-command (inspect) to the Podman CLI. This is example code, the production code has additional error checking and the business logic provided.

See items below for details on building, installing, contributing to Podman:

Adding a new command podman manifest

$ mkdir -p $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests

Create the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests/manifest.go

package manifests

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/cmd/podman/validate"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman _manifests_
    manifestCmd = &cobra.Command{
        Use:               "manifest",
        Short:             "Manage manifests",
        Args:              cobra.ExactArgs(1),
        Long:              "Manage manifests",
        Example:           "podman manifest IMAGE",
        TraverseChildren:  true,
        RunE:              validate.SubCommandExists, // Report error if there is no sub command given
    }
)
func init() {
    // Subscribe command to podman
    registry.Commands = append(registry.Commands, registry.CliCommand{
        Command: manifestCmd,
    })
}

To "wire" in the manifest command, edit the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/main.go to add:

package main

import	_ "github.com/containers/podman/cmd/podman/manifests"

Adding a new sub command podman manifests list

Create the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests/inspect.go

package manifests

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman manifests _inspect_
    inspectCmd = &cobra.Command{
        Use:     "inspect IMAGE",
        Short:   "Display manifest from image",
        Long:    "Displays the low-level information on a manifest identified by image name or ID",
        RunE:    inspect,
        Annotations: map[string]string{
            // Add this annotation if this command cannot be run rootless
            // registry.ParentNSRequired: "",
        },
        Example: "podman manifest inspect DEADBEEF",
    }
)

func init() {
    // Subscribe inspect sub command to manifest command
    registry.Commands = append(registry.Commands, registry.CliCommand{
        Command: inspectCmd,
        // The parent command to proceed this command on the CLI
        Parent:  manifestCmd,
    })

    // This is where you would configure the cobra flags using inspectCmd.Flags()
}

// Business logic: cmd is inspectCmd, args is the positional arguments from os.Args
func inspect(cmd *cobra.Command, args []string) error {
    // Business logic using registry.ImageEngine()
    // Do not pull from libpod directly use the domain objects and types
    return nil
}

Helper functions

The complete set can be found in the validate package, here are some examples:

  • cobra.Command{ Args: validate.NoArgs } used when the command does not accept errors
  • cobra.Command{ Args: validate.IdOrLatestArgs } used to ensure either a list of ids given or the --latest flag
  • cobra.Command{ RunE: validate.SubCommandExists } used to validate a subcommand given to a command
  • validate.ChoiceValue used to create a pflag.Value that validate user input against a provided slice of values. For example:
    flags := cobraCommand.Flags()
    created := validate.ChoiceValue(&opts.Sort, "command", "created", "id", "image", "names", "runningfor", "size", "status")
    flags.Var(created, "sort", "Sort output by: "+created.Choices())