automation-tests/cmd/podman
Paul Holzinger 41528739ce
golangci-lint: enable nolintlint
The nolintlint linter does not deny the use of `//nolint`
Instead it allows us to enforce a common nolint style:
- force that a linter name must be specified
- do not add a space between `//` and `nolint`
- make sure nolint is only used when there is actually a problem

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2022-06-14 16:29:42 +02:00
..
common golangci-lint: enable nolintlint 2022-06-14 16:29:42 +02:00
completion enable gocritic linter 2022-04-26 18:12:22 +02:00
containers golangci-lint: enable nolintlint 2022-06-14 16:29:42 +02:00
diff Remove unused archive flag from diff commands 2022-05-25 08:50:12 -07:00
generate Handlers for `generate systemd` with custom dependencies 2022-01-19 21:46:16 +05:00
healthcheck bump go module to version 4 2022-01-18 12:47:07 +01:00
images Merge pull request #14560 from rhatdan/remote 2022-06-13 04:15:20 -04:00
inspect golangci-lint: enable nolintlint 2022-06-14 16:29:42 +02:00
machine Introduce 'Starting' status for machines 2022-06-09 12:42:43 -04:00
manifest bump go module to version 4 2022-01-18 12:47:07 +01:00
networks Combine the CheckAllLatest CID and PodID functions 2022-05-26 11:12:40 -04:00
parse golangci-lint: enable nolintlint 2022-06-14 16:29:42 +02:00
play play kube: service container 2022-05-12 10:51:13 +02:00
pods golangci-lint: enable nolintlint 2022-06-14 16:29:42 +02:00
registry go fmt: use go 1.18 conditional-build syntax 2022-03-18 09:11:53 +01:00
secrets enable errcheck linter 2022-04-29 14:06:38 +02:00
system golangci-lint: enable nolintlint 2022-06-14 16:29:42 +02:00
utils podman machine ssh: set correct exit code 2022-05-30 15:55:20 +02:00
validate golangci-lint: enable nolintlint 2022-06-14 16:29:42 +02:00
volumes podman volume export/import: give better error 2022-05-30 18:10:28 +02:00
README.md [Techinal Debt] Cleanup ABI vs. Tunnel CLI commands 2021-05-27 11:40:43 -07:00
auto-update.go shell completion --format: use structs by reference 2022-04-28 18:12:17 +02:00
diff.go Remove unused archive flag from diff commands 2022-05-25 08:50:12 -07:00
early_init_linux.go bump go module to version 4 2022-01-18 12:47:07 +01:00
early_init_unsupported.go go fmt: use go 1.18 conditional-build syntax 2022-03-18 09:11:53 +01:00
inspect.go bump go module to version 4 2022-01-18 12:47:07 +01:00
login.go bump go module to version 4 2022-01-18 12:47:07 +01:00
logout.go bump go module to version 4 2022-01-18 12:47:07 +01:00
main.go Add podman machine events 2022-05-03 13:49:01 -07:00
root.go Remove TODO re: storage-driver 2022-05-24 08:45:32 -07:00
root_test.go bump go module to version 4 2022-01-18 12:47:07 +01:00
shell_completion_test.go bump go module to version 4 2022-01-18 12:47:07 +01:00
syslog_linux.go Fix build on OS X 2020-05-20 18:24:56 -04:00
syslog_unsupported.go go fmt: use go 1.18 conditional-build syntax 2022-03-18 09:11:53 +01:00

README.md

Podman CLI

The following is an example of how to add a new primary command (manifest) and a sub-command (inspect) to the Podman CLI. This is example code, the production code has additional error checking and the business logic provided.

See items below for details on building, installing, contributing to Podman:

Adding a new command podman manifest

$ mkdir -p $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests

Create the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests/manifest.go

package manifests

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/cmd/podman/validate"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman _manifests_
    manifestCmd = &cobra.Command{
        Use:               "manifest",
        Short:             "Manage manifests",
        Args:              cobra.ExactArgs(1),
        Long:              "Manage manifests",
        Example:           "podman manifest IMAGE",
        TraverseChildren:  true,
        RunE:              validate.SubCommandExists, // Report error if there is no sub command given
    }
)
func init() {
    // Subscribe command to podman
    registry.Commands = append(registry.Commands, registry.CliCommand{
        Command: manifestCmd,
    })
}

To "wire" in the manifest command, edit the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/main.go to add:

package main

import	_ "github.com/containers/podman/cmd/podman/manifests"

Adding a new sub command podman manifests list

Create the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests/inspect.go

package manifests

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman manifests _inspect_
    inspectCmd = &cobra.Command{
        Use:     "inspect IMAGE",
        Short:   "Display manifest from image",
        Long:    "Displays the low-level information on a manifest identified by image name or ID",
        RunE:    inspect,
        Annotations: map[string]string{
            // Add this annotation if this command cannot be run rootless
            // registry.ParentNSRequired: "",
        },
        Example: "podman manifest inspect DEADBEEF",
    }
)

func init() {
    // Subscribe inspect sub command to manifest command
    registry.Commands = append(registry.Commands, registry.CliCommand{
        Command: inspectCmd,
        // The parent command to proceed this command on the CLI
        Parent:  manifestCmd,
    })

    // This is where you would configure the cobra flags using inspectCmd.Flags()
}

// Business logic: cmd is inspectCmd, args is the positional arguments from os.Args
func inspect(cmd *cobra.Command, args []string) error {
    // Business logic using registry.ImageEngine()
    // Do not pull from libpod directly use the domain objects and types
    return nil
}

Helper functions

The complete set can be found in the validate package, here are some examples:

  • cobra.Command{ Args: validate.NoArgs } used when the command does not accept errors
  • cobra.Command{ Args: validate.IdOrLatestArgs } used to ensure either a list of ids given or the --latest flag
  • cobra.Command{ RunE: validate.SubCommandExists } used to validate a subcommand given to a command
  • validate.ChoiceValue used to create a pflag.Value that validate user input against a provided slice of values. For example:
    flags := cobraCommand.Flags()
    created := validate.ChoiceValue(&opts.Sort, "command", "created", "id", "image", "names", "runningfor", "size", "status")
    flags.Var(created, "sort", "Sort output by: "+created.Choices())