automation-tests/cmd/podman
Paul Holzinger 51fbf3da9e
enable gocritic linter
The linter ensures a common code style.
- use switch/case instead of else if
- use if instead of switch/case for single case statement
- add space between comment and text
- detect the use of defer with os.Exit()
- use short form var += "..." instead of var = var + "..."
- detect problems with append()
```
newSlice := append(orgSlice, val)
```
  This could lead to nasty bugs because the orgSlice will be changed in
  place if it has enough capacity too hold the new elements. Thus we
  newSlice might not be a copy.

Of course most of the changes are just cosmetic and do not cause any
logic errors but I think it is a good idea to enforce a common style.
This should help maintainability.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2022-04-26 18:12:22 +02:00
..
common enable gocritic linter 2022-04-26 18:12:22 +02:00
completion enable gocritic linter 2022-04-26 18:12:22 +02:00
containers [CI:DOCS]Remove unnecesarry files 2022-04-26 08:22:14 -05:00
diff bump go module to version 4 2022-01-18 12:47:07 +01:00
generate Handlers for `generate systemd` with custom dependencies 2022-01-19 21:46:16 +05:00
healthcheck bump go module to version 4 2022-01-18 12:47:07 +01:00
images enable gocritic linter 2022-04-26 18:12:22 +02:00
inspect Remove error stutter 2022-03-25 21:47:04 -04:00
machine Merge pull request #13996 from cdoern/machine 2022-04-26 09:08:31 -04:00
manifest bump go module to version 4 2022-01-18 12:47:07 +01:00
networks network create: add support for ipam-driver none 2022-04-11 11:09:15 +02:00
parse fix a number of `godot` issues 2022-03-22 13:04:35 +01:00
play play: kube: use in-memory kubefile and remove tempfile 2022-03-24 00:57:01 -07:00
pods enable gocritic linter 2022-04-26 18:12:22 +02:00
registry go fmt: use go 1.18 conditional-build syntax 2022-03-18 09:11:53 +01:00
secrets enable gocritic linter 2022-04-26 18:12:22 +02:00
system enable gocritic linter 2022-04-26 18:12:22 +02:00
utils enable gocritic linter 2022-04-26 18:12:22 +02:00
validate replace golint with revive linter 2022-04-22 15:12:33 +02:00
volumes enable staticcheck linter 2022-04-22 12:51:29 +02:00
README.md [Techinal Debt] Cleanup ABI vs. Tunnel CLI commands 2021-05-27 11:40:43 -07:00
auto-update.go bump go module to version 4 2022-01-18 12:47:07 +01:00
diff.go bump go module to version 4 2022-01-18 12:47:07 +01:00
early_init_linux.go bump go module to version 4 2022-01-18 12:47:07 +01:00
early_init_unsupported.go go fmt: use go 1.18 conditional-build syntax 2022-03-18 09:11:53 +01:00
inspect.go bump go module to version 4 2022-01-18 12:47:07 +01:00
login.go bump go module to version 4 2022-01-18 12:47:07 +01:00
logout.go bump go module to version 4 2022-01-18 12:47:07 +01:00
main.go cli commands: better error for unsupported commands 2022-03-31 16:20:18 +02:00
root.go Add support for passing --volumepath 2022-04-23 08:03:36 -04:00
root_test.go bump go module to version 4 2022-01-18 12:47:07 +01:00
shell_completion_test.go bump go module to version 4 2022-01-18 12:47:07 +01:00
syslog_linux.go Fix build on OS X 2020-05-20 18:24:56 -04:00
syslog_unsupported.go go fmt: use go 1.18 conditional-build syntax 2022-03-18 09:11:53 +01:00

README.md

Podman CLI

The following is an example of how to add a new primary command (manifest) and a sub-command (inspect) to the Podman CLI. This is example code, the production code has additional error checking and the business logic provided.

See items below for details on building, installing, contributing to Podman:

Adding a new command podman manifest

$ mkdir -p $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests

Create the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests/manifest.go

package manifests

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/cmd/podman/validate"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman _manifests_
    manifestCmd = &cobra.Command{
        Use:               "manifest",
        Short:             "Manage manifests",
        Args:              cobra.ExactArgs(1),
        Long:              "Manage manifests",
        Example:           "podman manifest IMAGE",
        TraverseChildren:  true,
        RunE:              validate.SubCommandExists, // Report error if there is no sub command given
    }
)
func init() {
    // Subscribe command to podman
    registry.Commands = append(registry.Commands, registry.CliCommand{
        Command: manifestCmd,
    })
}

To "wire" in the manifest command, edit the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/main.go to add:

package main

import	_ "github.com/containers/podman/cmd/podman/manifests"

Adding a new sub command podman manifests list

Create the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests/inspect.go

package manifests

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman manifests _inspect_
    inspectCmd = &cobra.Command{
        Use:     "inspect IMAGE",
        Short:   "Display manifest from image",
        Long:    "Displays the low-level information on a manifest identified by image name or ID",
        RunE:    inspect,
        Annotations: map[string]string{
            // Add this annotation if this command cannot be run rootless
            // registry.ParentNSRequired: "",
        },
        Example: "podman manifest inspect DEADBEEF",
    }
)

func init() {
    // Subscribe inspect sub command to manifest command
    registry.Commands = append(registry.Commands, registry.CliCommand{
        Command: inspectCmd,
        // The parent command to proceed this command on the CLI
        Parent:  manifestCmd,
    })

    // This is where you would configure the cobra flags using inspectCmd.Flags()
}

// Business logic: cmd is inspectCmd, args is the positional arguments from os.Args
func inspect(cmd *cobra.Command, args []string) error {
    // Business logic using registry.ImageEngine()
    // Do not pull from libpod directly use the domain objects and types
    return nil
}

Helper functions

The complete set can be found in the validate package, here are some examples:

  • cobra.Command{ Args: validate.NoArgs } used when the command does not accept errors
  • cobra.Command{ Args: validate.IdOrLatestArgs } used to ensure either a list of ids given or the --latest flag
  • cobra.Command{ RunE: validate.SubCommandExists } used to validate a subcommand given to a command
  • validate.ChoiceValue used to create a pflag.Value that validate user input against a provided slice of values. For example:
    flags := cobraCommand.Flags()
    created := validate.ChoiceValue(&opts.Sort, "command", "created", "id", "image", "names", "runningfor", "size", "status")
    flags.Var(created, "sort", "Sort output by: "+created.Choices())