automation-tests/cmd/podman
OpenShift Merge Robot 80a2317ca2
Merge pull request #7929 from kolyshkin/nits-err
Nits
2020-10-06 10:15:04 +02:00
..
common Support max_size logoptions 2020-10-05 17:51:45 -04:00
containers Fix podman-remote ps --ns broken 2020-10-04 19:48:13 +08:00
generate APIv2 add generate systemd endpoint 2020-09-02 22:06:19 +02:00
healthcheck Switch all references to github.com/containers/libpod -> podman 2020-07-28 08:23:45 -04:00
images Lowercase some errors 2020-10-05 15:56:44 -07:00
inspect Usability: prevent "-l" with arguments 2020-09-14 15:49:28 -06:00
manifest Extend flags of `manifest add` 2020-09-09 12:33:11 +02:00
networks Fix handling of remove of bogus volumes, networks and Pods 2020-09-29 15:52:43 -04:00
parse Restore "table" --format from V1 2020-10-02 06:58:02 -07:00
play Switch all references to github.com/containers/libpod -> podman 2020-07-28 08:23:45 -04:00
pods Podman containers/pods prune should throw an error if user adds args 2020-10-01 17:22:51 -04:00
registry Remove help/usage from --remote pre-check 2020-08-18 08:57:00 -07:00
report Restore "table" --format from V1 2020-10-02 06:58:02 -07:00
system Lowercase some errors 2020-10-05 15:56:44 -07:00
utils Show c/storage (Buildah/CRI-O) containers in ps 2020-09-09 06:10:02 -04:00
validate Usability: prevent "-l" with arguments 2020-09-14 15:49:28 -06:00
volumes Volume prune should not pass down the force flag 2020-10-01 06:32:57 -04:00
README.md Switch all references to github.com/containers/libpod -> podman 2020-07-28 08:23:45 -04:00
auto-update.go Fix up errors found by codespell 2020-09-11 06:14:25 -04:00
diff.go Switch all references to github.com/containers/libpod -> podman 2020-07-28 08:23:45 -04:00
early_init_linux.go Add support for --connection 2020-08-19 08:37:44 -07:00
early_init_unsupported.go abi: set default umask and rlimits 2020-07-17 20:53:38 +02:00
inspect.go Switch all references to github.com/containers/libpod -> podman 2020-07-28 08:23:45 -04:00
login.go Switch all references to github.com/containers/libpod -> podman 2020-07-28 08:23:45 -04:00
logout.go Switch all references to github.com/containers/libpod -> podman 2020-07-28 08:23:45 -04:00
main.go Switch all references to github.com/containers/libpod -> podman 2020-07-28 08:23:45 -04:00
root.go podman-remote does not support most of the global flags 2020-10-02 06:32:17 -04:00
syslog_linux.go Fix build on OS X 2020-05-20 18:24:56 -04:00
syslog_unsupported.go Fix build on OS X 2020-05-20 18:24:56 -04:00

README.md

Podman CLI

The following is an example of how to add a new primary command (manifest) and a sub-command (inspect) to the Podman CLI. This is example code, the production code has additional error checking and the business logic provided.

See items below for details on building, installing, contributing to Podman:

Adding a new command podman manifest

$ mkdir -p $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests

Create the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests/manifest.go

package manifests

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/cmd/podman/validate"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman _manifests_
    manifestCmd = &cobra.Command{
        Use:               "manifest",
        Short:             "Manage manifests",
        Args:              cobra.ExactArgs(1),
        Long:              "Manage manifests",
        Example:           "podman manifest IMAGE",
        TraverseChildren:  true,
        RunE:              validate.SubCommandExists, // Report error if there is no sub command given
    }
)
func init() {
    // Subscribe command to podman
    registry.Commands = append(registry.Commands, registry.CliCommand{
        // _podman manifest_ will support both ABIMode and TunnelMode
        Mode:    []entities.EngineMode{entities.ABIMode, entities.TunnelMode},
        // The definition for this command
        Command: manifestCmd,
    })
}

To "wire" in the manifest command, edit the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/main.go to add:

package main

import	_ "github.com/containers/podman/cmd/podman/manifests"

Adding a new sub command podman manifests list

Create the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests/inspect.go

package manifests

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman manifests _inspect_
    inspectCmd = &cobra.Command{
        Use:     "inspect IMAGE",
        Short:   "Display manifest from image",
        Long:    "Displays the low-level information on a manifest identified by image name or ID",
        RunE:    inspect,
        Annotations: map[string]string{
            // Add this annotation if this command cannot be run rootless
            // registry.ParentNSRequired: "",
        },
        Example: "podman manifest inspect DEADBEEF",
    }
)

func init() {
    // Subscribe inspect sub command to manifest command
    registry.Commands = append(registry.Commands, registry.CliCommand{
        // _podman manifest inspect_ will support both ABIMode and TunnelMode
        Mode:    []entities.EngineMode{entities.ABIMode, entities.TunnelMode},
        // The definition for this command
        Command: inspectCmd,
        // The parent command to proceed this command on the CLI
        Parent:  manifestCmd,
    })

    // This is where you would configure the cobra flags using inspectCmd.Flags()
}

// Business logic: cmd is inspectCmd, args is the positional arguments from os.Args
func inspect(cmd *cobra.Command, args []string) error {
    // Business logic using registry.ImageEngine()
    // Do not pull from libpod directly use the domain objects and types
    return nil
}

Helper functions

The complete set can be found in the validate package, here are some examples:

  • cobra.Command{ Args: validate.NoArgs } used when the command does not accept errors
  • cobra.Command{ Args: validate.IdOrLatestArgs } used to ensure either a list of ids given or the --latest flag
  • cobra.Command{ RunE: validate.SubCommandExists } used to validate a subcommand given to a command
  • validate.ChoiceValue used to create a pflag.Value that validate user input against a provided slice of values. For example:
    flags := cobraCommand.Flags()
    created := validate.ChoiceValue(&opts.Sort, "command", "created", "id", "image", "names", "runningfor", "size", "status")
    flags.Var(created, "sort", "Sort output by: "+created.Choices())