automation-tests/cmd/podman
Ed Santiago 6864a5547a BATS tests: new too-many-arguments test
...plus a few others. And fixes to actual parsing.

If a command's usage message includes '...' in the
argument list, assume it can take unlimited arguments.
Nothing we can check.

For all others, though, the ALL-CAPS part on the
right-hand side of the usage message will define
an upper bound on the number of arguments accepted
by the command. So in our 'podman --help' test,
generate N+1 args and run that command. We expect
a 125 exit status and a suitably helpful error message.

Not all podman commands or subcommands were checking,
so I fixed that. And, fixed some broken usage messages
(all-caps FLAGS, and '[flags]' at the end of 'ARGS').
Add new checks to the help test to prevent those in
the future.

Plus a little refactoring/cleanup where necessary.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2020-06-23 14:17:48 -06:00
..
common Merge pull request #6712 from mheon/readd_userns_envvar 2020-06-23 12:19:01 +02:00
containers BATS tests: new too-many-arguments test 2020-06-23 14:17:48 -06:00
generate BATS tests: new too-many-arguments test 2020-06-23 14:17:48 -06:00
healthcheck Fix errors found when comparing podman v1 --help versus V2 2020-05-04 14:16:34 -04:00
images BATS tests: new too-many-arguments test 2020-06-23 14:17:48 -06:00
inspect Fix podman inspect on overlapping/missing objects 2020-06-16 14:33:33 -04:00
manifest BATS tests: new too-many-arguments test 2020-06-23 14:17:48 -06:00
networks BATS tests: new too-many-arguments test 2020-06-23 14:17:48 -06:00
parse podman-pod{rm,start,stop}: support --pod-id-file 2020-06-11 11:01:13 +02:00
play Fix play kube report printing when no containers are created 2020-06-05 09:58:10 -07:00
pods BATS tests: new too-many-arguments test 2020-06-23 14:17:48 -06:00
registry V2 podman system connection 2020-06-23 08:18:53 -07:00
report Fixup issues found by golint 2020-06-10 05:49:41 -04:00
system BATS tests: new too-many-arguments test 2020-06-23 14:17:48 -06:00
utils And system prune feature for v2. 2020-05-01 13:57:16 -04:00
validate BATS tests: new too-many-arguments test 2020-06-23 14:17:48 -06:00
volumes Fix Id->ID where possible for lint 2020-06-10 05:49:41 -04:00
README.md [CI:DOCS] Bring README.md up to date 2020-05-01 11:22:39 -07:00
auto-update.go auto-update: support authfiles 2020-05-12 10:20:48 +02:00
diff.go Fix Id->ID where possible for lint 2020-06-10 05:49:41 -04:00
inspect.go BATS tests: new too-many-arguments test 2020-06-23 14:17:48 -06:00
login.go Fix handling of overridden paths from database 2020-05-08 09:27:39 -04:00
logout.go Fix handling of overridden paths from database 2020-05-08 09:27:39 -04:00
main.go V2 podman system connection 2020-06-23 08:18:53 -07:00
root.go V2 podman system connection 2020-06-23 08:18:53 -07:00
syslog_linux.go Fix build on OS X 2020-05-20 18:24:56 -04:00
syslog_unsupported.go Fix build on OS X 2020-05-20 18:24:56 -04:00

README.md

Podman CLI

The following is an example of how to add a new primary command (manifest) and a sub-command (inspect) to the Podman CLI. This is example code, the production code has additional error checking and the business logic provided.

See items below for details on building, installing, contributing to Podman:

Adding a new command podman manifest

$ mkdir -p $GOPATH/src/github.com/containers/libpod/cmd/podmanV2/manifests

Create the file $GOPATH/src/github.com/containers/libpod/cmd/podmanV2/manifests/manifest.go

package manifests

import (
    "github.com/containers/libpod/cmd/podman/registry"
    "github.com/containers/libpod/cmd/podman/validate"
    "github.com/containers/libpod/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman _manifests_
    manifestCmd = &cobra.Command{
        Use:               "manifest",
        Short:             "Manage manifests",
        Args:              cobra.ExactArgs(1),
        Long:              "Manage manifests",
        Example:           "podman manifest IMAGE",
        TraverseChildren:  true,
        RunE:              validate.SubCommandExists, // Report error if there is no sub command given
    }
)
func init() {
    // Subscribe command to podman
    registry.Commands = append(registry.Commands, registry.CliCommand{
        // _podman manifest_ will support both ABIMode and TunnelMode
        Mode:    []entities.EngineMode{entities.ABIMode, entities.TunnelMode},
        // The definition for this command
        Command: manifestCmd,
    })
}

To "wire" in the manifest command, edit the file $GOPATH/src/github.com/containers/libpod/cmd/podmanV2/main.go to add:

package main

import	_ "github.com/containers/libpod/cmd/podman/manifests"

Adding a new sub command podman manifests list

Create the file $GOPATH/src/github.com/containers/libpod/cmd/podmanV2/manifests/inspect.go

package manifests

import (
    "github.com/containers/libpod/cmd/podman/registry"
    "github.com/containers/libpod/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman manifests _inspect_
    inspectCmd = &cobra.Command{
        Use:     "inspect IMAGE",
        Short:   "Display manifest from image",
        Long:    "Displays the low-level information on a manifest identified by image name or ID",
        RunE:    inspect,
        Annotations: map[string]string{
            // Add this annotation if this command cannot be run rootless
            // registry.ParentNSRequired: "",
        },
        Example: "podman manifest inspect DEADBEEF",
    }
)

func init() {
    // Subscribe inspect sub command to manifest command
    registry.Commands = append(registry.Commands, registry.CliCommand{
        // _podman manifest inspect_ will support both ABIMode and TunnelMode
        Mode:    []entities.EngineMode{entities.ABIMode, entities.TunnelMode},
        // The definition for this command
        Command: inspectCmd,
        // The parent command to proceed this command on the CLI
        Parent:  manifestCmd,
    })

    // This is where you would configure the cobra flags using inspectCmd.Flags()
}

// Business logic: cmd is inspectCmd, args is the positional arguments from os.Args
func inspect(cmd *cobra.Command, args []string) error {
    // Business logic using registry.ImageEngine()
    // Do not pull from libpod directly use the domain objects and types
    return nil
}

Helper functions

The complete set can be found in the validate package, here are some examples:

  • cobra.Command{ Args: validate.NoArgs } used when the command does not accept errors
  • cobra.Command{ Args: validate.IdOrLatestArgs } used to ensure either a list of ids given or the --latest flag
  • cobra.Command{ RunE: validate.SubCommandExists } used to validate a subcommand given to a command
  • validate.ChoiceValue used to create a pflag.Value that validate user input against a provided slice of values. For example:
    flags := cobraCommand.Flags()
    created := validate.ChoiceValue(&opts.Sort, "command", "created", "id", "image", "names", "runningfor", "size", "status")
    flags.Var(created, "sort", "Sort output by: "+created.Choices())