automation-tests/cmd/podman
Paul Holzinger 19f4a463ed
pkg/machine/e2e: do not import from cmd/podman
The same problem again as 4374038cc6.

Also fix the incorrect --format autocompletion struct.

It should be avoided to import cmd/podman/... packages from outside of
cmd/podman. This can lead in weird hard to debug import paths but also
can have negative consequences when imported in unit tests. In this case
it will set XDG_CONFIG_HOME and thus the machine tests this dir over the
tmp HOME env variable which is set at a later point. This caused machine
files to be leaked into the actual users home dir.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2022-07-21 18:04:11 +02:00
..
common Merge pull request #14904 from giuseppe/move-to-subcgroup-in-a-container 2022-07-13 09:10:57 +00:00
completion enable gocritic linter 2022-04-26 18:12:22 +02:00
containers Remove return error from "containers.pause" 2022-07-19 10:00:53 +09:00
diff cmd/podman: switch to golang native error wrapping 2022-06-30 12:58:57 +02:00
generate cmd/podman: switch to golang native error wrapping 2022-06-30 12:58:57 +02:00
healthcheck bump go module to version 4 2022-01-18 12:47:07 +01:00
images Podman pull --all-tags shorthand option 2022-07-14 10:54:24 -04:00
inspect Merge pull request #14449 from cdoern/podVolumes 2022-07-01 08:46:11 +00:00
kube Add "podman kube play" cmd 2022-07-13 15:27:03 +01:00
machine pkg/machine/e2e: do not import from cmd/podman 2022-07-21 18:04:11 +02:00
manifest cmd/podman: switch to golang native error wrapping 2022-06-30 12:58:57 +02:00
networks Refactored networkPrune function 2022-07-08 08:33:20 +09:00
parse cmd/podman: switch to golang native error wrapping 2022-06-30 12:58:57 +02:00
pods Merge pull request #14501 from cdoern/podUTS 2022-07-06 14:51:22 +00:00
registry Add --host and -H as equivalent options to --url 2022-07-18 10:41:00 -04:00
secrets cmd/podman: switch to golang native error wrapping 2022-06-30 12:58:57 +02:00
system Add podman events -f to be alias for --filter 2022-07-13 10:55:27 -04:00
utils Refactored networkPrune function 2022-07-08 08:33:20 +09:00
validate Podman stop --filter flag 2022-07-14 13:18:53 -04:00
volumes cmd/podman: switch to golang native error wrapping 2022-06-30 12:58:57 +02:00
README.md [Techinal Debt] Cleanup ABI vs. Tunnel CLI commands 2021-05-27 11:40:43 -07:00
auto-update.go cmd/podman: switch to golang native error wrapping 2022-06-30 12:58:57 +02:00
diff.go Remove unused archive flag from diff commands 2022-05-25 08:50:12 -07:00
early_init_linux.go cmd/podman: switch to golang native error wrapping 2022-06-30 12:58:57 +02:00
early_init_unsupported.go go fmt: use go 1.18 conditional-build syntax 2022-03-18 09:11:53 +01:00
inspect.go bump go module to version 4 2022-01-18 12:47:07 +01:00
login.go bump go module to version 4 2022-01-18 12:47:07 +01:00
logout.go bump go module to version 4 2022-01-18 12:47:07 +01:00
main.go Add "podman kube play" cmd 2022-07-13 15:27:03 +01:00
root.go Add --host and -H as equivalent options to --url 2022-07-18 10:41:00 -04:00
root_test.go cmd/podman: switch to golang native error wrapping 2022-06-30 12:58:57 +02:00
shell_completion_test.go bump go module to version 4 2022-01-18 12:47:07 +01:00
syslog_linux.go Fix build on OS X 2020-05-20 18:24:56 -04:00
syslog_unsupported.go go fmt: use go 1.18 conditional-build syntax 2022-03-18 09:11:53 +01:00

README.md

Podman CLI

The following is an example of how to add a new primary command (manifest) and a sub-command (inspect) to the Podman CLI. This is example code, the production code has additional error checking and the business logic provided.

See items below for details on building, installing, contributing to Podman:

Adding a new command podman manifest

$ mkdir -p $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests

Create the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests/manifest.go

package manifests

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/cmd/podman/validate"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman _manifests_
    manifestCmd = &cobra.Command{
        Use:               "manifest",
        Short:             "Manage manifests",
        Args:              cobra.ExactArgs(1),
        Long:              "Manage manifests",
        Example:           "podman manifest IMAGE",
        TraverseChildren:  true,
        RunE:              validate.SubCommandExists, // Report error if there is no sub command given
    }
)
func init() {
    // Subscribe command to podman
    registry.Commands = append(registry.Commands, registry.CliCommand{
        Command: manifestCmd,
    })
}

To "wire" in the manifest command, edit the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/main.go to add:

package main

import	_ "github.com/containers/podman/cmd/podman/manifests"

Adding a new sub command podman manifests list

Create the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests/inspect.go

package manifests

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman manifests _inspect_
    inspectCmd = &cobra.Command{
        Use:     "inspect IMAGE",
        Short:   "Display manifest from image",
        Long:    "Displays the low-level information on a manifest identified by image name or ID",
        RunE:    inspect,
        Annotations: map[string]string{
            // Add this annotation if this command cannot be run rootless
            // registry.ParentNSRequired: "",
        },
        Example: "podman manifest inspect DEADBEEF",
    }
)

func init() {
    // Subscribe inspect sub command to manifest command
    registry.Commands = append(registry.Commands, registry.CliCommand{
        Command: inspectCmd,
        // The parent command to proceed this command on the CLI
        Parent:  manifestCmd,
    })

    // This is where you would configure the cobra flags using inspectCmd.Flags()
}

// Business logic: cmd is inspectCmd, args is the positional arguments from os.Args
func inspect(cmd *cobra.Command, args []string) error {
    // Business logic using registry.ImageEngine()
    // Do not pull from libpod directly use the domain objects and types
    return nil
}

Helper functions

The complete set can be found in the validate package, here are some examples:

  • cobra.Command{ Args: validate.NoArgs } used when the command does not accept errors
  • cobra.Command{ Args: validate.IdOrLatestArgs } used to ensure either a list of ids given or the --latest flag
  • cobra.Command{ RunE: validate.SubCommandExists } used to validate a subcommand given to a command
  • validate.ChoiceValue used to create a pflag.Value that validate user input against a provided slice of values. For example:
    flags := cobraCommand.Flags()
    created := validate.ChoiceValue(&opts.Sort, "command", "created", "id", "image", "names", "runningfor", "size", "status")
    flags.Var(created, "sort", "Sort output by: "+created.Choices())