automation-tests/cmd/podman
Daniel J Walsh 332b47fefb
Check on client side for Containerfile, if none specified
Fixes: https://github.com/containers/podman/issues/16354

Currently we check on the server side, which ends up generating a bad
error message.

$ podman --remote build foo/
ERRO[0000] While reading directory /home/dwalsh/go/src/github.com/containers/podman/foo: EOF
Error: stat /var/tmp/libpod_builder1249622306/build/Dockerfile: no such file or directory

With this change you will get

./bin/podman --remote build foo/
Error: Containerfile not specified and no Containerfile or Dockerfile found in context directory, /home/dwalsh/podman/foo

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-05-08 13:58:37 -04:00
..
common Add --restart flag to pod create 2023-05-02 10:29:58 -04:00
completion build(deps): bump github.com/spf13/cobra from 1.5.0 to 1.6.0 2022-10-12 14:54:19 +02:00
containers Add {{.Restarts}} to podman ps 2023-05-02 10:30:07 -04:00
diff cmd/podman: switch to golang native error wrapping 2022-06-30 12:58:57 +02:00
generate Replace deprecated ioutil 2022-09-20 15:34:27 -04:00
healthcheck Add support for startup healthchecks 2022-11-28 13:30:29 -05:00
images Check on client side for Containerfile, if none specified 2023-05-08 13:58:37 -04:00
inspect podman inspect return exit code > 0 on print error 2022-09-13 10:33:14 +02:00
kube podman: simplify code with a switch 2023-04-27 22:07:56 +02:00
machine Merge pull request #18402 from baude/applehvpass1 2023-05-03 10:17:51 -04:00
manifest manifest, push: use source as destination if not specified 2023-05-01 17:04:11 +05:30
networks Update short description for disconnect cmd 2023-04-27 13:33:28 +02:00
parse Use containers/storage/pkg/regexp in place of regexp 2023-01-12 18:33:38 -05:00
pods Add {{.Restarts}} to podman pod ps 2023-05-02 10:30:07 -04:00
registry cmd: clarify meaning of ParentNSRequired 2023-03-03 14:27:54 +01:00
secrets Add support for secret exists 2023-04-03 15:33:50 +03:00
system Merge pull request #18354 from Luap99/reset 2023-05-03 05:26:01 -04:00
utils Fix typos. Improve language. 2023-02-09 21:56:27 +01:00
validate bump golangci-lint to v1.49.0 2022-10-17 09:19:41 +02:00
volumes make example volume import, not import volume 2023-01-24 14:29:45 -08:00
README.md [Techinal Debt] Cleanup ABI vs. Tunnel CLI commands 2021-05-27 11:40:43 -07:00
auto-update.go podman auto-update: use report.Formatter over Template 2022-09-13 10:33:12 +02:00
diff.go Remove unused archive flag from diff commands 2022-05-25 08:50:12 -07:00
early_init_linux.go Fix stutters 2022-09-10 07:52:00 -04:00
early_init_unsupported.go go fmt: use go 1.18 conditional-build syntax 2022-03-18 09:11:53 +01:00
inspect.go bump go module to version 4 2022-01-18 12:47:07 +01:00
login.go bump go module to version 4 2022-01-18 12:47:07 +01:00
logout.go bump go module to version 4 2022-01-18 12:47:07 +01:00
main.go cmd: drop special handling for "scp" 2023-03-03 14:27:54 +01:00
root.go remote: return better connect error 2023-05-03 18:19:58 +02:00
root_test.go cmd/podman: switch to golang native error wrapping 2022-06-30 12:58:57 +02:00
shell_completion_test.go bump go module to version 4 2022-01-18 12:47:07 +01:00
syslog_common.go cmd/podman: Enable --syslog on FreeBSD 2022-08-26 08:01:02 +01:00
syslog_unsupported.go cmd/podman: Enable --syslog on FreeBSD 2022-08-26 08:01:02 +01:00

README.md

Podman CLI

The following is an example of how to add a new primary command (manifest) and a sub-command (inspect) to the Podman CLI. This is example code, the production code has additional error checking and the business logic provided.

See items below for details on building, installing, contributing to Podman:

Adding a new command podman manifest

$ mkdir -p $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests

Create the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests/manifest.go

package manifests

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/cmd/podman/validate"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman _manifests_
    manifestCmd = &cobra.Command{
        Use:               "manifest",
        Short:             "Manage manifests",
        Args:              cobra.ExactArgs(1),
        Long:              "Manage manifests",
        Example:           "podman manifest IMAGE",
        TraverseChildren:  true,
        RunE:              validate.SubCommandExists, // Report error if there is no sub command given
    }
)
func init() {
    // Subscribe command to podman
    registry.Commands = append(registry.Commands, registry.CliCommand{
        Command: manifestCmd,
    })
}

To "wire" in the manifest command, edit the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/main.go to add:

package main

import	_ "github.com/containers/podman/cmd/podman/manifests"

Adding a new sub command podman manifests list

Create the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests/inspect.go

package manifests

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman manifests _inspect_
    inspectCmd = &cobra.Command{
        Use:     "inspect IMAGE",
        Short:   "Display manifest from image",
        Long:    "Displays the low-level information on a manifest identified by image name or ID",
        RunE:    inspect,
        Annotations: map[string]string{
            // Add this annotation if this command cannot be run rootless
            // registry.ParentNSRequired: "",
        },
        Example: "podman manifest inspect DEADBEEF",
    }
)

func init() {
    // Subscribe inspect sub command to manifest command
    registry.Commands = append(registry.Commands, registry.CliCommand{
        Command: inspectCmd,
        // The parent command to proceed this command on the CLI
        Parent:  manifestCmd,
    })

    // This is where you would configure the cobra flags using inspectCmd.Flags()
}

// Business logic: cmd is inspectCmd, args is the positional arguments from os.Args
func inspect(cmd *cobra.Command, args []string) error {
    // Business logic using registry.ImageEngine()
    // Do not pull from libpod directly use the domain objects and types
    return nil
}

Helper functions

The complete set can be found in the validate package, here are some examples:

  • cobra.Command{ Args: validate.NoArgs } used when the command does not accept errors
  • cobra.Command{ Args: validate.IdOrLatestArgs } used to ensure either a list of ids given or the --latest flag
  • cobra.Command{ RunE: validate.SubCommandExists } used to validate a subcommand given to a command
  • validate.ChoiceValue used to create a pflag.Value that validate user input against a provided slice of values. For example:
    flags := cobraCommand.Flags()
    created := validate.ChoiceValue(&opts.Sort, "command", "created", "id", "image", "names", "runningfor", "size", "status")
    flags.Var(created, "sort", "Sort output by: "+created.Choices())