automation-tests/cmd/podman
Sascha Grunert d02cb2ddc0
Fix log level case regression
With previous versions of Podman (like v1.9.2) it was always possible to
specify the log level in any case, for example `INFO`. This behavior has
silently changed, where the `--log-level` flag only accepts lower case
levels. This commit re-enables the old behavior and adds an e2e test for
it.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
2020-08-28 12:09:08 +02:00
..
common podman: add option --cgroup-conf 2020-08-21 19:06:05 +02:00
containers fix pod creation with "new:" syntax followup + allow hostname 2020-08-20 16:28:45 +02:00
generate Switch all references to github.com/containers/libpod -> podman 2020-07-28 08:23:45 -04:00
healthcheck Switch all references to github.com/containers/libpod -> podman 2020-07-28 08:23:45 -04:00
images podman save use named pipe 2020-08-12 10:03:41 -04:00
inspect Switch all references to github.com/containers/libpod -> podman 2020-07-28 08:23:45 -04:00
manifest Switch all references to github.com/containers/libpod -> podman 2020-07-28 08:23:45 -04:00
networks Switch all references to github.com/containers/libpod -> podman 2020-07-28 08:23:45 -04:00
parse version/info: format: allow more json variants 2020-07-10 15:44:17 +02:00
play Switch all references to github.com/containers/libpod -> podman 2020-07-28 08:23:45 -04:00
pods Switch all references to github.com/containers/libpod -> podman 2020-07-28 08:23:45 -04:00
registry Remove help/usage from --remote pre-check 2020-08-18 08:57:00 -07:00
report Switch all references to github.com/containers/libpod -> podman 2020-07-28 08:23:45 -04:00
system Add support for --connection 2020-08-19 08:37:44 -07:00
utils Support sighup reload configuration files 2020-08-18 14:42:49 -04:00
validate remove --latest for all remote commands 2020-08-10 12:05:39 -05:00
volumes Switch all references to github.com/containers/libpod -> podman 2020-07-28 08:23:45 -04:00
README.md Switch all references to github.com/containers/libpod -> podman 2020-07-28 08:23:45 -04:00
auto-update.go Switch all references to github.com/containers/libpod -> podman 2020-07-28 08:23:45 -04:00
diff.go Switch all references to github.com/containers/libpod -> podman 2020-07-28 08:23:45 -04:00
early_init_linux.go Add support for --connection 2020-08-19 08:37:44 -07:00
early_init_unsupported.go abi: set default umask and rlimits 2020-07-17 20:53:38 +02:00
inspect.go Switch all references to github.com/containers/libpod -> podman 2020-07-28 08:23:45 -04:00
login.go Switch all references to github.com/containers/libpod -> podman 2020-07-28 08:23:45 -04:00
logout.go Switch all references to github.com/containers/libpod -> podman 2020-07-28 08:23:45 -04:00
main.go Switch all references to github.com/containers/libpod -> podman 2020-07-28 08:23:45 -04:00
root.go Fix log level case regression 2020-08-28 12:09:08 +02:00
syslog_linux.go Fix build on OS X 2020-05-20 18:24:56 -04:00
syslog_unsupported.go Fix build on OS X 2020-05-20 18:24:56 -04:00

README.md

Podman CLI

The following is an example of how to add a new primary command (manifest) and a sub-command (inspect) to the Podman CLI. This is example code, the production code has additional error checking and the business logic provided.

See items below for details on building, installing, contributing to Podman:

Adding a new command podman manifest

$ mkdir -p $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests

Create the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests/manifest.go

package manifests

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/cmd/podman/validate"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman _manifests_
    manifestCmd = &cobra.Command{
        Use:               "manifest",
        Short:             "Manage manifests",
        Args:              cobra.ExactArgs(1),
        Long:              "Manage manifests",
        Example:           "podman manifest IMAGE",
        TraverseChildren:  true,
        RunE:              validate.SubCommandExists, // Report error if there is no sub command given
    }
)
func init() {
    // Subscribe command to podman
    registry.Commands = append(registry.Commands, registry.CliCommand{
        // _podman manifest_ will support both ABIMode and TunnelMode
        Mode:    []entities.EngineMode{entities.ABIMode, entities.TunnelMode},
        // The definition for this command
        Command: manifestCmd,
    })
}

To "wire" in the manifest command, edit the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/main.go to add:

package main

import	_ "github.com/containers/podman/cmd/podman/manifests"

Adding a new sub command podman manifests list

Create the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests/inspect.go

package manifests

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman manifests _inspect_
    inspectCmd = &cobra.Command{
        Use:     "inspect IMAGE",
        Short:   "Display manifest from image",
        Long:    "Displays the low-level information on a manifest identified by image name or ID",
        RunE:    inspect,
        Annotations: map[string]string{
            // Add this annotation if this command cannot be run rootless
            // registry.ParentNSRequired: "",
        },
        Example: "podman manifest inspect DEADBEEF",
    }
)

func init() {
    // Subscribe inspect sub command to manifest command
    registry.Commands = append(registry.Commands, registry.CliCommand{
        // _podman manifest inspect_ will support both ABIMode and TunnelMode
        Mode:    []entities.EngineMode{entities.ABIMode, entities.TunnelMode},
        // The definition for this command
        Command: inspectCmd,
        // The parent command to proceed this command on the CLI
        Parent:  manifestCmd,
    })

    // This is where you would configure the cobra flags using inspectCmd.Flags()
}

// Business logic: cmd is inspectCmd, args is the positional arguments from os.Args
func inspect(cmd *cobra.Command, args []string) error {
    // Business logic using registry.ImageEngine()
    // Do not pull from libpod directly use the domain objects and types
    return nil
}

Helper functions

The complete set can be found in the validate package, here are some examples:

  • cobra.Command{ Args: validate.NoArgs } used when the command does not accept errors
  • cobra.Command{ Args: validate.IdOrLatestArgs } used to ensure either a list of ids given or the --latest flag
  • cobra.Command{ RunE: validate.SubCommandExists } used to validate a subcommand given to a command
  • validate.ChoiceValue used to create a pflag.Value that validate user input against a provided slice of values. For example:
    flags := cobraCommand.Flags()
    created := validate.ChoiceValue(&opts.Sort, "command", "created", "id", "image", "names", "runningfor", "size", "status")
    flags.Var(created, "sort", "Sort output by: "+created.Choices())