It was added for debian so they could build without the deps but this is
no longer needed. Get rid of it to simplify the codebase.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
It was added for debian so they could build without the deps but this is
no longer needed, the tag is broken and fails to compile so just get rid
of it to simplify the codebase.
Fixes: #2877
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Currently, ostree does not compile:
> ostree/ostree_dest.go:115:28: cannot use d (variable of type *ostreeImageDestination) as private.ImageDestinationInternalOnly value in argument to impl.AddCompat: *ostreeImageDestination does not implement private.ImageDestinationInternalOnly (missing method NoteOriginalOCIConfig) (typecheck)
> d.Compat = impl.AddCompat(d)
This has been broken since b941c6bf41 (Nov 18 2024, > 4 months).
Previously:
- 807381f448 (broken almost 4 months),
- 2e33bf7d27 (broken > 7 months)
Overall, it seems extremely likely that noone is using the
containers_image_ostree build tag (off by default since March 2019).
So, finally, give up, and delete the code. Most importantly, this allows us
to delete the > 3-year-old-frozen dependency, and risky CGo code.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
For situations where Fulcio and Rekor operations are not required,
this commit provides buildtags to avoid those dependencies.
Signed-off-by: Reinhard Tartler <siretart@gmail.com>
Since only Skopeo uses the OStree transport for fetching images from
OStree repositories, making default no support for OStree. It
simplifies building on other components like libpod and buildah.
Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
These are from f4d6188f (Make it easier for CONTRIBUTORS to find
information, 2018-07-05, #474). I dunno if they were intentional or
not, but I thought they might be footnote markers so I scrolled down
to the bottom of the README looking for a footnote. Remove them to
save other people from that same confusion ;).
Signed-off-by: W. Trevor King <wking@tremily.us>
Set the containers_image_ostree_stub build tag automatically on macOS;
at least right now, ostree/src/libostree/ostree-linuxfsutil.c hard-codes
Linux-specific header files and ioctls, so we are fairly sure that it will
not be available no macOS.
Make the ostree subpackage also conditional on containers_image_ostree_stub ,
so that we don't even try to build it (and any reference to it fails with
"no buildable source files").
Finally, use $BUILDFLAGS also in (go list) when listing the subpackages,
so that we don't try to run tests in the ostree subpackage (and therefore
try to build it) when it has been disabled.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
If this tag is defined, transports/alltransports registers a stub
instead of the real package.
Also updates README, adding the ostree-devel dependency to the dnf
command and restructuring it to have a list of build tags.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
… instead of just documenting how to avoid it.
And move the (make BUILDTAGS=…) variant into the “Contributing”
subsection, it is not useful when integrating this into another project.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
(go build ./...) is entirely useless when not developing this project:
per (go help build):
> When compiling multiple packages or a single non-main package,
> build compiles the packages but discards the resulting object,
> serving only as a check that the packages can be built.
Instead, add a starting point for integrating the library into a user.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
It is not something people just wanting to use the project care about,
and we want to make the containers_image_openpgp tag clearly related.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Be a bit more explicit about the lack of “vendor” subdirectory.
… and use a file name instead of “here” as a link title to make it
easier to see what it points to.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This is not really a new content, just emphasizing the existence of
skopeo as a starting point—and highlights `copy.Image`.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
The default is gpgme; a containers_image_openpgp build tag can be used
to use openpgp instead.
openpgp does not currently support signing, and is based on mfojtik's
implementation (adding GPG home directory support, parsing of unarmored
keys, and fixing ImportKeysFromBytes semantics).
Also adds build documentation, including the new
containers_image_openpgp build tag, to README.md.
This does not yet hook this into Travis, because that needs a
corresponding skopeo build infrastructure and test update to make it
possible. That is a separate commit (perhaps a separate PR)?
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Resolves https://github.com/projectatomic/skopeo/issues/12
* Convert man page from markdown to nroff
* Fill out man page
* Remove TODO's from go code regarding man page
* Additional information on building instructions
* Update Makfile
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Paul Holzinger