Commit Graph

6 Commits

Author SHA1 Message Date
Miloslav Trmač 004d4684b6 Don't assume that &pkg/regexp.Regexp implements any methods
See https://github.com/containers/storage/pull/1651 for more discussion.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2023-06-27 18:56:06 +02:00
Daniel J Walsh 27cfaea55d
Do not preallocate regex in init program
We are trying to speed up startup time of apps based on
containers/image regex takes some time on every start
when in init. Moving this to a sync.Once should not
effect any change on the system.

Only changing internal regexp, since changing external would be a
breaking change to the library.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-01-13 16:49:57 -05:00
Daniel J Walsh b30947b041
Drop dead code that causes a regex compilation on init
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-01-13 16:21:42 -05:00
Valentin Rothberg 40befe38b2 docker/referece: add IsFullIdentifier
containers/common/libimage is in need to check whether a given input
looks like a full image ID (i.e., a 64-byte hex string).  Since
compiling regexes has a negative impact on init- and run-time, let's
expose a function to check whether a given string matches the already
compiled regex in docker/reference.

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2022-02-24 10:25:02 +01:00
Miloslav Trmač 6ddbf03773 Update docker/reference from docker/distribution/reference
Primarily to make DomainRegexp public.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2019-05-29 00:30:55 +02:00
Miloslav Trmač ecdd233c84 Copy github.com/docker/distribution/reference to docker/reference
This replaces the copy of github.com/docker/docker/reference in the same
place, which we have just gotten rid of, and allows using this package
even in consumers which insist on an incompatible version of
docker/distribution.

The copy has been edited to drop a reference to
github.com/docker/distribution/digestset .

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2017-02-07 15:25:27 +01:00