containers
/
podman
mirror of https://github.com/containers/podman.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #15788 from kolyshkin/non-crypto-id 

all: stop using deprecated GenerateNonCryptoID
This commit is contained in:
OpenShift Merge Robot 2022-09-14 16:17:37 +02:00 committed by GitHub
parent a3876c2f85 75740be395
commit 017d81ddd0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
21 changed files with 101 additions and 101 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libpod/container_exec.go
View File

@ -182,7 +182,7 @@ func (c *Container) ExecCreate(config *ExecConfig) (string, error) {
} }
// Generate an ID for our new exec session // Generate an ID for our new exec session
sessionID := stringid.GenerateNonCryptoID() sessionID := stringid.GenerateRandomID()
found := true found := true
// This really ought to be a do-while, but Go doesn't have those... // This really ought to be a do-while, but Go doesn't have those...
for found { for found {
@ -194,7 +194,7 @@ func (c *Container) ExecCreate(config *ExecConfig) (string, error) {
} }
} }
if found { if found {
sessionID = stringid.GenerateNonCryptoID() sessionID = stringid.GenerateRandomID()
} }
} }

2
libpod/pod_internal.go
View File

@ -16,7 +16,7 @@ import (
func newPod(runtime *Runtime) *Pod { func newPod(runtime *Runtime) *Pod {
pod := new(Pod) pod := new(Pod)
pod.config = new(PodConfig) pod.config = new(PodConfig)
pod.config.ID = stringid.GenerateNonCryptoID() pod.config.ID = stringid.GenerateRandomID()
pod.config.Labels = make(map[string]string) pod.config.Labels = make(map[string]string)
pod.config.CreatedTime = time.Now() pod.config.CreatedTime = time.Now()
// pod.config.InfraContainer = new(ContainerConfig) // pod.config.InfraContainer = new(ContainerConfig)

6
libpod/runtime_ctr.go
View File

@ -169,7 +169,7 @@ func (r *Runtime) initContainerVariables(rSpec *spec.Spec, config *ContainerConf
ctr.state = new(ContainerState) ctr.state = new(ContainerState)
if config == nil { if config == nil {
ctr.config.ID = stringid.GenerateNonCryptoID() ctr.config.ID = stringid.GenerateRandomID()
size, err := units.FromHumanSize(r.config.Containers.ShmSize) size, err := units.FromHumanSize(r.config.Containers.ShmSize)
if useDevShm { if useDevShm {
if err != nil { if err != nil {
@ -193,7 +193,7 @@ func (r *Runtime) initContainerVariables(rSpec *spec.Spec, config *ContainerConf
} }
// If the ID is empty a new name for the restored container was requested // If the ID is empty a new name for the restored container was requested
if ctr.config.ID == "" { if ctr.config.ID == "" {
ctr.config.ID = stringid.GenerateNonCryptoID() ctr.config.ID = stringid.GenerateRandomID()
} }
// Reset the log path to point to the default // Reset the log path to point to the default
ctr.config.LogPath = "" ctr.config.LogPath = ""
@ -466,7 +466,7 @@ func (r *Runtime) setupContainer(ctx context.Context, ctr *Container) (_ *Contai
if vol.Name == "" { if vol.Name == "" {
// Anonymous volume. We'll need to create it. // Anonymous volume. We'll need to create it.
// It needs a name first. // It needs a name first.
vol.Name = stringid.GenerateNonCryptoID() vol.Name = stringid.GenerateRandomID()
isAnonymous = true isAnonymous = true
} else { } else {
// Check if it exists already // Check if it exists already

2
libpod/runtime_volume_linux.go
View File

@ -42,7 +42,7 @@ func (r *Runtime) newVolume(noCreatePluginVolume bool, options ...VolumeCreateOp
} }
if volume.config.Name == "" { if volume.config.Name == "" {
volume.config.Name = stringid.GenerateNonCryptoID() volume.config.Name = stringid.GenerateRandomID()
} }
if volume.config.Driver == "" { if volume.config.Driver == "" {
volume.config.Driver = define.VolumeDriverLocal volume.config.Driver = define.VolumeDriverLocal

6
test/e2e/common_test.go
View File

@ -306,7 +306,7 @@ func PodmanTestCreateUtil(tempDir string, remote bool) *PodmanTestIntegration {
// happens. So, use a podman-%s.sock-lock empty file as a marker. // happens. So, use a podman-%s.sock-lock empty file as a marker.
tries := 0 tries := 0
for { for {
uuid := stringid.GenerateNonCryptoID() uuid := stringid.GenerateRandomID()
lockPath := fmt.Sprintf("%s-%s.sock-lock", pathPrefix, uuid) lockPath := fmt.Sprintf("%s-%s.sock-lock", pathPrefix, uuid)
lockFile, err := os.OpenFile(lockPath, os.O_WRONLY|os.O_CREATE|os.O_EXCL, 0700) lockFile, err := os.OpenFile(lockPath, os.O_WRONLY|os.O_CREATE|os.O_EXCL, 0700)
if err == nil { if err == nil {
@ -894,7 +894,7 @@ func generateNetworkConfig(p *PodmanTestIntegration) (string, string) {
conf string conf string
) )
// generate a random name to prevent conflicts with other tests // generate a random name to prevent conflicts with other tests
name := "net" + stringid.GenerateNonCryptoID() name := "net" + stringid.GenerateRandomID()
if p.NetworkBackend != Netavark { if p.NetworkBackend != Netavark {
path = filepath.Join(p.NetworkConfigDir, fmt.Sprintf("%s.conflist", name)) path = filepath.Join(p.NetworkConfigDir, fmt.Sprintf("%s.conflist", name))
conf = fmt.Sprintf(`{ conf = fmt.Sprintf(`{
@ -1030,7 +1030,7 @@ func ncz(port int) bool {
} }
func createNetworkName(name string) string { func createNetworkName(name string) string {
return name + stringid.GenerateNonCryptoID()[:10] return name + stringid.GenerateRandomID()[:10]
} }
var IPRegex = `(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)(\.(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)){3}` var IPRegex = `(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)(\.(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)){3}`

2
test/e2e/create_staticmac_test.go
View File

@ -48,7 +48,7 @@ var _ = Describe("Podman run with --mac-address flag", func() {
}) })
It("Podman run --mac-address with custom network", func() { It("Podman run --mac-address with custom network", func() {
net := "n1" + stringid.GenerateNonCryptoID() net := "n1" + stringid.GenerateRandomID()
session := podmanTest.Podman([]string{"network", "create", net}) session := podmanTest.Podman([]string{"network", "create", net})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(net) defer podmanTest.removeNetwork(net)

2
test/e2e/create_test.go
View File

@ -595,7 +595,7 @@ var _ = Describe("Podman create", func() {
pod.WaitWithDefaultTimeout() pod.WaitWithDefaultTimeout()
Expect(pod).Should(Exit(0)) Expect(pod).Should(Exit(0))
netName := "pod" + stringid.GenerateNonCryptoID() netName := "pod" + stringid.GenerateRandomID()
session := podmanTest.Podman([]string{"network", "create", netName}) session := podmanTest.Podman([]string{"network", "create", netName})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))

10
test/e2e/diff_test.go
View File

@ -93,9 +93,9 @@ var _ = Describe("Podman diff", func() {
}) })
It("podman image diff", func() { It("podman image diff", func() {
file1 := "/" + stringid.GenerateNonCryptoID() file1 := "/" + stringid.GenerateRandomID()
file2 := "/" + stringid.GenerateNonCryptoID() file2 := "/" + stringid.GenerateRandomID()
file3 := "/" + stringid.GenerateNonCryptoID() file3 := "/" + stringid.GenerateRandomID()
// Create container image with the files // Create container image with the files
containerfile := fmt.Sprintf(` containerfile := fmt.Sprintf(`
@ -152,8 +152,8 @@ RUN echo test
}) })
It("podman diff container and image with same name", func() { It("podman diff container and image with same name", func() {
imagefile := "/" + stringid.GenerateNonCryptoID() imagefile := "/" + stringid.GenerateRandomID()
confile := "/" + stringid.GenerateNonCryptoID() confile := "/" + stringid.GenerateRandomID()
// Create container image with the files // Create container image with the files
containerfile := fmt.Sprintf(` containerfile := fmt.Sprintf(`

6
test/e2e/events_test.go
View File

@ -154,9 +154,9 @@ var _ = Describe("Podman events", func() {
}) })
It("podman events --until future", func() { It("podman events --until future", func() {
name1 := stringid.GenerateNonCryptoID() name1 := stringid.GenerateRandomID()
name2 := stringid.GenerateNonCryptoID() name2 := stringid.GenerateRandomID()
name3 := stringid.GenerateNonCryptoID() name3 := stringid.GenerateRandomID()
session := podmanTest.Podman([]string{"create", "--name", name1, ALPINE}) session := podmanTest.Podman([]string{"create", "--name", name1, ALPINE})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))

2
test/e2e/logs_test.go
View File

@ -376,7 +376,7 @@ var _ = Describe("Podman logs", func() {
skipIfJournaldInContainer() skipIfJournaldInContainer()
cname := "log-test" cname := "log-test"
content := stringid.GenerateNonCryptoID() content := stringid.GenerateRandomID()
// use printf to print no extra newline // use printf to print no extra newline
logc := podmanTest.Podman([]string{"run", "--log-driver", log, "--name", cname, ALPINE, "printf", content}) logc := podmanTest.Podman([]string{"run", "--log-driver", log, "--name", cname, ALPINE, "printf", content})
logc.WaitWithDefaultTimeout() logc.WaitWithDefaultTimeout()

30
test/e2e/network_connect_disconnect_test.go
View File

@ -41,7 +41,7 @@ var _ = Describe("Podman network connect and disconnect", func() {
}) })
It("bad container name in network disconnect should result in error", func() { It("bad container name in network disconnect should result in error", func() {
netName := "aliasTest" + stringid.GenerateNonCryptoID() netName := "aliasTest" + stringid.GenerateRandomID()
session := podmanTest.Podman([]string{"network", "create", netName}) session := podmanTest.Podman([]string{"network", "create", netName})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))
@ -53,7 +53,7 @@ var _ = Describe("Podman network connect and disconnect", func() {
}) })
It("network disconnect with net mode slirp4netns should result in error", func() { It("network disconnect with net mode slirp4netns should result in error", func() {
netName := "slirp" + stringid.GenerateNonCryptoID() netName := "slirp" + stringid.GenerateRandomID()
session := podmanTest.Podman([]string{"network", "create", netName}) session := podmanTest.Podman([]string{"network", "create", netName})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))
@ -72,7 +72,7 @@ var _ = Describe("Podman network connect and disconnect", func() {
It("podman network disconnect", func() { It("podman network disconnect", func() {
SkipIfRootlessCgroupsV1("stats not supported under rootless CgroupsV1") SkipIfRootlessCgroupsV1("stats not supported under rootless CgroupsV1")
netName := "aliasTest" + stringid.GenerateNonCryptoID() netName := "aliasTest" + stringid.GenerateRandomID()
session := podmanTest.Podman([]string{"network", "create", netName}) session := podmanTest.Podman([]string{"network", "create", netName})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))
@ -128,7 +128,7 @@ var _ = Describe("Podman network connect and disconnect", func() {
}) })
It("bad container name in network connect should result in error", func() { It("bad container name in network connect should result in error", func() {
netName := "aliasTest" + stringid.GenerateNonCryptoID() netName := "aliasTest" + stringid.GenerateRandomID()
session := podmanTest.Podman([]string{"network", "create", netName}) session := podmanTest.Podman([]string{"network", "create", netName})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))
@ -140,7 +140,7 @@ var _ = Describe("Podman network connect and disconnect", func() {
}) })
It("network connect with net mode slirp4netns should result in error", func() { It("network connect with net mode slirp4netns should result in error", func() {
netName := "slirp" + stringid.GenerateNonCryptoID() netName := "slirp" + stringid.GenerateRandomID()
session := podmanTest.Podman([]string{"network", "create", netName}) session := podmanTest.Podman([]string{"network", "create", netName})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))
@ -158,7 +158,7 @@ var _ = Describe("Podman network connect and disconnect", func() {
}) })
It("podman connect on a container that already is connected to the network should error after init", func() { It("podman connect on a container that already is connected to the network should error after init", func() {
netName := "aliasTest" + stringid.GenerateNonCryptoID() netName := "aliasTest" + stringid.GenerateRandomID()
session := podmanTest.Podman([]string{"network", "create", netName}) session := podmanTest.Podman([]string{"network", "create", netName})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))
@ -190,7 +190,7 @@ var _ = Describe("Podman network connect and disconnect", func() {
It("podman network connect", func() { It("podman network connect", func() {
SkipIfRootlessCgroupsV1("stats not supported under rootless CgroupsV1") SkipIfRootlessCgroupsV1("stats not supported under rootless CgroupsV1")
netName := "aliasTest" + stringid.GenerateNonCryptoID() netName := "aliasTest" + stringid.GenerateRandomID()
session := podmanTest.Podman([]string{"network", "create", netName}) session := podmanTest.Podman([]string{"network", "create", netName})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))
@ -206,7 +206,7 @@ var _ = Describe("Podman network connect and disconnect", func() {
Expect(exec).Should(Exit(0)) Expect(exec).Should(Exit(0))
// Create a second network // Create a second network
newNetName := "aliasTest" + stringid.GenerateNonCryptoID() newNetName := "aliasTest" + stringid.GenerateRandomID()
session = podmanTest.Podman([]string{"network", "create", newNetName, "--subnet", "10.11.100.0/24"}) session = podmanTest.Podman([]string{"network", "create", newNetName, "--subnet", "10.11.100.0/24"})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))
@ -264,13 +264,13 @@ var _ = Describe("Podman network connect and disconnect", func() {
}) })
It("podman network connect when not running", func() { It("podman network connect when not running", func() {
netName1 := "connect1" + stringid.GenerateNonCryptoID() netName1 := "connect1" + stringid.GenerateRandomID()
session := podmanTest.Podman([]string{"network", "create", netName1}) session := podmanTest.Podman([]string{"network", "create", netName1})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))
defer podmanTest.removeNetwork(netName1) defer podmanTest.removeNetwork(netName1)
netName2 := "connect2" + stringid.GenerateNonCryptoID() netName2 := "connect2" + stringid.GenerateRandomID()
session = podmanTest.Podman([]string{"network", "create", netName2}) session = podmanTest.Podman([]string{"network", "create", netName2})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))
@ -303,7 +303,7 @@ var _ = Describe("Podman network connect and disconnect", func() {
}) })
It("podman network connect and run with network ID", func() { It("podman network connect and run with network ID", func() {
netName := "ID" + stringid.GenerateNonCryptoID() netName := "ID" + stringid.GenerateRandomID()
session := podmanTest.Podman([]string{"network", "create", netName}) session := podmanTest.Podman([]string{"network", "create", netName})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))
@ -323,7 +323,7 @@ var _ = Describe("Podman network connect and disconnect", func() {
Expect(exec).Should(Exit(0)) Expect(exec).Should(Exit(0))
// Create a second network // Create a second network
newNetName := "ID2" + stringid.GenerateNonCryptoID() newNetName := "ID2" + stringid.GenerateRandomID()
session = podmanTest.Podman([]string{"network", "create", newNetName}) session = podmanTest.Podman([]string{"network", "create", newNetName})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))
@ -350,13 +350,13 @@ var _ = Describe("Podman network connect and disconnect", func() {
}) })
It("podman network disconnect when not running", func() { It("podman network disconnect when not running", func() {
netName1 := "aliasTest" + stringid.GenerateNonCryptoID() netName1 := "aliasTest" + stringid.GenerateRandomID()
session := podmanTest.Podman([]string{"network", "create", netName1}) session := podmanTest.Podman([]string{"network", "create", netName1})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))
defer podmanTest.removeNetwork(netName1) defer podmanTest.removeNetwork(netName1)
netName2 := "aliasTest" + stringid.GenerateNonCryptoID() netName2 := "aliasTest" + stringid.GenerateRandomID()
session2 := podmanTest.Podman([]string{"network", "create", netName2}) session2 := podmanTest.Podman([]string{"network", "create", netName2})
session2.WaitWithDefaultTimeout() session2.WaitWithDefaultTimeout()
Expect(session2).Should(Exit(0)) Expect(session2).Should(Exit(0))
@ -395,7 +395,7 @@ var _ = Describe("Podman network connect and disconnect", func() {
}) })
It("podman network disconnect and run with network ID", func() { It("podman network disconnect and run with network ID", func() {
netName := "aliasTest" + stringid.GenerateNonCryptoID() netName := "aliasTest" + stringid.GenerateRandomID()
session := podmanTest.Podman([]string{"network", "create", netName}) session := podmanTest.Podman([]string{"network", "create", netName})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))

46
test/e2e/network_create_test.go
View File

@ -41,7 +41,7 @@ var _ = Describe("Podman network create", func() {
}) })
It("podman network create with name and subnet", func() { It("podman network create with name and subnet", func() {
netName := "subnet-" + stringid.GenerateNonCryptoID() netName := "subnet-" + stringid.GenerateRandomID()
nc := podmanTest.Podman([]string{"network", "create", "--subnet", "10.11.12.0/24", "--ip-range", "10.11.12.0/26", netName}) nc := podmanTest.Podman([]string{"network", "create", "--subnet", "10.11.12.0/24", "--ip-range", "10.11.12.0/26", netName})
nc.WaitWithDefaultTimeout() nc.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(netName) defer podmanTest.removeNetwork(netName)
@ -84,7 +84,7 @@ var _ = Describe("Podman network create", func() {
}) })
It("podman network create with name and IPv6 subnet", func() { It("podman network create with name and IPv6 subnet", func() {
netName := "ipv6-" + stringid.GenerateNonCryptoID() netName := "ipv6-" + stringid.GenerateRandomID()
nc := podmanTest.Podman([]string{"network", "create", "--subnet", "fd00:1:2:3:4::/64", netName}) nc := podmanTest.Podman([]string{"network", "create", "--subnet", "fd00:1:2:3:4::/64", netName})
nc.WaitWithDefaultTimeout() nc.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(netName) defer podmanTest.removeNetwork(netName)
@ -123,7 +123,7 @@ var _ = Describe("Podman network create", func() {
}) })
It("podman network create with name and IPv6 flag (dual-stack)", func() { It("podman network create with name and IPv6 flag (dual-stack)", func() {
netName := "dual-" + stringid.GenerateNonCryptoID() netName := "dual-" + stringid.GenerateRandomID()
nc := podmanTest.Podman([]string{"network", "create", "--subnet", "fd00:4:3:2::/64", "--ipv6", netName}) nc := podmanTest.Podman([]string{"network", "create", "--subnet", "fd00:4:3:2::/64", "--ipv6", netName})
nc.WaitWithDefaultTimeout() nc.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(netName) defer podmanTest.removeNetwork(netName)
@ -156,7 +156,7 @@ var _ = Describe("Podman network create", func() {
// create a second network to check the auto assigned ipv4 subnet does not overlap // create a second network to check the auto assigned ipv4 subnet does not overlap
// https://github.com/containers/podman/issues/11032 // https://github.com/containers/podman/issues/11032
netName2 := "dual-" + stringid.GenerateNonCryptoID() netName2 := "dual-" + stringid.GenerateRandomID()
nc = podmanTest.Podman([]string{"network", "create", "--subnet", "fd00:10:3:2::/64", "--ipv6", netName2}) nc = podmanTest.Podman([]string{"network", "create", "--subnet", "fd00:10:3:2::/64", "--ipv6", netName2})
nc.WaitWithDefaultTimeout() nc.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(netName2) defer podmanTest.removeNetwork(netName2)
@ -204,13 +204,13 @@ var _ = Describe("Podman network create", func() {
}) })
It("podman network create with invalid subnet", func() { It("podman network create with invalid subnet", func() {
nc := podmanTest.Podman([]string{"network", "create", "--subnet", "10.11.12.0/17000", stringid.GenerateNonCryptoID()}) nc := podmanTest.Podman([]string{"network", "create", "--subnet", "10.11.12.0/17000", stringid.GenerateRandomID()})
nc.WaitWithDefaultTimeout() nc.WaitWithDefaultTimeout()
Expect(nc).To(ExitWithError()) Expect(nc).To(ExitWithError())
}) })
It("podman network create with ipv4 subnet and ipv6 flag", func() { It("podman network create with ipv4 subnet and ipv6 flag", func() {
name := stringid.GenerateNonCryptoID() name := stringid.GenerateRandomID()
nc := podmanTest.Podman([]string{"network", "create", "--subnet", "10.11.12.0/24", "--ipv6", name}) nc := podmanTest.Podman([]string{"network", "create", "--subnet", "10.11.12.0/24", "--ipv6", name})
nc.WaitWithDefaultTimeout() nc.WaitWithDefaultTimeout()
Expect(nc).To(Exit(0)) Expect(nc).To(Exit(0))
@ -224,7 +224,7 @@ var _ = Describe("Podman network create", func() {
}) })
It("podman network create with empty subnet and ipv6 flag", func() { It("podman network create with empty subnet and ipv6 flag", func() {
name := stringid.GenerateNonCryptoID() name := stringid.GenerateRandomID()
nc := podmanTest.Podman([]string{"network", "create", "--ipv6", name}) nc := podmanTest.Podman([]string{"network", "create", "--ipv6", name})
nc.WaitWithDefaultTimeout() nc.WaitWithDefaultTimeout()
Expect(nc).To(Exit(0)) Expect(nc).To(Exit(0))
@ -238,19 +238,19 @@ var _ = Describe("Podman network create", func() {
}) })
It("podman network create with invalid IP", func() { It("podman network create with invalid IP", func() {
nc := podmanTest.Podman([]string{"network", "create", "--subnet", "10.11.0/17000", stringid.GenerateNonCryptoID()}) nc := podmanTest.Podman([]string{"network", "create", "--subnet", "10.11.0/17000", stringid.GenerateRandomID()})
nc.WaitWithDefaultTimeout() nc.WaitWithDefaultTimeout()
Expect(nc).To(ExitWithError()) Expect(nc).To(ExitWithError())
}) })
It("podman network create with invalid gateway for subnet", func() { It("podman network create with invalid gateway for subnet", func() {
nc := podmanTest.Podman([]string{"network", "create", "--subnet", "10.11.12.0/24", "--gateway", "192.168.1.1", stringid.GenerateNonCryptoID()}) nc := podmanTest.Podman([]string{"network", "create", "--subnet", "10.11.12.0/24", "--gateway", "192.168.1.1", stringid.GenerateRandomID()})
nc.WaitWithDefaultTimeout() nc.WaitWithDefaultTimeout()
Expect(nc).To(ExitWithError()) Expect(nc).To(ExitWithError())
}) })
It("podman network create two networks with same name should fail", func() { It("podman network create two networks with same name should fail", func() {
netName := "same-" + stringid.GenerateNonCryptoID() netName := "same-" + stringid.GenerateRandomID()
nc := podmanTest.Podman([]string{"network", "create", netName}) nc := podmanTest.Podman([]string{"network", "create", netName})
nc.WaitWithDefaultTimeout() nc.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(netName) defer podmanTest.removeNetwork(netName)
@ -262,13 +262,13 @@ var _ = Describe("Podman network create", func() {
}) })
It("podman network create two networks with same subnet should fail", func() { It("podman network create two networks with same subnet should fail", func() {
netName1 := "sub1-" + stringid.GenerateNonCryptoID() netName1 := "sub1-" + stringid.GenerateRandomID()
nc := podmanTest.Podman([]string{"network", "create", "--subnet", "10.11.13.0/24", netName1}) nc := podmanTest.Podman([]string{"network", "create", "--subnet", "10.11.13.0/24", netName1})
nc.WaitWithDefaultTimeout() nc.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(netName1) defer podmanTest.removeNetwork(netName1)
Expect(nc).Should(Exit(0)) Expect(nc).Should(Exit(0))
netName2 := "sub2-" + stringid.GenerateNonCryptoID() netName2 := "sub2-" + stringid.GenerateRandomID()
ncFail := podmanTest.Podman([]string{"network", "create", "--subnet", "10.11.13.0/24", netName2}) ncFail := podmanTest.Podman([]string{"network", "create", "--subnet", "10.11.13.0/24", netName2})
ncFail.WaitWithDefaultTimeout() ncFail.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(netName2) defer podmanTest.removeNetwork(netName2)
@ -276,13 +276,13 @@ var _ = Describe("Podman network create", func() {
}) })
It("podman network create two IPv6 networks with same subnet should fail", func() { It("podman network create two IPv6 networks with same subnet should fail", func() {
netName1 := "subipv61-" + stringid.GenerateNonCryptoID() netName1 := "subipv61-" + stringid.GenerateRandomID()
nc := podmanTest.Podman([]string{"network", "create", "--subnet", "fd00:4:4:4:4::/64", "--ipv6", netName1}) nc := podmanTest.Podman([]string{"network", "create", "--subnet", "fd00:4:4:4:4::/64", "--ipv6", netName1})
nc.WaitWithDefaultTimeout() nc.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(netName1) defer podmanTest.removeNetwork(netName1)
Expect(nc).Should(Exit(0)) Expect(nc).Should(Exit(0))
netName2 := "subipv62-" + stringid.GenerateNonCryptoID() netName2 := "subipv62-" + stringid.GenerateRandomID()
ncFail := podmanTest.Podman([]string{"network", "create", "--subnet", "fd00:4:4:4:4::/64", "--ipv6", netName2}) ncFail := podmanTest.Podman([]string{"network", "create", "--subnet", "fd00:4:4:4:4::/64", "--ipv6", netName2})
ncFail.WaitWithDefaultTimeout() ncFail.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(netName2) defer podmanTest.removeNetwork(netName2)
@ -296,7 +296,7 @@ var _ = Describe("Podman network create", func() {
}) })
It("podman network create with mtu option", func() { It("podman network create with mtu option", func() {
net := "mtu-test" + stringid.GenerateNonCryptoID() net := "mtu-test" + stringid.GenerateRandomID()
nc := podmanTest.Podman([]string{"network", "create", "--opt", "mtu=9000", net}) nc := podmanTest.Podman([]string{"network", "create", "--opt", "mtu=9000", net})
nc.WaitWithDefaultTimeout() nc.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(net) defer podmanTest.removeNetwork(net)
@ -309,7 +309,7 @@ var _ = Describe("Podman network create", func() {
}) })
It("podman network create with vlan option", func() { It("podman network create with vlan option", func() {
net := "vlan-test" + stringid.GenerateNonCryptoID() net := "vlan-test" + stringid.GenerateRandomID()
nc := podmanTest.Podman([]string{"network", "create", "--opt", "vlan=9", net}) nc := podmanTest.Podman([]string{"network", "create", "--opt", "vlan=9", net})
nc.WaitWithDefaultTimeout() nc.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(net) defer podmanTest.removeNetwork(net)
@ -322,7 +322,7 @@ var _ = Describe("Podman network create", func() {
}) })
It("podman network create with invalid option", func() { It("podman network create with invalid option", func() {
net := "invalid-test" + stringid.GenerateNonCryptoID() net := "invalid-test" + stringid.GenerateRandomID()
nc := podmanTest.Podman([]string{"network", "create", "--opt", "foo=bar", net}) nc := podmanTest.Podman([]string{"network", "create", "--opt", "foo=bar", net})
nc.WaitWithDefaultTimeout() nc.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(net) defer podmanTest.removeNetwork(net)
@ -331,7 +331,7 @@ var _ = Describe("Podman network create", func() {
It("podman CNI network create with internal should not have dnsname", func() { It("podman CNI network create with internal should not have dnsname", func() {
SkipIfNetavark(podmanTest) SkipIfNetavark(podmanTest)
net := "internal-test" + stringid.GenerateNonCryptoID() net := "internal-test" + stringid.GenerateRandomID()
nc := podmanTest.Podman([]string{"network", "create", "--internal", net}) nc := podmanTest.Podman([]string{"network", "create", "--internal", net})
nc.WaitWithDefaultTimeout() nc.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(net) defer podmanTest.removeNetwork(net)
@ -349,7 +349,7 @@ var _ = Describe("Podman network create", func() {
It("podman Netavark network create with internal should have dnsname", func() { It("podman Netavark network create with internal should have dnsname", func() {
SkipIfCNI(podmanTest) SkipIfCNI(podmanTest)
net := "internal-test" + stringid.GenerateNonCryptoID() net := "internal-test" + stringid.GenerateRandomID()
nc := podmanTest.Podman([]string{"network", "create", "--internal", net}) nc := podmanTest.Podman([]string{"network", "create", "--internal", net})
nc.WaitWithDefaultTimeout() nc.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(net) defer podmanTest.removeNetwork(net)
@ -375,7 +375,7 @@ var _ = Describe("Podman network create", func() {
}) })
It("podman network create with multiple subnets", func() { It("podman network create with multiple subnets", func() {
name := "subnets-" + stringid.GenerateNonCryptoID() name := "subnets-" + stringid.GenerateRandomID()
subnet1 := "10.10.0.0/24" subnet1 := "10.10.0.0/24"
subnet2 := "10.10.1.0/24" subnet2 := "10.10.1.0/24"
nc := podmanTest.Podman([]string{"network", "create", "--subnet", subnet1, "--subnet", subnet2, name}) nc := podmanTest.Podman([]string{"network", "create", "--subnet", subnet1, "--subnet", subnet2, name})
@ -393,7 +393,7 @@ var _ = Describe("Podman network create", func() {
}) })
It("podman network create with multiple subnets dual stack", func() { It("podman network create with multiple subnets dual stack", func() {
name := "subnets-" + stringid.GenerateNonCryptoID() name := "subnets-" + stringid.GenerateRandomID()
subnet1 := "10.10.2.0/24" subnet1 := "10.10.2.0/24"
subnet2 := "fd52:2a5a:747e:3acd::/64" subnet2 := "fd52:2a5a:747e:3acd::/64"
nc := podmanTest.Podman([]string{"network", "create", "--subnet", subnet1, "--subnet", subnet2, name}) nc := podmanTest.Podman([]string{"network", "create", "--subnet", subnet1, "--subnet", subnet2, name})
@ -411,7 +411,7 @@ var _ = Describe("Podman network create", func() {
}) })
It("podman network create with multiple subnets dual stack with gateway and range", func() { It("podman network create with multiple subnets dual stack with gateway and range", func() {
name := "subnets-" + stringid.GenerateNonCryptoID() name := "subnets-" + stringid.GenerateRandomID()
subnet1 := "10.10.3.0/24" subnet1 := "10.10.3.0/24"
gw1 := "10.10.3.10" gw1 := "10.10.3.10"
range1 := "10.10.3.0/26" range1 := "10.10.3.0/26"
@ -436,7 +436,7 @@ var _ = Describe("Podman network create", func() {
}) })
It("podman network create invalid options with multiple subnets", func() { It("podman network create invalid options with multiple subnets", func() {
name := "subnets-" + stringid.GenerateNonCryptoID() name := "subnets-" + stringid.GenerateRandomID()
subnet1 := "10.10.3.0/24" subnet1 := "10.10.3.0/24"
gw1 := "10.10.3.10" gw1 := "10.10.3.10"
gw2 := "fd52:2a5a:747e:3acf::10" gw2 := "fd52:2a5a:747e:3acf::10"

40
test/e2e/network_test.go
View File

@ -113,7 +113,7 @@ var _ = Describe("Podman network", func() {
}) })
It("podman network list --filter labels", func() { It("podman network list --filter labels", func() {
net1 := "labelnet" + stringid.GenerateNonCryptoID() net1 := "labelnet" + stringid.GenerateRandomID()
label1 := "testlabel1=abc" label1 := "testlabel1=abc"
label2 := "abcdef" label2 := "abcdef"
session := podmanTest.Podman([]string{"network", "create", "--label", label1, net1}) session := podmanTest.Podman([]string{"network", "create", "--label", label1, net1})
@ -121,7 +121,7 @@ var _ = Describe("Podman network", func() {
defer podmanTest.removeNetwork(net1) defer podmanTest.removeNetwork(net1)
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))
net2 := "labelnet" + stringid.GenerateNonCryptoID() net2 := "labelnet" + stringid.GenerateRandomID()
session = podmanTest.Podman([]string{"network", "create", "--label", label1, "--label", label2, net2}) session = podmanTest.Podman([]string{"network", "create", "--label", label1, "--label", label2, net2})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(net2) defer podmanTest.removeNetwork(net2)
@ -141,7 +141,7 @@ var _ = Describe("Podman network", func() {
}) })
It("podman network list --filter invalid value", func() { It("podman network list --filter invalid value", func() {
net := "net" + stringid.GenerateNonCryptoID() net := "net" + stringid.GenerateRandomID()
session := podmanTest.Podman([]string{"network", "create", net}) session := podmanTest.Podman([]string{"network", "create", net})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(net) defer podmanTest.removeNetwork(net)
@ -294,7 +294,7 @@ var _ = Describe("Podman network", func() {
}) })
It("podman inspect container single CNI network", func() { It("podman inspect container single CNI network", func() {
netName := "net-" + stringid.GenerateNonCryptoID() netName := "net-" + stringid.GenerateRandomID()
network := podmanTest.Podman([]string{"network", "create", "--subnet", "10.50.50.0/24", netName}) network := podmanTest.Podman([]string{"network", "create", "--subnet", "10.50.50.0/24", netName})
network.WaitWithDefaultTimeout() network.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(netName) defer podmanTest.removeNetwork(netName)
@ -324,13 +324,13 @@ var _ = Describe("Podman network", func() {
}) })
It("podman inspect container two CNI networks (container not running)", func() { It("podman inspect container two CNI networks (container not running)", func() {
netName1 := "net1-" + stringid.GenerateNonCryptoID() netName1 := "net1-" + stringid.GenerateRandomID()
network1 := podmanTest.Podman([]string{"network", "create", netName1}) network1 := podmanTest.Podman([]string{"network", "create", netName1})
network1.WaitWithDefaultTimeout() network1.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(netName1) defer podmanTest.removeNetwork(netName1)
Expect(network1).Should(Exit(0)) Expect(network1).Should(Exit(0))
netName2 := "net2-" + stringid.GenerateNonCryptoID() netName2 := "net2-" + stringid.GenerateRandomID()
network2 := podmanTest.Podman([]string{"network", "create", netName2}) network2 := podmanTest.Podman([]string{"network", "create", netName2})
network2.WaitWithDefaultTimeout() network2.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(netName2) defer podmanTest.removeNetwork(netName2)
@ -361,13 +361,13 @@ var _ = Describe("Podman network", func() {
}) })
It("podman inspect container two CNI networks", func() { It("podman inspect container two CNI networks", func() {
netName1 := "net1-" + stringid.GenerateNonCryptoID() netName1 := "net1-" + stringid.GenerateRandomID()
network1 := podmanTest.Podman([]string{"network", "create", "--subnet", "10.50.51.0/25", netName1}) network1 := podmanTest.Podman([]string{"network", "create", "--subnet", "10.50.51.0/25", netName1})
network1.WaitWithDefaultTimeout() network1.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(netName1) defer podmanTest.removeNetwork(netName1)
Expect(network1).Should(Exit(0)) Expect(network1).Should(Exit(0))
netName2 := "net2-" + stringid.GenerateNonCryptoID() netName2 := "net2-" + stringid.GenerateRandomID()
network2 := podmanTest.Podman([]string{"network", "create", "--subnet", "10.50.51.128/26", netName2}) network2 := podmanTest.Podman([]string{"network", "create", "--subnet", "10.50.51.128/26", netName2})
network2.WaitWithDefaultTimeout() network2.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(netName2) defer podmanTest.removeNetwork(netName2)
@ -403,7 +403,7 @@ var _ = Describe("Podman network", func() {
It("podman network remove after disconnect when container initially created with the network", func() { It("podman network remove after disconnect when container initially created with the network", func() {
container := "test" container := "test"
network := "foo" + stringid.GenerateNonCryptoID() network := "foo" + stringid.GenerateRandomID()
session := podmanTest.Podman([]string{"network", "create", network}) session := podmanTest.Podman([]string{"network", "create", network})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
@ -430,7 +430,7 @@ var _ = Describe("Podman network", func() {
}) })
It("podman network remove --force with pod", func() { It("podman network remove --force with pod", func() {
netName := "net-" + stringid.GenerateNonCryptoID() netName := "net-" + stringid.GenerateRandomID()
session := podmanTest.Podman([]string{"network", "create", netName}) session := podmanTest.Podman([]string{"network", "create", netName})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(netName) defer podmanTest.removeNetwork(netName)
@ -466,13 +466,13 @@ var _ = Describe("Podman network", func() {
}) })
It("podman network remove with two networks", func() { It("podman network remove with two networks", func() {
netName1 := "net1-" + stringid.GenerateNonCryptoID() netName1 := "net1-" + stringid.GenerateRandomID()
session := podmanTest.Podman([]string{"network", "create", netName1}) session := podmanTest.Podman([]string{"network", "create", netName1})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(netName1) defer podmanTest.removeNetwork(netName1)
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))
netName2 := "net2-" + stringid.GenerateNonCryptoID() netName2 := "net2-" + stringid.GenerateRandomID()
session = podmanTest.Podman([]string{"network", "create", netName2}) session = podmanTest.Podman([]string{"network", "create", netName2})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(netName2) defer podmanTest.removeNetwork(netName2)
@ -591,7 +591,7 @@ var _ = Describe("Podman network", func() {
It("podman network create/remove macvlan", func() { It("podman network create/remove macvlan", func() {
// Netavark currently does not do dhcp so the this test fails // Netavark currently does not do dhcp so the this test fails
SkipIfNetavark(podmanTest) SkipIfNetavark(podmanTest)
net := "macvlan" + stringid.GenerateNonCryptoID() net := "macvlan" + stringid.GenerateRandomID()
nc := podmanTest.Podman([]string{"network", "create", "--macvlan", "lo", net}) nc := podmanTest.Podman([]string{"network", "create", "--macvlan", "lo", net})
nc.WaitWithDefaultTimeout() nc.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(net) defer podmanTest.removeNetwork(net)
@ -605,7 +605,7 @@ var _ = Describe("Podman network", func() {
It("podman network create/remove macvlan as driver (-d) no device name", func() { It("podman network create/remove macvlan as driver (-d) no device name", func() {
// Netavark currently does not do dhcp so the this test fails // Netavark currently does not do dhcp so the this test fails
SkipIfNetavark(podmanTest) SkipIfNetavark(podmanTest)
net := "macvlan" + stringid.GenerateNonCryptoID() net := "macvlan" + stringid.GenerateRandomID()
nc := podmanTest.Podman([]string{"network", "create", "-d", "macvlan", net}) nc := podmanTest.Podman([]string{"network", "create", "-d", "macvlan", net})
nc.WaitWithDefaultTimeout() nc.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(net) defer podmanTest.removeNetwork(net)
@ -632,7 +632,7 @@ var _ = Describe("Podman network", func() {
It("podman network create/remove macvlan as driver (-d) with device name", func() { It("podman network create/remove macvlan as driver (-d) with device name", func() {
// Netavark currently does not do dhcp so the this test fails // Netavark currently does not do dhcp so the this test fails
SkipIfNetavark(podmanTest) SkipIfNetavark(podmanTest)
net := "macvlan" + stringid.GenerateNonCryptoID() net := "macvlan" + stringid.GenerateRandomID()
nc := podmanTest.Podman([]string{"network", "create", "-d", "macvlan", "-o", "parent=lo", net}) nc := podmanTest.Podman([]string{"network", "create", "-d", "macvlan", "-o", "parent=lo", net})
nc.WaitWithDefaultTimeout() nc.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(net) defer podmanTest.removeNetwork(net)
@ -659,7 +659,7 @@ var _ = Describe("Podman network", func() {
}) })
It("podman network exists", func() { It("podman network exists", func() {
net := "net" + stringid.GenerateNonCryptoID() net := "net" + stringid.GenerateRandomID()
session := podmanTest.Podman([]string{"network", "create", net}) session := podmanTest.Podman([]string{"network", "create", net})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(net) defer podmanTest.removeNetwork(net)
@ -669,13 +669,13 @@ var _ = Describe("Podman network", func() {
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))
session = podmanTest.Podman([]string{"network", "exists", stringid.GenerateNonCryptoID()}) session = podmanTest.Podman([]string{"network", "exists", stringid.GenerateRandomID()})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(1)) Expect(session).Should(Exit(1))
}) })
It("podman network create macvlan with network info and options", func() { It("podman network create macvlan with network info and options", func() {
net := "macvlan" + stringid.GenerateNonCryptoID() net := "macvlan" + stringid.GenerateRandomID()
nc := podmanTest.Podman([]string{"network", "create", "-d", "macvlan", "-o", "parent=lo", "-o", "mtu=1500", "--gateway", "192.168.1.254", "--subnet", "192.168.1.0/24", net}) nc := podmanTest.Podman([]string{"network", "create", "-d", "macvlan", "-o", "parent=lo", "-o", "mtu=1500", "--gateway", "192.168.1.254", "--subnet", "192.168.1.0/24", net})
nc.WaitWithDefaultTimeout() nc.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(net) defer podmanTest.removeNetwork(net)
@ -711,7 +711,7 @@ var _ = Describe("Podman network", func() {
if IsRemote() { if IsRemote() {
podmanTest.RestartRemoteService() podmanTest.RestartRemoteService()
} }
net1 := "macvlan" + stringid.GenerateNonCryptoID() + "net1" net1 := "macvlan" + stringid.GenerateRandomID() + "net1"
nc := podmanTest.Podman([]string{"network", "create", net1}) nc := podmanTest.Podman([]string{"network", "create", net1})
nc.WaitWithDefaultTimeout() nc.WaitWithDefaultTimeout()
@ -764,7 +764,7 @@ var _ = Describe("Podman network", func() {
// Run a container on one of them // Run a container on one of them
// Network Prune // Network Prune
// Check that one has been pruned, other remains // Check that one has been pruned, other remains
net := "macvlan" + stringid.GenerateNonCryptoID() net := "macvlan" + stringid.GenerateRandomID()
net1 := net + "1" net1 := net + "1"
net2 := net + "2" net2 := net + "2"
nc := podmanTest.Podman([]string{"network", "create", net1}) nc := podmanTest.Podman([]string{"network", "create", net1})

6
test/e2e/play_kube_test.go
View File

@ -2433,7 +2433,7 @@ spec:
err := generateKubeYaml("deployment", deployment, kubeYaml) err := generateKubeYaml("deployment", deployment, kubeYaml)
Expect(err).To(BeNil()) Expect(err).To(BeNil())
net := "playkube" + stringid.GenerateNonCryptoID() net := "playkube" + stringid.GenerateRandomID()
session := podmanTest.Podman([]string{"network", "create", "--subnet", "10.25.31.0/24", net}) session := podmanTest.Podman([]string{"network", "create", "--subnet", "10.25.31.0/24", net})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(net) defer podmanTest.removeNetwork(net)
@ -2475,8 +2475,8 @@ spec:
err := generateKubeYaml("pod", pod, kubeYaml) err := generateKubeYaml("pod", pod, kubeYaml)
Expect(err).To(BeNil()) Expect(err).To(BeNil())
net1 := "net1" + stringid.GenerateNonCryptoID() net1 := "net1" + stringid.GenerateRandomID()
net2 := "net2" + stringid.GenerateNonCryptoID() net2 := "net2" + stringid.GenerateRandomID()
net := podmanTest.Podman([]string{"network", "create", "--subnet", "10.0.11.0/24", net1}) net := podmanTest.Podman([]string{"network", "create", "--subnet", "10.0.11.0/24", net1})
net.WaitWithDefaultTimeout() net.WaitWithDefaultTimeout()

6
test/e2e/pod_ps_test.go
View File

@ -294,7 +294,7 @@ var _ = Describe("Podman ps", func() {
}) })
It("podman pod ps filter network", func() { It("podman pod ps filter network", func() {
net := stringid.GenerateNonCryptoID() net := stringid.GenerateRandomID()
session := podmanTest.Podman([]string{"network", "create", net}) session := podmanTest.Podman([]string{"network", "create", net})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))
@ -333,12 +333,12 @@ var _ = Describe("Podman ps", func() {
Expect(session.OutputToString()).To(Equal("podman")) Expect(session.OutputToString()).To(Equal("podman"))
} }
net1 := stringid.GenerateNonCryptoID() net1 := stringid.GenerateRandomID()
session = podmanTest.Podman([]string{"network", "create", net1}) session = podmanTest.Podman([]string{"network", "create", net1})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))
defer podmanTest.removeNetwork(net1) defer podmanTest.removeNetwork(net1)
net2 := stringid.GenerateNonCryptoID() net2 := stringid.GenerateRandomID()
session = podmanTest.Podman([]string{"network", "create", net2}) session = podmanTest.Podman([]string{"network", "create", net2})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))

6
test/e2e/ps_test.go
View File

@ -817,7 +817,7 @@ var _ = Describe("Podman ps", func() {
}) })
It("podman ps filter network", func() { It("podman ps filter network", func() {
net := stringid.GenerateNonCryptoID() net := stringid.GenerateRandomID()
session := podmanTest.Podman([]string{"network", "create", net}) session := podmanTest.Podman([]string{"network", "create", net})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))
@ -860,12 +860,12 @@ var _ = Describe("Podman ps", func() {
Expect(actual).To(Equal("podman")) Expect(actual).To(Equal("podman"))
} }
net1 := stringid.GenerateNonCryptoID() net1 := stringid.GenerateRandomID()
session = podmanTest.Podman([]string{"network", "create", net1}) session = podmanTest.Podman([]string{"network", "create", net1})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))
defer podmanTest.removeNetwork(net1) defer podmanTest.removeNetwork(net1)
net2 := stringid.GenerateNonCryptoID() net2 := stringid.GenerateRandomID()
session = podmanTest.Podman([]string{"network", "create", net2}) session = podmanTest.Podman([]string{"network", "create", net2})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))

10
test/e2e/run_networking_test.go
View File

@ -869,7 +869,7 @@ EXPOSE 2004-2005/tcp`, ALPINE)
}) })
It("podman run in custom CNI network with --static-ip", func() { It("podman run in custom CNI network with --static-ip", func() {
netName := stringid.GenerateNonCryptoID() netName := stringid.GenerateRandomID()
ipAddr := "10.25.30.128" ipAddr := "10.25.30.128"
create := podmanTest.Podman([]string{"network", "create", "--subnet", "10.25.30.0/24", netName}) create := podmanTest.Podman([]string{"network", "create", "--subnet", "10.25.30.0/24", netName})
create.WaitWithDefaultTimeout() create.WaitWithDefaultTimeout()
@ -884,7 +884,7 @@ EXPOSE 2004-2005/tcp`, ALPINE)
It("podman CNI network works across user ns", func() { It("podman CNI network works across user ns", func() {
SkipIfNetavark(podmanTest) SkipIfNetavark(podmanTest)
netName := stringid.GenerateNonCryptoID() netName := stringid.GenerateRandomID()
create := podmanTest.Podman([]string{"network", "create", netName}) create := podmanTest.Podman([]string{"network", "create", netName})
create.WaitWithDefaultTimeout() create.WaitWithDefaultTimeout()
Expect(create).Should(Exit(0)) Expect(create).Should(Exit(0))
@ -933,7 +933,7 @@ EXPOSE 2004-2005/tcp`, ALPINE)
}) })
It("podman run with new:pod and static-ip", func() { It("podman run with new:pod and static-ip", func() {
netName := stringid.GenerateNonCryptoID() netName := stringid.GenerateRandomID()
ipAddr := "10.25.40.128" ipAddr := "10.25.40.128"
podname := "testpod" podname := "testpod"
create := podmanTest.Podman([]string{"network", "create", "--subnet", "10.25.40.0/24", netName}) create := podmanTest.Podman([]string{"network", "create", "--subnet", "10.25.40.0/24", netName})
@ -1121,7 +1121,7 @@ EXPOSE 2004-2005/tcp`, ALPINE)
// see https://github.com/containers/podman/issues/12972 // see https://github.com/containers/podman/issues/12972
It("podman run check network-alias works on networks without dns", func() { It("podman run check network-alias works on networks without dns", func() {
net := "dns" + stringid.GenerateNonCryptoID() net := "dns" + stringid.GenerateRandomID()
session := podmanTest.Podman([]string{"network", "create", "--disable-dns", net}) session := podmanTest.Podman([]string{"network", "create", "--disable-dns", net})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(net) defer podmanTest.removeNetwork(net)
@ -1135,7 +1135,7 @@ EXPOSE 2004-2005/tcp`, ALPINE)
It("podman run with ipam none driver", func() { It("podman run with ipam none driver", func() {
// Test fails, issue #13931 // Test fails, issue #13931
SkipIfNetavark(podmanTest) SkipIfNetavark(podmanTest)
net := "ipam" + stringid.GenerateNonCryptoID() net := "ipam" + stringid.GenerateRandomID()
session := podmanTest.Podman([]string{"network", "create", "--ipam-driver=none", net}) session := podmanTest.Podman([]string{"network", "create", "--ipam-driver=none", net})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
defer podmanTest.removeNetwork(net) defer podmanTest.removeNetwork(net)

2
test/e2e/run_staticip_test.go
View File

@ -66,7 +66,7 @@ var _ = Describe("Podman run with --ip flag", func() {
}) })
It("Podman run with specified static IPv6 has correct IP", func() { It("Podman run with specified static IPv6 has correct IP", func() {
netName := "ipv6-" + stringid.GenerateNonCryptoID() netName := "ipv6-" + stringid.GenerateRandomID()
ipv6 := "fd46:db93:aa76:ac37::10" ipv6 := "fd46:db93:aa76:ac37::10"
net := podmanTest.Podman([]string{"network", "create", "--subnet", "fd46:db93:aa76:ac37::/64", netName}) net := podmanTest.Podman([]string{"network", "create", "--subnet", "fd46:db93:aa76:ac37::/64", netName})
net.WaitWithDefaultTimeout() net.WaitWithDefaultTimeout()

4
test/e2e/run_test.go
View File

@ -222,7 +222,7 @@ var _ = Describe("Podman run", func() {
It("podman run a container with a --rootfs", func() { It("podman run a container with a --rootfs", func() {
rootfs := filepath.Join(tempdir, "rootfs") rootfs := filepath.Join(tempdir, "rootfs")
uls := filepath.Join("/", "usr", "local", "share") uls := filepath.Join("/", "usr", "local", "share")
uniqueString := stringid.GenerateNonCryptoID() uniqueString := stringid.GenerateRandomID()
testFilePath := filepath.Join(uls, uniqueString) testFilePath := filepath.Join(uls, uniqueString)
tarball := filepath.Join(tempdir, "rootfs.tar") tarball := filepath.Join(tempdir, "rootfs.tar")
@ -848,7 +848,7 @@ USER bin`, BB)
err = ioutil.WriteFile(hookJSONPath, []byte(hookJSON), 0644) err = ioutil.WriteFile(hookJSONPath, []byte(hookJSON), 0644)
Expect(err).ToNot(HaveOccurred()) Expect(err).ToNot(HaveOccurred())
random := stringid.GenerateNonCryptoID() random := stringid.GenerateRandomID()
hookScript := fmt.Sprintf(`#!/bin/sh hookScript := fmt.Sprintf(`#!/bin/sh
echo -n %s >%s echo -n %s >%s

4
test/e2e/volume_exists_test.go
View File

@ -34,7 +34,7 @@ var _ = Describe("Podman volume exists", func() {
}) })
It("podman volume exists", func() { It("podman volume exists", func() {
vol := "vol" + stringid.GenerateNonCryptoID() vol := "vol" + stringid.GenerateRandomID()
session := podmanTest.Podman([]string{"volume", "create", vol}) session := podmanTest.Podman([]string{"volume", "create", vol})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))
@ -43,7 +43,7 @@ var _ = Describe("Podman volume exists", func() {
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))
session = podmanTest.Podman([]string{"volume", "exists", stringid.GenerateNonCryptoID()}) session = podmanTest.Podman([]string{"volume", "exists", stringid.GenerateRandomID()})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(1)) Expect(session).Should(Exit(1))
}) })

6
test/e2e/volume_plugin_test.go
View File

@ -212,19 +212,19 @@ testvol5 = "/run/docker/plugins/testvol5.sock"`), 0o644)
plugin.WaitWithDefaultTimeout() plugin.WaitWithDefaultTimeout()
Expect(plugin).Should(Exit(0)) Expect(plugin).Should(Exit(0))
localvol := "local-" + stringid.GenerateNonCryptoID() localvol := "local-" + stringid.GenerateRandomID()
// create local volume // create local volume
session := podmanTest.Podman([]string{"volume", "create", localvol}) session := podmanTest.Podman([]string{"volume", "create", localvol})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).To(Exit(0)) Expect(session).To(Exit(0))
vol1 := "vol1-" + stringid.GenerateNonCryptoID() vol1 := "vol1-" + stringid.GenerateRandomID()
session = podmanTest.Podman([]string{"volume", "create", "--driver", pluginName, vol1}) session = podmanTest.Podman([]string{"volume", "create", "--driver", pluginName, vol1})
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).To(Exit(0)) Expect(session).To(Exit(0))
// now create volume in plugin without podman // now create volume in plugin without podman
vol2 := "vol2-" + stringid.GenerateNonCryptoID() vol2 := "vol2-" + stringid.GenerateRandomID()
plugin = podmanTest.Podman([]string{"exec", ctrName, "/usr/local/bin/testvol", "--sock-name", pluginName, "create", vol2}) plugin = podmanTest.Podman([]string{"exec", ctrName, "/usr/local/bin/testvol", "--sock-name", pluginName, "create", vol2})
plugin.WaitWithDefaultTimeout() plugin.WaitWithDefaultTimeout()
Expect(plugin).Should(Exit(0)) Expect(plugin).Should(Exit(0))