containers
/
podman
mirror of https://github.com/containers/podman.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Print "extracting" only on compressed file 

We should only print "extracting compressed file" when the file is
actually compressed

Signed-off-by: Ashley Cui <acui@redhat.com>
This commit is contained in:
Ashley Cui 2021-05-12 14:35:49 -04:00
parent 0ce6a65b39
commit 01f6e4b53e
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/machine/pull.go
View File

@ -162,7 +162,11 @@ func Decompress(localPath, uncompressedPath string) error {
return err return err
} }
if compressionType := archive.DetectCompression(sourceFile); compressionType.Extension() == "tar.xz" { compressionType := archive.DetectCompression(sourceFile)
if compressionType != archive.Uncompressed {
fmt.Println("Extracting compressed file")
}
if compressionType == archive.Xz {
return decompressXZ(localPath, uncompressedFileWriter) return decompressXZ(localPath, uncompressedFileWriter)
} }
return decompressEverythingElse(localPath, uncompressedFileWriter) return decompressEverythingElse(localPath, uncompressedFileWriter)
@ -172,7 +176,6 @@ func Decompress(localPath, uncompressedPath string) error {
// Maybe extracting then renameing is a good idea here.. // Maybe extracting then renameing is a good idea here..
// depends on xz: not pre-installed on mac, so it becomes a brew dependency // depends on xz: not pre-installed on mac, so it becomes a brew dependency
func decompressXZ(src string, output io.Writer) error { func decompressXZ(src string, output io.Writer) error {
fmt.Println("Extracting compressed file")
cmd := exec.Command("xzcat", "-k", src) cmd := exec.Command("xzcat", "-k", src)
//cmd := exec.Command("xz", "-d", "-k", "-v", src) //cmd := exec.Command("xz", "-d", "-k", "-v", src)
stdOut, err := cmd.StdoutPipe() stdOut, err := cmd.StdoutPipe()
@ -190,7 +193,6 @@ func decompressXZ(src string, output io.Writer) error {
} }
func decompressEverythingElse(src string, output io.Writer) error { func decompressEverythingElse(src string, output io.Writer) error {
fmt.Println("Extracting compressed file")
f, err := os.Open(src) f, err := os.Open(src)
if err != nil { if err != nil {
return err return err