Short options!

Any subcommand that has two or more booleon short options can
now combine those two options.  For example:

kpod rmi -af (Remove all images forceably)

Signed-off-by: baude <bbaude@redhat.com>

Closes: #100
Approved by: rhatdan

cmd/kpod/create.go

@@ -138,6 +138,7 @@ var createCommand = cli.Command{
 	Action:                 createCmd,
 	ArgsUsage:              "IMAGE [COMMAND [ARG...]]",
 	SkipArgReorder:         true,
+	UseShortOptionHandling: true,
 }
 
 func createCmd(c *cli.Context) error {

cmd/kpod/history.go

@@ -77,6 +77,7 @@ var (
 		Flags:                  historyFlags,
 		Action:                 historyCmd,
 		ArgsUsage:              "",
+		UseShortOptionHandling: true,
 	}
 )
 

cmd/kpod/images.go

@@ -78,6 +78,7 @@ var (
 		Flags:                  imagesFlags,
 		Action:                 imagesCmd,
 		ArgsUsage:              "",
+		UseShortOptionHandling: true,
 	}
 )
 

cmd/kpod/ps.go

@@ -139,6 +139,7 @@ var (
 		Flags:                  psFlags,
 		Action:                 psCmd,
 		ArgsUsage:              "",
+		UseShortOptionHandling: true,
 	}
 )
 

cmd/kpod/rm.go

@@ -29,6 +29,7 @@ var (
 		Flags:                  rmFlags,
 		Action:                 rmCmd,
 		ArgsUsage:              "",
+		UseShortOptionHandling: true,
 	}
 )
 

cmd/kpod/rmi.go

@@ -27,6 +27,7 @@ var (
 		Action:      rmiCmd,
 		ArgsUsage:   "IMAGE-NAME-OR-ID [...]",
 		Flags:       rmiFlags,
+		UseShortOptionHandling: true,
 	}
 )
 

cmd/kpod/run.go

@@ -20,6 +20,7 @@ var runCommand = cli.Command{
 	Action:                 runCmd,
 	ArgsUsage:              "IMAGE [COMMAND [ARG...]]",
 	SkipArgReorder:         true,
+	UseShortOptionHandling: true,
 }
 
 func runCmd(c *cli.Context) error {

cmd/kpod/start.go

@@ -40,6 +40,7 @@ var (
 		Flags:                  startFlags,
 		Action:                 startCmd,
 		ArgsUsage:              "CONTAINER-NAME [CONTAINER-NAME ...]",
+		UseShortOptionHandling: true,
 	}
 )
 

test/kpod_create.bats

@@ -21,3 +21,9 @@ function teardown() {
     echo "$output"
     [ "$status" -eq 0 ]
 }
+
+@test "ensure short options" {
+    run ${KPOD_BINARY} ${KPOD_OPTIONS} create -dt ${BB_GLIBC} ls
+    echo "$output"
+    [ "$status" -eq 0 ]
+}

test/kpod_history.bats

@@ -45,3 +45,9 @@ function setup() {
 	echo "$output"
 	[ "$status" -eq 0 ]
 }
+
+@test "kpod history short options" {
+	run ${KPOD_BINARY} ${KPOD_OPTIONS} history -qH $ALPINE
+	echo "$output"
+	[ "$status" -eq 0 ]
+}

test/kpod_images.bats

@@ -40,3 +40,9 @@ function teardown() {
     echo "$output"
     [ "$status" -eq 0 ]
 }
+
+@test "kpod images short options" {
+    run  ${KPOD_BINARY} ${KPOD_OPTIONS} images -qn
+    echo "$output"
+    [ "$status" -eq 0 ]
+}

test/kpod_ps.bats

@@ -120,3 +120,12 @@ function teardown() {
     [ "$status" -eq 0 ]
     run ${KPOD_BINARY} ${KPOD_OPTIONS} stop $ctr_id
 }
+
+@test "kpod ps short options" {
+    run ${KPOD_BINARY} ${KPOD_OPTIONS} run -d ${ALPINE} sleep 99
+    ctr_id="$output"
+    run bash -c ${KPOD_BINARY} ${KPOD_OPTIONS} ps -aqs
+    echo "$output"
+    [ "$status" -eq 0 ]
+    run ${KPOD_BINARY} ${KPOD_OPTIONS} stop $ctr_id
+}

test/kpod_rm.bats

@@ -60,12 +60,12 @@ function teardown() {
     [ "$status" -eq 0 ]
 }
 
-@test "remove all containers with one running" {
+@test "remove all containers with one running with short options" {
     ${KPOD_BINARY} ${KPOD_OPTIONS} create $BB ls
     ${KPOD_BINARY} ${KPOD_OPTIONS} create $BB ls -l
     ${KPOD_BINARY} ${KPOD_OPTIONS} create $BB whoami
     ${KPOD_BINARY} ${KPOD_OPTIONS} run -d ${ALPINE} sleep 30
-    run ${KPOD_BINARY} $KPOD_OPTIONS rm -a -f
+    run ${KPOD_BINARY} $KPOD_OPTIONS rm -af
     echo "$output"
     [ "$status" -eq 0 ]
 }

test/kpod_rmi.bats

@@ -43,10 +43,10 @@ function pullImages() {
 	[ "$status" -eq 0 ]
 }
 
-@test "kpod rmi all images forceably" {
+@test "kpod rmi all images forceably with short options" {
 	pullImages
 	${KPOD_BINARY} $KPOD_OPTIONS create ${IMAGE1} ls
-	run ${KPOD_BINARY} $KPOD_OPTIONS rmi -a -f
+	run ${KPOD_BINARY} $KPOD_OPTIONS rmi -af
 	echo "$output"
 	[ "$status" -eq 0 ]
 }

test/kpod_run.bats

@@ -16,6 +16,12 @@ function setup() {
     [ "$status" -eq 0 ]
 }
 
+@test "run a container based on local image with short options" {
+    run bash -c "${KPOD_BINARY} ${KPOD_OPTIONS} run -dt $BB ls"
+    echo "$output"
+    [ "$status" -eq 0 ]
+}
+
 @test "run a container based on a remote image" {
     run bash -c "${KPOD_BINARY} ${KPOD_OPTIONS} run ${BB_GLIBC} ls"
     echo "$output"
@@ -65,25 +71,22 @@ function setup() {
 }
 
 @test "run environment test" {
-
+    run bash -c "${KPOD_BINARY} ${KPOD_OPTIONS} run --env FOO=BAR ${ALPINE} printenv FOO | tr -d '\r'"
-    ${KPOD_BINARY} ${KPOD_OPTIONS} pull ${ALPINE}
-
-    run bash -c "${KPOD_BINARY} ${KPOD_OPTIONS} run -env FOO=BAR ${ALPINE} printenv FOO | tr -d '\r'"
     echo "$output"
     [ "$status" -eq 0 ]
     [ $output = "BAR" ]
 
-    run bash -c "${KPOD_BINARY} ${KPOD_OPTIONS} run -env PATH="/bin" ${ALPINE} printenv PATH | tr -d '\r'"
+    run bash -c "${KPOD_BINARY} ${KPOD_OPTIONS} run --env PATH="/bin" ${ALPINE} printenv PATH | tr -d '\r'"
     echo "$output"
     [ "$status" -eq 0 ]
     [ $output = "/bin" ]
 
-    run bash -c "export FOO=BAR; ${KPOD_BINARY} ${KPOD_OPTIONS} run -env FOO ${ALPINE} printenv FOO | tr -d '\r'"
+    run bash -c "export FOO=BAR; ${KPOD_BINARY} ${KPOD_OPTIONS} run --env FOO ${ALPINE} printenv FOO | tr -d '\r'"
     echo "$output"
     [ "$status" -eq 0 ]
     [ "$output" = "BAR" ]
 
-    run bash -c "${KPOD_BINARY} ${KPOD_OPTIONS} run -env FOO ${ALPINE} printenv"
+    run bash -c "${KPOD_BINARY} ${KPOD_OPTIONS} run --env FOO ${ALPINE} printenv"
     echo "$output"
     [ "$status" -ne 0 ]