From 499b8d13c57ea38c3347df8b310750772834ad89 Mon Sep 17 00:00:00 2001 From: Paul Holzinger Date: Thu, 6 Jul 2023 15:12:12 +0200 Subject: [PATCH] CI: remove build without cgo task Podman is basically unusable without cgo, checking if it compiles without adds no value and just tricks people into thinking it works when it does not. This means we do not need extra to NOP out a lot of cgo calls with functions that just return an error like `XXX is not supported without cgo`. Signed-off-by: Paul Holzinger --- .cirrus.yml | 2 -- Makefile | 7 ------- contrib/cirrus/runner.sh | 3 --- 3 files changed, 12 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index aed074e5be..57b00db508 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -379,8 +379,6 @@ alt_build_task: ALT_NAME: 'Build Each Commit' - env: ALT_NAME: 'Windows Cross' - - env: - ALT_NAME: 'Build Without CGO' - env: ALT_NAME: 'Alt Arch. Cross' # This task cannot make use of the shared repo.tbz artifact. diff --git a/Makefile b/Makefile index 9def57299d..14a703dd9e 100644 --- a/Makefile +++ b/Makefile @@ -451,13 +451,6 @@ local-cross: $(CROSS_BUILD_TARGETS) ## Cross compile podman binary for multiple .PHONY: cross cross: local-cross -.PHONY: build-no-cgo -build-no-cgo: - BUILDTAGS="containers_image_openpgp exclude_graphdriver_btrfs \ - exclude_graphdriver_devicemapper exclude_disk_quota" \ - CGO_ENABLED=0 \ - $(MAKE) all - .PHONY: completions completions: podman podman-remote # key = shell, value = completion filename diff --git a/contrib/cirrus/runner.sh b/contrib/cirrus/runner.sh index e08289d6bb..5fc98a5b2a 100755 --- a/contrib/cirrus/runner.sh +++ b/contrib/cirrus/runner.sh @@ -276,9 +276,6 @@ function _run_altbuild() { make podman-remote-release-windows_amd64.zip make podman.msi ;; - *Without*) - make build-no-cgo - ;; *RPM*) make package ;;