Makefile: remove useless HACK variable in e2e test

This doesn't do anything and I was unable to find anything in the git
history when or why it was added. The HACK var is just adding another
directory to the ginkgo argument list. As the only arg used was the
"./hack" dir which does not contain any go files it does nothing
besides confusing me about its purpose.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This commit is contained in:
Paul Holzinger 2024-04-25 17:55:53 +02:00
parent 537c21a49a
commit 5040c6e390
No known key found for this signature in database
GPG Key ID: EB145DD938A3CAF2
1 changed files with 4 additions and 4 deletions

View File

@ -625,15 +625,15 @@ ginkgo-run: .install.ginkgo
$(GINKGO) -vv $(TESTFLAGS) --tags "$(TAGS) remote" $(GINKGOTIMEOUT) --flake-attempts $(GINKGO_FLAKE_ATTEMPTS) \
--trace $(if $(findstring y,$(GINKGO_NO_COLOR)),--no-color,) \
$(GINKGO_JSON) $(if $(findstring y,$(GINKGO_PARALLEL)),-p,) $(if $(FOCUS),--focus "$(FOCUS)",) \
$(if $(FOCUS_FILE),--focus-file "$(FOCUS_FILE)",) $(GINKGOWHAT) $(HACK)
$(if $(FOCUS_FILE),--focus-file "$(FOCUS_FILE)",) $(GINKGOWHAT)
.PHONY: ginkgo
ginkgo:
$(MAKE) ginkgo-run TAGS="$(BUILDTAGS)" HACK=hack/.
$(MAKE) ginkgo-run TAGS="$(BUILDTAGS)"
.PHONY: ginkgo-remote
ginkgo-remote:
$(MAKE) ginkgo-run TAGS="$(REMOTETAGS) remote_testing" HACK=
$(MAKE) ginkgo-run TAGS="$(REMOTETAGS) remote_testing"
.PHONY: testbindings
testbindings: .install.ginkgo
@ -649,7 +649,7 @@ remoteintegration: test-binaries ginkgo-remote
localmachine:
# gitCommit needed by logformatter, to link to sources
@echo /define.gitCommit=$(GIT_COMMIT)
$(MAKE) ginkgo-run GINKGO_PARALLEL=n TAGS="$(REMOTETAGS)" GINKGO_FLAKE_ATTEMPTS=0 FOCUS_FILE=$(FOCUS_FILE) GINKGOWHAT=pkg/machine/e2e/. HACK=
$(MAKE) ginkgo-run GINKGO_PARALLEL=n TAGS="$(REMOTETAGS)" GINKGO_FLAKE_ATTEMPTS=0 FOCUS_FILE=$(FOCUS_FILE) GINKGOWHAT=pkg/machine/e2e/.
.PHONY: localsystem
localsystem: