system tests must pass

Signed-off-by: Brent Baude <bbaude@redhat.com>

.cirrus.yml

@@ -390,8 +390,6 @@ testing_task:
         - "build_each_commit"
         - "build_without_cgo"
 
-    allow_failures: $CI == 'true'
-
     # Only test build cache-images, if that's what's requested
     only_if: >-
         $CIRRUS_CHANGE_MESSAGE !=~ '.*CI:IMG.*' &&

cmd/podman/common/util.go

@@ -1,8 +1,11 @@
 package common
 
 import (
+	"fmt"
 	"strconv"
 
+	"github.com/spf13/cobra"
+
 	"github.com/cri-o/ocicni/pkg/ocicni"
 	"github.com/docker/go-connections/nat"
 	"github.com/pkg/errors"
@@ -41,3 +44,11 @@ func createPortBindings(ports []string) ([]ocicni.PortMapping, error) {
 	}
 	return portBindings, nil
 }
+
+// NoArgs returns an error if any args are included.
+func NoArgs(cmd *cobra.Command, args []string) error {
+	if len(args) > 0 {
+		return fmt.Errorf("`%s` takes no arguments", cmd.CommandPath())
+	}
+	return nil
+}

cmd/podman/containers/exists.go

@@ -17,8 +17,9 @@ var (
 		Long:  containerExistsDescription,
 		Example: `podman container exists containerID
   podman container exists myctr || podman run --name myctr [etc...]`,
-		RunE: exists,
-		Args: cobra.ExactArgs(1),
+		RunE:                  exists,
+		Args:                  cobra.ExactArgs(1),
+		DisableFlagsInUseLine: true,
 	}
 )
 

cmd/podman/containers/list.go

@@ -1,6 +1,7 @@
 package containers
 
 import (
+	"github.com/containers/libpod/cmd/podman/common"
 	"github.com/containers/libpod/cmd/podman/registry"
 	"github.com/containers/libpod/pkg/domain/entities"
 	"github.com/spf13/cobra"
@@ -11,7 +12,7 @@ var (
 	listCmd = &cobra.Command{
 		Use:     "list",
 		Aliases: []string{"ls"},
-		Args:    cobra.NoArgs,
+		Args:    common.NoArgs,
 		Short:   "List containers",
 		Long:    "Prints out information about the containers",
 		RunE:    ps,

cmd/podman/containers/port.go

@@ -109,7 +109,7 @@ func port(cmd *cobra.Command, args []string) error {
 				fmt.Printf("%d/%s -> %s:%d\n", v.ContainerPort, v.Protocol, hostIP, v.HostPort)
 				continue
 			}
-			if v == userPort {
+			if v.ContainerPort == userPort.ContainerPort {
 				fmt.Printf("%s:%d\n", hostIP, v.HostPort)
 				found = true
 				break

cmd/podman/containers/ps.go

@@ -12,6 +12,7 @@ import (
 
 	tm "github.com/buger/goterm"
 	"github.com/containers/buildah/pkg/formats"
+	"github.com/containers/libpod/cmd/podman/common"
 	"github.com/containers/libpod/cmd/podman/registry"
 	"github.com/containers/libpod/pkg/domain/entities"
 	"github.com/cri-o/ocicni/pkg/ocicni"
@@ -25,7 +26,7 @@ var (
 	psDescription = "Prints out information about the containers"
 	psCommand     = &cobra.Command{
 		Use:   "ps",
-		Args:  checkFlags,
+		Args:  common.NoArgs,
 		Short: "List containers",
 		Long:  psDescription,
 		RunE:  ps,
@@ -141,6 +142,9 @@ func getResponses() ([]entities.ListContainer, error) {
 
 func ps(cmd *cobra.Command, args []string) error {
 	var responses []psReporter
+	if err := checkFlags(cmd, args); err != nil {
+		return err
+	}
 	for _, f := range filters {
 		split := strings.SplitN(f, "=", 2)
 		if len(split) == 1 {

cmd/podman/images/exists.go

@@ -15,6 +15,7 @@ var (
 		RunE:  exists,
 		Example: `podman image exists ID
   podman image exists IMAGE && podman pull IMAGE`,
+		DisableFlagsInUseLine: true,
 	}
 )
 

cmd/podman/images/images.go

@@ -11,12 +11,13 @@ import (
 var (
 	// podman _images_  Alias for podman image _list_
 	imagesCmd = &cobra.Command{
-		Use:     strings.Replace(listCmd.Use, "list", "images", 1),
-		Args:    listCmd.Args,
-		Short:   listCmd.Short,
-		Long:    listCmd.Long,
-		RunE:    listCmd.RunE,
-		Example: strings.Replace(listCmd.Example, "podman image list", "podman images", -1),
+		Use:                   strings.Replace(listCmd.Use, "list", "images", 1),
+		Args:                  listCmd.Args,
+		Short:                 listCmd.Short,
+		Long:                  listCmd.Long,
+		RunE:                  listCmd.RunE,
+		Example:               strings.Replace(listCmd.Example, "podman image list", "podman images", -1),
+		DisableFlagsInUseLine: true,
 	}
 )
 

cmd/podman/images/list.go

@@ -32,7 +32,7 @@ type listFlagType struct {
 var (
 	// Command: podman image _list_
 	listCmd = &cobra.Command{
-		Use:     "list [flag] [IMAGE]",
+		Use:     "list [FLAGS] [IMAGE]",
 		Aliases: []string{"ls"},
 		Args:    cobra.MaximumNArgs(1),
 		Short:   "List images in local storage",
@@ -41,6 +41,7 @@ var (
 		Example: `podman image list --format json
   podman image list --sort repository --format "table {{.ID}} {{.Repository}} {{.Tag}}"
   podman image list --filter dangling=true`,
+		DisableFlagsInUseLine: true,
 	}
 
 	// Options to pull data

cmd/podman/images/prune.go

@@ -6,6 +6,7 @@ import (
 	"os"
 	"strings"
 
+	"github.com/containers/libpod/cmd/podman/common"
 	"github.com/containers/libpod/cmd/podman/registry"
 	"github.com/containers/libpod/pkg/domain/entities"
 	"github.com/pkg/errors"
@@ -18,7 +19,7 @@ var (
   If an image is not being used by a container, it will be removed from the system.`
 	pruneCmd = &cobra.Command{
 		Use:     "prune",
-		Args:    cobra.NoArgs,
+		Args:    common.NoArgs,
 		Short:   "Remove unused images",
 		Long:    pruneDescription,
 		RunE:    prune,

cmd/podman/main.go

@@ -7,7 +7,6 @@ import (
 	_ "github.com/containers/libpod/cmd/podman/healthcheck"
 	_ "github.com/containers/libpod/cmd/podman/images"
 	_ "github.com/containers/libpod/cmd/podman/manifest"
-	_ "github.com/containers/libpod/cmd/podman/networks"
 	_ "github.com/containers/libpod/cmd/podman/pods"
 	"github.com/containers/libpod/cmd/podman/registry"
 	_ "github.com/containers/libpod/cmd/podman/system"

cmd/podman/manifest/add.go

@@ -13,7 +13,7 @@ import (
 var (
 	manifestAddOpts = entities.ManifestAddOptions{}
 	addCmd          = &cobra.Command{
-		Use:   "add",
+		Use:   "add [flags] LIST LIST",
 		Short: "Add images to a manifest list or image index",
 		Long:  "Adds an image to a manifest list or image index.",
 		RunE:  add,

cmd/podman/manifest/create.go

@@ -13,7 +13,7 @@ import (
 var (
 	manifestCreateOpts = entities.ManifestCreateOptions{}
 	createCmd          = &cobra.Command{
-		Use:   "create",
+		Use:   "create [flags] LIST [IMAGE]",
 		Short: "Create manifest list or image index",
 		Long:  "Creates manifest lists or image indexes.",
 		RunE:  create,

cmd/podman/manifest/inspect.go

@@ -12,7 +12,7 @@ import (
 
 var (
 	inspectCmd = &cobra.Command{
-		Use:     "inspect IMAGE",
+		Use:     "inspect [flags] IMAGE",
 		Short:   "Display the contents of a manifest list or image index",
 		Long:    "Display the contents of a manifest list or image index.",
 		RunE:    inspect,

cmd/podman/networks/network.go

@@ -17,6 +17,9 @@ var (
 	}
 )
 
+// TODO add the following to main.go to get networks back onto the
+// command list.
+//_ "github.com/containers/libpod/cmd/podman/networks"
 func init() {
 	registry.Commands = append(registry.Commands, registry.CliCommand{
 		Mode:    []entities.EngineMode{entities.ABIMode},

cmd/podman/pods/create.go

@@ -24,7 +24,7 @@ var (
 
 	createCommand = &cobra.Command{
 		Use:   "create",
-		Args:  cobra.NoArgs,
+		Args:  common.NoArgs,
 		Short: "Create a new empty pod",
 		Long:  podCreateDescription,
 		RunE:  create,

cmd/podman/pods/exists.go

@@ -19,6 +19,7 @@ var (
 		Args:  cobra.ExactArgs(1),
 		Example: `podman pod exists podID
   podman pod exists mypod || podman pod create --name mypod`,
+		DisableFlagsInUseLine: true,
 	}
 )
 

cmd/podman/pods/ps.go

@@ -11,6 +11,7 @@ import (
 	"text/template"
 	"time"
 
+	"github.com/containers/libpod/cmd/podman/common"
 	"github.com/containers/libpod/cmd/podman/registry"
 	"github.com/containers/libpod/pkg/domain/entities"
 	"github.com/docker/go-units"
@@ -28,6 +29,7 @@ var (
 		Short:   "list pods",
 		Long:    psDescription,
 		RunE:    pods,
+		Args:    common.NoArgs,
 	}
 )
 

cmd/podman/root.go

@@ -34,7 +34,7 @@ Description:
 // UsageTemplate is the usage template for podman commands
 // This blocks the displaying of the global options. The main podman
 // command should not use this.
-const usageTemplate = `Usage(v2):{{if (and .Runnable (not .HasAvailableSubCommands))}}
+const usageTemplate = `Usage:{{if (and .Runnable (not .HasAvailableSubCommands))}}
   {{.UseLine}}{{end}}{{if .HasAvailableSubCommands}}
   {{.CommandPath}} [command]{{end}}{{if gt (len .Aliases) 0}}
 

cmd/podman/system/events.go

@@ -7,6 +7,7 @@ import (
 	"os"
 
 	"github.com/containers/buildah/pkg/formats"
+	"github.com/containers/libpod/cmd/podman/common"
 	"github.com/containers/libpod/cmd/podman/registry"
 	"github.com/containers/libpod/libpod/events"
 	"github.com/containers/libpod/pkg/domain/entities"
@@ -18,7 +19,7 @@ var (
 	eventsDescription = "Monitor podman events"
 	eventsCommand     = &cobra.Command{
 		Use:   "events",
-		Args:  cobra.NoArgs,
+		Args:  common.NoArgs,
 		Short: "Show podman events",
 		Long:  eventsDescription,
 		RunE:  eventsCmd,

cmd/podman/system/info.go

@@ -5,6 +5,7 @@ import (
 	"os"
 	"text/template"
 
+	"github.com/containers/libpod/cmd/podman/common"
 	"github.com/containers/libpod/cmd/podman/registry"
 	"github.com/containers/libpod/pkg/domain/entities"
 	"github.com/ghodss/yaml"
@@ -18,7 +19,7 @@ var (
 `
 	infoCommand = &cobra.Command{
 		Use:     "info",
-		Args:    cobra.NoArgs,
+		Args:    common.NoArgs,
 		Long:    infoDescription,
 		Short:   "Display podman system information",
 		RunE:    info,

cmd/podman/system/version.go

@@ -9,6 +9,7 @@ import (
 	"time"
 
 	"github.com/containers/buildah/pkg/formats"
+	"github.com/containers/libpod/cmd/podman/common"
 	"github.com/containers/libpod/cmd/podman/registry"
 	"github.com/containers/libpod/libpod/define"
 	"github.com/containers/libpod/pkg/domain/entities"
@@ -19,7 +20,7 @@ import (
 var (
 	versionCommand = &cobra.Command{
 		Use:   "version",
-		Args:  cobra.NoArgs,
+		Args:  common.NoArgs,
 		Short: "Display the Podman Version Information",
 		RunE:  version,
 		Annotations: map[string]string{

cmd/podman/volumes/list.go

@@ -9,6 +9,7 @@ import (
 	"strings"
 	"text/tabwriter"
 
+	"github.com/containers/libpod/cmd/podman/common"
 	"github.com/containers/libpod/cmd/podman/registry"
 	"github.com/containers/libpod/pkg/domain/entities"
 	"github.com/pkg/errors"
@@ -24,7 +25,7 @@ and the output format can be changed to JSON or a user specified Go template.`
 	lsCommand = &cobra.Command{
 		Use:     "ls",
 		Aliases: []string{"list"},
-		Args:    cobra.NoArgs,
+		Args:    common.NoArgs,
 		Short:   "List volumes",
 		Long:    volumeLsDescription,
 		RunE:    list,

cmd/podman/volumes/prune.go

@@ -7,6 +7,7 @@ import (
 	"os"
 	"strings"
 
+	"github.com/containers/libpod/cmd/podman/common"
 	"github.com/containers/libpod/cmd/podman/registry"
 	"github.com/containers/libpod/cmd/podman/utils"
 	"github.com/containers/libpod/pkg/domain/entities"
@@ -21,7 +22,7 @@ var (
   Note all data will be destroyed.`
 	pruneCommand = &cobra.Command{
 		Use:   "prune",
-		Args:  cobra.NoArgs,
+		Args:  common.NoArgs,
 		Short: "Remove all unused volumes",
 		Long:  volumePruneDescription,
 		RunE:  prune,

pkg/domain/infra/abi/containers.go

@@ -949,7 +949,7 @@ func (ic *ContainerEngine) Config(_ context.Context) (*config.Config, error) {
 
 func (ic *ContainerEngine) ContainerPort(ctx context.Context, nameOrId string, options entities.ContainerPortOptions) ([]*entities.ContainerPortReport, error) {
 	var reports []*entities.ContainerPortReport
-	ctrs, err := getContainersByContext(options.All, false, []string{nameOrId}, ic.Libpod)
+	ctrs, err := getContainersByContext(options.All, options.Latest, []string{nameOrId}, ic.Libpod)
 	if err != nil {
 		return nil, err
 	}

test/apiv2/10-images.at

@@ -7,15 +7,15 @@
 podman pull -q $IMAGE
 
 t GET libpod/images/json 200 \
-  .[0].Id~[0-9a-f]\\{64\\}
-iid=$(jq -r '.[0].Id' <<<"$output")
+  .[0].ID~[0-9a-f]\\{64\\}
+iid=$(jq -r '.[0].ID' <<<"$output")
 
 t GET libpod/images/$iid/exists                     204
 t GET libpod/images/$PODMAN_TEST_IMAGE_NAME/exists  204
 
 # FIXME: compare to actual podman info
 t GET libpod/images/json 200  \
-  .[0].Id=${iid}
+  .[0].ID=${iid}
 
 t GET libpod/images/$iid/json 200 \
   .Id=$iid \

test/system/005-info.bats

@@ -8,19 +8,19 @@ load helpers
     run_podman info
 
     expected_keys="
-buildahversion: *[0-9.]\\\+
+buildahVersion: *[0-9.]\\\+
 conmon:\\\s\\\+package:
 distribution:
-ociruntime:\\\s\\\+name:
+ociRuntime:\\\s\\\+name:
 os:
 rootless:
 registries:
 store:
-graphdrivername:
-graphroot:
-graphstatus:
-imagestore:\\\s\\\+number: 1
-runroot:
+graphDriverName:
+graphRoot:
+graphStatus:
+imageStore:\\\s\\\+number: 1
+runRoot:
 "
     while read expect; do
         is "$output" ".*$expect" "output includes '$expect'"

test/system/150-login.bats

@@ -165,6 +165,9 @@ function setup() {
 
 # Some push tests
 @test "podman push fail" {
+
+    skip "Not working for v2 yet"
+
     # Create an invalid authfile
     authfile=${PODMAN_LOGIN_WORKDIR}/auth-$(random_string 10).json
     rm -f $authfile
@@ -197,6 +200,9 @@ EOF
     #
     #   https://github.com/containers/skopeo/issues/651
     #
+
+    skip "Not working for v2 yet"
+
     run_podman pull busybox
 
     # Preserve its ID for later comparison against push/pulled image