containers
/
podman
mirror of https://github.com/containers/podman.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

healthcheck: reject empty commands 

An image with "HEALTHCHECK CMD ['']" is valid but as there is no command
defined the healthcheck will fail. Reject such a configuration.

Fixes #3507

Signed-off-by: Stefan Becker <chemobejk@gmail.com>
This commit is contained in:
Stefan Becker 2019-07-11 20:18:56 +03:00
parent 5caf218b11
commit 5ed2de158f
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libpod/healthcheck.go
View File

@ -123,6 +123,9 @@ func (c *Container) runHealthCheck() (HealthCheckStatus, error) {
// command supplied on command line - pass as-is // command supplied on command line - pass as-is
newCommand = hcCommand newCommand = hcCommand
} }
if len(newCommand) < 1 || newCommand[0] == "" {
return HealthCheckNotDefined, errors.Errorf("container %s has no defined healthcheck", c.ID())
}
captureBuffer := bufio.NewWriter(&capture) captureBuffer := bufio.NewWriter(&capture)
hcw := hcWriteCloser{ hcw := hcWriteCloser{
captureBuffer, captureBuffer,