run/create: reserve `-h` flag for hostname

Move the `-h` short flag from `--help` to `--hostname` for podman-run,
podman-create and podman-pod-create to be compatible with Docker.

Fixes: #1367
Signed-off-by: Valentin Rothberg <vrothberg@suse.com>

Closes: #1373
Approved by: rhatdan

cmd/podman/common.go

@@ -216,8 +216,12 @@ var createFlags = []cli.Flag{
 		Name:  "group-add",
 		Usage: "Add additional groups to join (default [])",
 	},
+	cli.BoolFlag{
+		Name:   "help",
+		Hidden: true,
+	},
 	cli.StringFlag{
-		Name:  "hostname",
+		Name:  "hostname, h",
 		Usage: "Set container hostname",
 	},
 	cli.StringFlag{

cmd/podman/create.go

@@ -49,6 +49,7 @@ var createCommand = cli.Command{
 	Flags:                  createFlags,
 	Action:                 createCmd,
 	ArgsUsage:              "IMAGE [COMMAND [ARG...]]",
+	HideHelp:               true,
 	SkipArgReorder:         true,
 	UseShortOptionHandling: true,
 }
@@ -57,6 +58,12 @@ func createCmd(c *cli.Context) error {
 	// TODO should allow user to create based off a directory on the host not just image
 	// Need CLI support for this
 
+	// Docker-compatibility: the "-h" flag for run/create is reserved for
+	// the hostname (see https://github.com/containers/libpod/issues/1367).
+	if c.Bool("help") {
+		cli.ShowCommandHelpAndExit(c, "run", 0)
+	}
+
 	if err := validateFlags(c, createFlags); err != nil {
 		return err
 	}

cmd/podman/pod_create.go

@@ -71,6 +71,7 @@ var podCreateCommand = cli.Command{
 	Description:            podCreateDescription,
 	Flags:                  podCreateFlags,
 	Action:                 podCreateCmd,
+	HideHelp:               true,
 	SkipArgReorder:         true,
 	UseShortOptionHandling: true,
 }
@@ -79,6 +80,12 @@ func podCreateCmd(c *cli.Context) error {
 	var options []libpod.PodCreateOption
 	var err error
 
+	// Docker-compatibility: the "-h" flag for run/create is reserved for
+	// the hostname (see https://github.com/containers/libpod/issues/1367).
+	if c.Bool("help") {
+		cli.ShowCommandHelpAndExit(c, "run", 0)
+	}
+
 	if err = validateFlags(c, createFlags); err != nil {
 		return err
 	}

cmd/podman/run.go

@@ -34,12 +34,20 @@ var runCommand = cli.Command{
 	Flags:                  runFlags,
 	Action:                 runCmd,
 	ArgsUsage:              "IMAGE [COMMAND [ARG...]]",
+	HideHelp:               true,
 	SkipArgReorder:         true,
 	UseShortOptionHandling: true,
 }
 
 func runCmd(c *cli.Context) error {
 	var imageName string
+
+	// Docker-compatibility: the "-h" flag for run/create is reserved for
+	// the hostname (see https://github.com/containers/libpod/issues/1367).
+	if c.Bool("help") {
+		cli.ShowCommandHelpAndExit(c, "run", 0)
+	}
+
 	if err := validateFlags(c, createFlags); err != nil {
 		return err
 	}

cmd/podman/run_test.go

@@ -17,9 +17,10 @@ var (
 	cmd         = []string{"podman", "test", "alpine"}
 	CLI         *cli.Context
 	testCommand = cli.Command{
-		Name:   "test",
+		Name:     "test",
-		Flags:  createFlags,
+		Flags:    createFlags,
-		Action: testCmd,
+		Action:   testCmd,
+		HideHelp: true,
 	}
 )