containers
/
podman
mirror of https://github.com/containers/podman.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix errcheck warnings on freebsd 

These two:

> libpod/container_internal_freebsd.go:183:33: Error return value of `c.runtime.state.UpdateContainer` is not checked (errcheck)
> 	c.runtime.state.UpdateContainer(nsCtr)
> 	                               ^
> pkg/specgen/generate/config_freebsd.go:51:12: Error return value is not checked (errcheck)
> 		addDevice(g, resolvedDevicePath)
> 		         ^

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This commit is contained in:
Kir Kolyshkin 2025-04-01 14:33:19 -07:00
parent 8fd7143e36
commit 851bd141af
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libpod/container_internal_freebsd.go
View File

@ -180,7 +180,9 @@ func (c *Container) addNetworkContainer(g *generate.Generator, ctr string) error
if err != nil { if err != nil {
return fmt.Errorf("retrieving dependency %s of container %s from state: %w", ctr, c.ID(), err) return fmt.Errorf("retrieving dependency %s of container %s from state: %w", ctr, c.ID(), err)
} }
c.runtime.state.UpdateContainer(nsCtr) if err := c.runtime.state.UpdateContainer(nsCtr); err != nil {
return err
}
if nsCtr.state.NetNS != "" { if nsCtr.state.NetNS != "" {
g.AddAnnotation("org.freebsd.parentJail", nsCtr.state.NetNS) g.AddAnnotation("org.freebsd.parentJail", nsCtr.state.NetNS)
} }

4
pkg/specgen/generate/config_freebsd.go
View File

@ -48,7 +48,9 @@ func DevicesFromPath(g *generate.Generator, devicePath string, config *config.Co
} }
if st.IsDir() { if st.IsDir() {
// For devfs, we need to add the directory as well // For devfs, we need to add the directory as well
addDevice(g, resolvedDevicePath) if err := addDevice(g, resolvedDevicePath); err != nil {
return err
}
found := false found := false
src := resolvedDevicePath src := resolvedDevicePath