containers
/
podman
mirror of https://github.com/containers/podman.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Quadlet - use specifier for unescaped values for templated container name 

The escaped version replaces - with / which creates an invalid container name
See https://github.com/containers/podman/issues/22874#issuecomment-2175559746

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
This commit is contained in:
Ygal Blum 2024-06-18 16:13:24 +03:00
parent afe55cded0
commit 91a5c0de2a
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/systemd/quadlet/quadlet.go
View File

@ -488,7 +488,7 @@ func ConvertContainer(container *parser.UnitFile, names map[string]string, isUse
if !ok || len(containerName) == 0 { if !ok || len(containerName) == 0 {
// By default, We want to name the container by the service name // By default, We want to name the container by the service name
if strings.Contains(container.Filename, "@") { if strings.Contains(container.Filename, "@") {
containerName = "systemd-%P_%I" containerName = "systemd-%p_%i"
} else { } else {
containerName = "systemd-%N" containerName = "systemd-%N"
} }

2
test/e2e/quadlet/template@.container
View File

@ -1,5 +1,5 @@
## assert-podman-final-args localhost/imagename ## assert-podman-final-args localhost/imagename
## assert-podman-args "--name=systemd-%P_%I" ## assert-podman-args "--name=systemd-%p_%i"
## assert-symlink want.service.wants/template@default.service ../template@.service ## assert-symlink want.service.wants/template@default.service ../template@.service
## assert-podman-args --env "FOO=bar" ## assert-podman-args --env "FOO=bar"

2
test/e2e/quadlet/template@instance.container
View File

@ -1,5 +1,5 @@
## assert-podman-final-args localhost/changed-image ## assert-podman-final-args localhost/changed-image
## assert-podman-args "--name=systemd-%P_%I" ## assert-podman-args "--name=systemd-%p_%i"
## assert-symlink want.service.wants/template@instance.service ../template@instance.service ## assert-symlink want.service.wants/template@instance.service ../template@instance.service
## assert-podman-args --env "FOO=bar" ## assert-podman-args --env "FOO=bar"