diff --git a/pkg/domain/infra/abi/terminal/sigproxy_commn.go b/pkg/domain/infra/abi/terminal/sigproxy_commn.go index 705808d5e7..629b2e9c33 100644 --- a/pkg/domain/infra/abi/terminal/sigproxy_commn.go +++ b/pkg/domain/infra/abi/terminal/sigproxy_commn.go @@ -28,9 +28,6 @@ func ProxySignals(ctr *libpod.Container) { go func() { for s := range sigBuffer { syscallSignal := s.(syscall.Signal) - if signal.IsSignalIgnoredBySigProxy(syscallSignal) { - continue - } if err := ctr.Kill(uint(syscallSignal)); err != nil { // If the container is no longer running/removed do not log it as error. diff --git a/pkg/domain/infra/tunnel/runtime.go b/pkg/domain/infra/tunnel/runtime.go index 05f8b00787..2a8aa8b258 100644 --- a/pkg/domain/infra/tunnel/runtime.go +++ b/pkg/domain/infra/tunnel/runtime.go @@ -46,9 +46,6 @@ func remoteProxySignals(ctrID string, killFunc func(string) error) { go func() { for s := range sigBuffer { syscallSignal := s.(syscall.Signal) - if signal.IsSignalIgnoredBySigProxy(syscallSignal) { - continue - } signalName, err := signal.ParseSysSignalToName(syscallSignal) if err != nil { logrus.Infof("Ceasing signal %v forwarding to container %s as it has stopped: %s", s, ctrID, err) diff --git a/pkg/signal/signal_common.go b/pkg/signal/signal_common.go index 1061058291..34e5b494e5 100644 --- a/pkg/signal/signal_common.go +++ b/pkg/signal/signal_common.go @@ -46,11 +46,14 @@ func ParseSignalNameOrNumber(rawSignal string) (syscall.Signal, error) { return -1, fmt.Errorf("invalid signal: %s", basename) } -// CatchAll catches all signals and relays them to the specified channel. +// CatchAll catches all signals (except the ones that make no sense to handle/forward, +// see isSignalIgnoredBySigProxy()) and relays them to the specified channel. func CatchAll(sigc chan os.Signal) { handledSigs := make([]os.Signal, 0, len(SignalMap)) for _, s := range SignalMap { - handledSigs = append(handledSigs, s) + if !isSignalIgnoredBySigProxy(s) { + handledSigs = append(handledSigs, s) + } } signal.Notify(sigc, handledSigs...) } diff --git a/pkg/signal/signal_linux.go b/pkg/signal/signal_linux.go index 5b07ccdd59..0df442b93f 100644 --- a/pkg/signal/signal_linux.go +++ b/pkg/signal/signal_linux.go @@ -89,8 +89,8 @@ var SignalMap = map[string]syscall.Signal{ "RTMAX": sigrtmax, } -// IsSignalIgnoredBySigProxy determines whether sig-proxy should ignore syscall signal -func IsSignalIgnoredBySigProxy(s syscall.Signal) bool { +// isSignalIgnoredBySigProxy determines whether sig-proxy should ignore syscall signal +func isSignalIgnoredBySigProxy(s syscall.Signal) bool { // Ignore SIGCHLD and SIGPIPE - these are most likely intended for the podman command itself. // SIGURG was added because of golang 1.14 and its preemptive changes causing more signals to "show up". // https://github.com/containers/podman/issues/5483 diff --git a/pkg/signal/signal_linux_mipsx.go b/pkg/signal/signal_linux_mipsx.go index f587c09a36..852bdf3b39 100644 --- a/pkg/signal/signal_linux_mipsx.go +++ b/pkg/signal/signal_linux_mipsx.go @@ -89,8 +89,8 @@ var SignalMap = map[string]syscall.Signal{ "RTMAX": sigrtmax, } -// IsSignalIgnoredBySigProxy determines whether sig-proxy should ignore syscall signal -func IsSignalIgnoredBySigProxy(s syscall.Signal) bool { +// isSignalIgnoredBySigProxy determines whether sig-proxy should ignore syscall signal +func isSignalIgnoredBySigProxy(s syscall.Signal) bool { // Ignore SIGCHLD and SIGPIPE - these are most likely intended for the podman command itself. // SIGURG was added because of golang 1.14 and its preemptive changes causing more signals to "show up". // https://github.com/containers/podman/issues/5483 diff --git a/pkg/signal/signal_unix.go b/pkg/signal/signal_unix.go index 6e1ed540ea..d5d22268ab 100644 --- a/pkg/signal/signal_unix.go +++ b/pkg/signal/signal_unix.go @@ -87,8 +87,8 @@ var SignalMap = map[string]syscall.Signal{ "RTMAX": sigrtmax, } -// IsSignalIgnoredBySigProxy determines whether sig-proxy should ignore syscall signal -func IsSignalIgnoredBySigProxy(s syscall.Signal) bool { +// isSignalIgnoredBySigProxy determines whether sig-proxy should ignore syscall signal +func isSignalIgnoredBySigProxy(s syscall.Signal) bool { // Ignore SIGCHLD and SIGPIPE - these are most likely intended for the podman command itself. // SIGURG was added because of golang 1.14 and its preemptive changes causing more signals to "show up". // https://github.com/containers/podman/issues/5483 diff --git a/pkg/signal/signal_unsupported.go b/pkg/signal/signal_unsupported.go index 96c0c8f990..3c0e187ff0 100644 --- a/pkg/signal/signal_unsupported.go +++ b/pkg/signal/signal_unsupported.go @@ -87,8 +87,8 @@ var SignalMap = map[string]syscall.Signal{ "RTMAX": sigrtmax, } -// IsSignalIgnoredBySigProxy determines whether to sig-proxy should ignore syscall signal +// isSignalIgnoredBySigProxy determines whether to sig-proxy should ignore syscall signal // keep the container running or not. In unsupported OS this should not ignore any syscall signal. -func IsSignalIgnoredBySigProxy(s syscall.Signal) bool { +func isSignalIgnoredBySigProxy(_ syscall.Signal) bool { return false }