containers
/
podman
mirror of https://github.com/containers/podman.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

getContainerNetworkInfo: lock netNsCtr before sync 

`syncContainer()` requires the container to be locked, otherwise we can
end up with undefined behavior.

[NO TESTS NEEDED]

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This commit is contained in:
Paul Holzinger 2021-06-22 16:06:25 +02:00
parent ed511d27d7
commit a84fa194b7
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libpod/networking_linux.go
View File

@ -888,6 +888,10 @@ func (c *Container) getContainerNetworkInfo() (*define.InspectNetworkSettings, e
if err != nil { if err != nil {
return nil, err return nil, err
} }
// see https://github.com/containers/podman/issues/10090
// the container has to be locked for syncContainer()
netNsCtr.lock.Lock()
defer netNsCtr.lock.Unlock()
// Have to sync to ensure that state is populated // Have to sync to ensure that state is populated
if err := netNsCtr.syncContainer(); err != nil { if err := netNsCtr.syncContainer(); err != nil {
return nil, err return nil, err