containers
/
podman
mirror of https://github.com/containers/podman.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Minor fix filtering images by label 

Added test to avoid future regressions

Fix #3163

Signed-off-by: Divyansh Kamboj <kambojdivyansh2000@gmail.com>
This commit is contained in:
Divyansh Kamboj 2019-05-20 21:15:47 +05:30
parent 18a953918e
commit c6f7066e77
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/podman/images.go
View File

@ -362,7 +362,7 @@ func CreateFilterFuncs(ctx context.Context, r *adapter.LocalRuntime, filters []s
var filterFuncs []imagefilters.ResultFilter var filterFuncs []imagefilters.ResultFilter
for _, filter := range filters { for _, filter := range filters {
splitFilter := strings.Split(filter, "=") splitFilter := strings.Split(filter, "=")
if len(splitFilter) != 2 { if len(splitFilter) < 2 {
return nil, errors.Errorf("invalid filter syntax %s", filter) return nil, errors.Errorf("invalid filter syntax %s", filter)
} }
switch splitFilter[0] { switch splitFilter[0] {

13
test/e2e/images_test.go
View File

@ -298,4 +298,17 @@ ENV foo=bar
Expect(session2.ExitCode()).To(Equal(0)) Expect(session2.ExitCode()).To(Equal(0))
Expect(len(session2.OutputToStringArray())).To(Equal(6)) Expect(len(session2.OutputToStringArray())).To(Equal(6))
}) })
It("podman images filter by label", func() {
SkipIfRemote()
dockerfile := `FROM docker.io/library/alpine:latest
LABEL version="1.0"
LABEL "com.example.vendor"="Example Vendor"
`
podmanTest.BuildImage(dockerfile, "test", "true")
session := podmanTest.Podman([]string{"images", "-f", "label=version=1.0"})
session.WaitWithDefaultTimeout()
Expect(session.ExitCode()).To(Equal(0))
Expect(len(session.OutputToStringArray())).To(Equal(2))
})
}) })