diff --git a/pkg/machine/applehv/machine.go b/pkg/machine/applehv/machine.go index 9777060c9d..da81d79c72 100644 --- a/pkg/machine/applehv/machine.go +++ b/pkg/machine/applehv/machine.go @@ -543,7 +543,7 @@ func (m *MacMachine) Start(name string, opts machine.StartOptions) error { defer ioEater.Close() // TODO handle returns from startHostNetworking - forwardSock, forwardState, err := m.startHostNetworking(ioEater) + forwardSock, forwardState, err := m.startHostNetworking() if err != nil { return err } @@ -816,7 +816,7 @@ func (m *MacMachine) setupStartHostNetworkingCmd() (gvproxy.GvproxyCommand, stri return cmd, forwardSock, state } -func (m *MacMachine) startHostNetworking(ioEater *os.File) (string, machine.APIForwardingState, error) { +func (m *MacMachine) startHostNetworking() (string, machine.APIForwardingState, error) { var ( forwardSock string state machine.APIForwardingState @@ -858,7 +858,6 @@ func (m *MacMachine) startHostNetworking(ioEater *os.File) (string, machine.APIF cmd, forwardSock, state := m.setupStartHostNetworkingCmd() c := cmd.Cmd(gvproxyBinary) - c.ExtraFiles = []*os.File{ioEater, ioEater, ioEater} if err := c.Start(); err != nil { return "", 0, fmt.Errorf("unable to execute: %q: %w", cmd.ToCmdline(), err) } diff --git a/pkg/machine/qemu/machine.go b/pkg/machine/qemu/machine.go index 5b1045823c..9134847522 100644 --- a/pkg/machine/qemu/machine.go +++ b/pkg/machine/qemu/machine.go @@ -1317,14 +1317,6 @@ func (v *MachineVM) startHostNetworking() (string, machine.APIForwardingState, e return "", machine.NoForwarding, err } - dnr, dnw, err := machine.GetDevNullFiles() - if err != nil { - return "", machine.NoForwarding, err - } - - defer dnr.Close() - defer dnw.Close() - cmd := gvproxy.NewGvproxyCommand() cmd.AddQemuSocket(fmt.Sprintf("unix://%s", v.QMPMonitor.Address.GetPath())) cmd.PidFile = v.PidFilePath.GetPath() @@ -1342,7 +1334,6 @@ func (v *MachineVM) startHostNetworking() (string, machine.APIForwardingState, e } c := cmd.Cmd(binary) - c.ExtraFiles = []*os.File{dnr, dnw, dnw} if err := c.Start(); err != nil { return "", 0, fmt.Errorf("unable to execute: %q: %w", cmd.ToCmdline(), err) }